hiqdev\hiart\stream\Request

Complexity

Total Complexity

11

Size/Duplication

Total Lines	92
Duplicated Lines	16.3 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

76.32%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	send()	0	16	2
A	prepareContextOptions()	0	19	2
A	convertContextOptions()	0	15	3
A	composeHeaderLines()	15	15	4

<?php
/**
 * Tools to use API as ActiveRecord for Yii2
 *
 * @link      https://github.com/hiqdev/yii2-hiart
 * @package   yii2-hiart
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\hiart\stream;

use hiqdev\hiart\AbstractRequest;
use hiqdev\hiart\RequestErrorException;
use yii\helpers\ArrayHelper;
use yii\helpers\Inflector;

/**
 * PHP stream request implementation.
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class Request extends AbstractRequest
{
    protected $responseClass = Response::class;

    public $defaultOptions = [
        'http' => [
            'ignore_errors' => true,
        ],
        'ssl' => [
            'verify_peer' => false,
        ],
    ];

    /**
     * @param array $options
     * @throws RequestErrorException
     * @return mixed
     */
    public function send($options = [])
    {
        try {
            $this->build();
            $context = stream_context_create($this->prepareContextOptions($options));
            $stream = fopen($this->getFullUri(), 'rb', false, $context);
            $responseContent = stream_get_contents($stream);
            // see http://php.net/manual/en/reserved.variables.httpresponseheader.php
            $responseHeaders = $http_response_header;
            fclose($stream);
        } catch (\Exception $e) {
            throw new RequestErrorException($e->getMessage(), $this, $e->getCode(), $e);
        }

        return new $this->responseClass($this, $responseContent, $responseHeaders);
    }

    protected function prepareContextOptions($options)
    {
        $requestOptions = [
            'http' => [
                'protocol_version' => $this->version,
                'method' => $this->method,
                'header' => static::composeHeaderLines($this->headers),
            ],
        ];

        if (isset($this->body)) {
            $requestOptions['http']['content'] = $this->body;
        }

        $dbOptions = $this->convertContextOptions($this->getDb()->config);

Accessing config on the interface hiqdev\hiart\ConnectionInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $sendOptions = $this->convertContextOptions($options);

        return ArrayHelper::merge($this->defaultOptions, $dbOptions, $requestOptions, $sendOptions);
    }

    /**
     * Composes stream context options from raw options.
     * @param array $options raw options
     * @return array stream context options
     */
    protected function convertContextOptions(array $options)
    {
        $contextOptions = [];
        foreach ($options as $key => $value) {
            $section = 'http';
            if (strpos($key, 'ssl') === 0) {
                $section = 'ssl';
                $key = substr($key, 3);
            }
            $key = Inflector::underscore($key);
            $contextOptions[$section][$key] = $value;
        }

        return $contextOptions;
    }

    public static function composeHeaderLines($headers)

This method seems to be duplicated in your project.

    {
        $result = [];
        foreach ($headers as $name => $values) {
            $name = str_replace(' ', '-', ucwords(str_replace('-', ' ', $name)));
            if (is_string($values)) {
                $values = [$values];
            }
            foreach ($values as $value) {
                $result[] = "$name: $value";
            }
        }

        return $result;
    }
}