Response - Code Metrics - Inspection of "Improved PHPDocs, refactored many different method..." - hiqdev/yii2-hiart - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2a1eef...f81184 )

by Dmitry

created 2017-01-25 17:11 UTC

Response A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Test Coverage

Coverage

92.59%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	10
lcom	2
cbo	1
dl	0
loc	59
ccs	25
cts	27
cp	0.9259
rs	10
c	1
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	__construct()	6	1
A	getRawData()	4	1
A	getHeader()	6	2
A	getStatusCode()	4	1
A	getReasonPhrase()	4	1
A	parseHeaders()	19	4

<?php
/**
 * Tools to use API as ActiveRecord for Yii2
 *
 * @link      https://github.com/hiqdev/yii2-hiart
 * @package   yii2-hiart
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\hiart\stream;

use hiqdev\hiart\AbstractResponse;

/**
 * PHP stream response implementation.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class Response extends AbstractResponse
{
    protected $rawData;

    protected $headers;

    protected $statusCode;

    protected $reasonPhrase;

    public function __construct(Request $request, $rawData, array $rawHeaders)
    {
        $this->request = $request;
        $this->rawData = $rawData;
        $this->headers = $this->parseHeaders($rawHeaders);
    }

    public function getRawData()
    {
        return $this->rawData;
    }

    public function getHeader($name)
    {
        $name = strtolower($name);

        return isset($this->headers[$name]) ? $this->headers[$name] : null;
    }

    public function parseHeaders($headers)
    {
        foreach ($headers as $header) {
            if (strncmp($header, 'HTTP/', 5) === 0) {
                $parts = explode(' ', $header, 3);
                $this->version = substr($parts[0], 5);
class MyClass { }

$x = new MyClass();
$x->foo = true;
                $this->statusCode = $parts[1];
                $this->reasonPhrase = $parts[2];
            } elseif (($pos = strpos($header, ':')) !== false) {
                $name = strtolower(trim(substr($header, 0, $pos)));
                $value = trim(substr($header, $pos + 1));
                $result[$name][] = $value;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            } else {
                $result['raw'][] = $header;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            }
        }

        return $result;
    }

    public function getStatusCode()
    {
        return $this->statusCode;
    }

    public function getReasonPhrase()
    {
        return $this->reasonPhrase;
    }
}


1		<?php
2		/**
3		* Tools to use API as ActiveRecord for Yii2
4		*
5		* @link https://github.com/hiqdev/yii2-hiart
6		* @package yii2-hiart
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hiqdev\hiart\stream;
12
13		use hiqdev\hiart\AbstractResponse;
14
15		/**
16		* PHP stream response implementation.
17		*
18		* @author Andrii Vasyliev <[email protected]>
19		*/
20		class Response extends AbstractResponse
21		{
22		protected $rawData;
23
24		protected $headers;
25
26		protected $statusCode;
27
28		protected $reasonPhrase;
29
30	2	public function __construct(Request $request, $rawData, array $rawHeaders)
31		{
32	2	$this->request = $request;
33	2	$this->rawData = $rawData;
34	2	$this->headers = $this->parseHeaders($rawHeaders);
35	2	}
36
37	2	public function getRawData()
38		{
39	2	return $this->rawData;
40		}
41
42	2	public function getHeader($name)
43		{
44	2	$name = strtolower($name);
45
46	2	return isset($this->headers[$name]) ? $this->headers[$name] : null;
47		}
48
49	2	public function parseHeaders($headers)
50		{
51	2	foreach ($headers as $header) {
52	2	if (strncmp($header, 'HTTP/', 5) === 0) {
53	2	$parts = explode(' ', $header, 3);
54	2	$this->version = substr($parts[0], 5);
		0 ignored issues – show Bug introduced 2017-01-24 17:39 UTC by Report Bug Copy Issue Report The property `version` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
55	2	$this->statusCode = $parts[1];
56	2	$this->reasonPhrase = $parts[2];
57	2	} elseif (($pos = strpos($header, ':')) !== false) {
58	2	$name = strtolower(trim(substr($header, 0, $pos)));
59	2	$value = trim(substr($header, $pos + 1));
60	2	$result[$name][] = $value;
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-01-24 17:39 UTC by Report Bug Copy Issue Report `$result` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$result = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
61		} else {
62	2	$result['raw'][] = $header;
		0 ignored issues – show Bug introduced 2017-01-24 17:39 UTC by Report Bug Copy Issue Report The variable `$result` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
63		}
64		}
65
66	2	return $result;
67		}
68
69	2	public function getStatusCode()
70		{
71	2	return $this->statusCode;
72		}
73
74		public function getReasonPhrase()
75		{
76		return $this->reasonPhrase;
77		}
78		}
79

hiqdev / yii2-hiart

Push — master ( 2a1eef...f81184 )

Response A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like