ExtendedCollection::collectData() - Code Metrics - Inspection of "Extended collection" - hiqdev/yii2-hiart - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#28)

unknown

created 2020-09-21 15:55 UTC

ExtendedCollection::collectData() A

↳ Parent: ExtendedCollection

Complexity

Conditions	5
Paths	5

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
cc	5
eloc	13
c	2
b	1
f	1
nc	5
nop	1
dl	0
loc	20
rs	9.5222

<?php
/**
 * ActiveRecord for API
 *
 * @link      https://github.com/hiqdev/yii2-hiart
 * @package   yii2-hiart
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\hiart;

use Closure;

/**
 * {@inheritdoc}
 */
class ExtendedCollection extends Collection
{
    /**
     * {@inheritdoc}
     */
    public $checkConsistency = false;

    /**
     * {@inheritdoc}
     */
    public function collectData($attributes = null)
    {
        $data = [];
        foreach ($this->models as $model) {
            if ($this->dataCollector instanceof Closure) {
                list($key, $row) = call_user_func($this->dataCollector, $model, $this);
            } else {
                $key = $model->getPrimaryKey();
                $row = $model->getAttributes($this->isConsistent() ? $attributes : $model->attributes);
                $row['recordModel'] = $model;
            }

            if ($key) {
                $data[$key] = $row;
            } else {
                $data[] = $row;
            }
        }

        return $data;
    }

    /**
     * {@inheritdoc}
     */
    protected function performOperation(string $command, array $data, array $queryOptions = []) : array
    {
        if ($this->isConsistent()) {
            return $this->first->batchQuery($command, $data, $queryOptions);
        }

        foreach ($data as $key => $record) {
            $records[$record['recordModel']->className()][$key] = $record;
        }

        $results = [];
        foreach ($records as $className => $d) {

            $row = reset($d);

            $model = $d['recordModel'];
            $results = array_merge($results, $model->batchQuery($command, $d, $queryOptions));
        }

        return $results;
    }
}


1			<?php
2			/**
3			* ActiveRecord for API
4			*
5			* @link https://github.com/hiqdev/yii2-hiart
6			* @package yii2-hiart
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\hiart;
12
13			use Closure;
14
15			/**
16			* {@inheritdoc}
17			*/
18			class ExtendedCollection extends Collection
19			{
20			/**
21			* {@inheritdoc}
22			*/
23			public $checkConsistency = false;
24
25			/**
26			* {@inheritdoc}
27			*/
28			public function collectData($attributes = null)
29			{
30			$data = [];
31			foreach ($this->models as $model) {
32			if ($this->dataCollector instanceof Closure) {
33			list($key, $row) = call_user_func($this->dataCollector, $model, $this);
34			} else {
35			$key = $model->getPrimaryKey();
36			$row = $model->getAttributes($this->isConsistent() ? $attributes : $model->attributes);
37			$row['recordModel'] = $model;
38			}
39
40			if ($key) {
41			$data[$key] = $row;
42			} else {
43			$data[] = $row;
44			}
45			}
46
47			return $data;
48			}
49
50			/**
51			* {@inheritdoc}
52			*/
53			protected function performOperation(string $command, array $data, array $queryOptions = []) : array
54			{
55			if ($this->isConsistent()) {
56			return $this->first->batchQuery($command, $data, $queryOptions);
57			}
58
59			foreach ($data as $key => $record) {
60			$records[$record['recordModel']->className()][$key] = $record;
61			}
62
63			$results = [];
64			foreach ($records as $className => $d) {
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-09-21 14:59 UTC by Report Bug Copy Issue Report The variable `$records` seems to be defined by a `foreach` iteration on line `59`. Are you sure the iterator is never empty, otherwise this variable is not defined? Loading history...
65			$row = reset($d);
			0 ignored issues – show Unused Code introduced 2020-09-21 14:59 UTC by Report Bug Copy Issue Report The assignment to `$row` is dead and can be removed. Loading history...
66			$model = $d['recordModel'];
67			$results = array_merge($results, $model->batchQuery($command, $d, $queryOptions));
68			}
69
70			return $results;
71			}
72			}
73

hiqdev / yii2-hiart

Pull Request — master (#28)

ExtendedCollection::collectData() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like