hiqdev\hiart\tests\functional\SimpleConfigTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	7	1
A	tearDown()	0	5	1
A	testGetDb()	0	6	1

<?php
/**
 * ActiveRecord for API
 *
 * @link      https://github.com/hiqdev/yii2-hiart
 * @package   yii2-hiart
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\hiart\tests\functional;

use hiqdev\hiart\curl\Request;
use hiqdev\hiart\rest\Connection;
use Yii;
use yii\console\Application;

class SimpleConfigTest extends \PHPUnit\Framework\TestCase
{
    protected $simpleConfig = [
        'id' => 'hiart-simple-config',
        'basePath' => __DIR__,
        'components' => [
            'hiart' => [
                'class' => Connection::class,
                'requestClass' => Request::class,
                'baseUri' => 'https://site.com/api/v3/',
            ],
        ],
    ];

    private $app;
    private $container;

    public function setUp()
    {
        $this->app = Yii::$app;
        $this->container = Yii::$container;
        Yii::$app = new Application($this->simpleConfig);
        Yii::$container = new yii\di\Container();
    }

    public function tearDown()
    {
        Yii::$app = $this->app;
        Yii::$container = $this->container;
    }

    public function testGetDb()
    {
        $db = Connection::getDb();
        $this->assertInstanceOf(Connection::class, $db);
        $this->assertSame(Request::class, $db->requestClass);

Accessing requestClass on the interface hiqdev\hiart\ConnectionInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }
}