Complex classes like AbstractQueryBuilder often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractQueryBuilder, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 22 | abstract class AbstractQueryBuilder extends \yii\base\Object implements QueryBuilderInterface |
||
| 23 | { |
||
| 24 | /** |
||
| 25 | * @var AbstractConnection |
||
| 26 | */ |
||
| 27 | public $db; |
||
| 28 | |||
| 29 | 2 | public function __construct($connection, $config = []) |
|
| 34 | |||
| 35 | /** |
||
| 36 | * Builds config array to create Command. |
||
| 37 | * @param Query $query |
||
| 38 | * @throws NotSupportedException |
||
| 39 | * @return array |
||
| 40 | */ |
||
| 41 | 2 | public function build(Query $query) |
|
| 45 | |||
| 46 | 3 | public function createRequest($query) |
|
| 52 | |||
| 53 | /** |
||
| 54 | * Prepares query before actual building. |
||
| 55 | * This function for you to redefine. |
||
| 56 | * It will be called before other build functions. |
||
| 57 | * @param Query $query |
||
| 58 | */ |
||
| 59 | 2 | public function prepare(Query $query) |
|
| 60 | { |
||
| 61 | 2 | return $query->prepare($this); |
|
|
|
|||
| 62 | } |
||
| 63 | |||
| 64 | /** |
||
| 65 | * This function is for you to provide your authentication. |
||
| 66 | * @param Query $query |
||
| 67 | */ |
||
| 68 | abstract public function buildAuth(Query $query); |
||
| 69 | |||
| 70 | abstract public function buildMethod(Query $query); |
||
| 71 | |||
| 72 | abstract public function buildUri(Query $query); |
||
| 73 | |||
| 74 | abstract public function buildHeaders(Query $query); |
||
| 75 | |||
| 76 | abstract public function buildProtocolVersion(Query $query); |
||
| 77 | |||
| 78 | abstract public function buildQueryParams(Query $query); |
||
| 79 | |||
| 80 | abstract public function buildFormParams(Query $query); |
||
| 81 | |||
| 82 | abstract public function buildBody(Query $query); |
||
| 83 | |||
| 84 | /** |
||
| 85 | * Creates insert request. |
||
| 86 | * @param string $table |
||
| 87 | * @param array $columns |
||
| 88 | * @param array $options |
||
| 89 | * @return AbstractRequest |
||
| 90 | */ |
||
| 91 | 1 | public function insert($table, $columns, array $options = []) |
|
| 95 | |||
| 96 | /** |
||
| 97 | * Creates update request. |
||
| 98 | * @param string $table |
||
| 99 | * @param array $columns |
||
| 100 | * @param array $options |
||
| 101 | * @return AbstractRequest |
||
| 102 | */ |
||
| 103 | public function update($table, $columns, $condition = [], array $options = []) |
||
| 109 | |||
| 110 | public function delete($table, $condition = [], array $options = []) |
||
| 116 | |||
| 117 | 1 | public function perform($action, $table, $body, $options = []) |
|
| 123 | |||
| 124 | 1 | public function createQuery($action, $table, array $options = []) |
|
| 130 | |||
| 131 | public function buildCondition($condition) |
||
| 168 | |||
| 169 | protected function buildHashCondition($condition) |
||
| 183 | |||
| 184 | protected function buildLikeCondition($operator, $operands) |
||
| 188 | |||
| 189 | protected function buildIlikeCondition($operator, $operands) |
||
| 193 | |||
| 194 | protected function buildCompareCondition($operator, $operands) |
||
| 202 | |||
| 203 | protected function buildAndCondition($operator, $operands) |
||
| 217 | |||
| 218 | protected function buildBetweenCondition($operator, $operands) |
||
| 222 | |||
| 223 | protected function buildInCondition($operator, $operands, $not = false) |
||
| 253 | |||
| 254 | protected function buildNotInCondition($operator, $operands) |
||
| 258 | |||
| 259 | protected function buildEqCondition($operator, $operands) |
||
| 265 | |||
| 266 | protected function buildNotEqCondition($operator, $operands) |
||
| 272 | |||
| 273 | protected function buildCompositeInCondition($operator, $columns, $values) |
||
| 277 | } |
||
| 278 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: