ConnectionTest::testErrorChecker() - Code Metrics - Inspection of "minor" - hiqdev/yii2-hiart - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c4e219...f561f8 )

by Andrii

created 2016-01-18 21:54 UTC

ConnectionTest::testErrorChecker() A

↳ Parent: ConnectionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php

/*
 * Tools to use API as ActiveRecord for Yii2
 *
 * @link      https://github.com/hiqdev/yii2-hiart
 * @package   yii2-hiart
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\hiart\tests\unit;

use GuzzleHttp\Psr7\Response;
use hiqdev\hiart\Connection;
use hiqdev\hiart\tests\Mock;
use Yii;

/**
 * Connection test class.
 */
class ConnectionTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var Connection
     */
    protected $object;

    /**
     * @var Mock
     */
    protected $mock;

    protected $site   = 'http://test.api.site/';
    protected $url    = 'test/url';
    protected $query  = ['a' => 'b'];
    protected $body   = ['c' => 'd'];
    protected $result = 'xyz result string';

    protected function setUp()
    {
        $response     = new Response(200, [], $this->result);
        $this->mock   = new Mock($response);
        $this->object = Yii::createObject([
            'class'   => Connection::className(),
            'handler' => $this->mock,
            'config'  => [
                'base_uri' => $this->site,
            ],
            'errorChecker' => function ($res) {

                return null;
            },
        ]);
    }

    protected function tearDown()
    {
    }

    public function testGet()
    {
        $result = $this->object->get($this->url, [], $this->body, false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertSame($this->result, $result);
        $this->assertSame('request',   $this->mock->name);
        $this->assertSame('GET',       $this->mock->args[0]);
        $this->assertSame($this->url,  $this->mock->args[1]);
        $this->assertSame($this->body, $this->mock->args[2]['form_params']);
    }

    public function testErrorChecker()
    {
        $this->object->setErrorChecker(function ($res) { return $res; });
        $this->setExpectedException('hiqdev\hiart\ErrorResponseException', $this->result);
        $this->object->get($this->url, [], $this->body, false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			/*
4			* Tools to use API as ActiveRecord for Yii2
5			*
6			* @link https://github.com/hiqdev/yii2-hiart
7			* @package yii2-hiart
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hiqdev\hiart\tests\unit;
13
14			use GuzzleHttp\Psr7\Response;
15			use hiqdev\hiart\Connection;
16			use hiqdev\hiart\tests\Mock;
17			use Yii;
18
19			/**
20			* Connection test class.
21			*/
22			class ConnectionTest extends \PHPUnit_Framework_TestCase
23			{
24			/**
25			* @var Connection
26			*/
27			protected $object;
28
29			/**
30			* @var Mock
31			*/
32			protected $mock;
33
34			protected $site = 'http://test.api.site/';
35			protected $url = 'test/url';
36			protected $query = ['a' => 'b'];
37			protected $body = ['c' => 'd'];
38			protected $result = 'xyz result string';
39
40			protected function setUp()
41			{
42			$response = new Response(200, [], $this->result);
43			$this->mock = new Mock($response);
44			$this->object = Yii::createObject([
45			'class' => Connection::className(),
46			'handler' => $this->mock,
47			'config' => [
48			'base_uri' => $this->site,
49			],
50			'errorChecker' => function ($res) {
			0 ignored issues – show Unused Code introduced 2016-01-18 21:57 UTC by Report Bug Copy Issue Report The parameter `$res` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
51			return null;
52			},
53			]);
54			}
55
56			protected function tearDown()
57			{
58			}
59
60			public function testGet()
61			{
62			$result = $this->object->get($this->url, [], $this->body, false);
			0 ignored issues – show Documentation introduced 2016-01-18 21:57 UTC by Report Bug Copy Issue Report `$this->body` is of type `array`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
63			$this->assertSame($this->result, $result);
64			$this->assertSame('request', $this->mock->name);
65			$this->assertSame('GET', $this->mock->args[0]);
66			$this->assertSame($this->url, $this->mock->args[1]);
67			$this->assertSame($this->body, $this->mock->args[2]['form_params']);
68			}
69
70			public function testErrorChecker()
71			{
72			$this->object->setErrorChecker(function ($res) { return $res; });
73			$this->setExpectedException('hiqdev\hiart\ErrorResponseException', $this->result);
74			$this->object->get($this->url, [], $this->body, false);
			0 ignored issues – show Documentation introduced 2016-01-18 21:57 UTC by Report Bug Copy Issue Report `$this->body` is of type `array`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
75			}
76			}
77

hiqdev / yii2-hiart

Push — master ( c4e219...f561f8 )

ConnectionTest::testErrorChecker() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like