AddToCartAction::run() - Code Metrics - Inspection of "Fixed `white screen` after `add-to-cart-dedicated`" - hiqdev/yii2-cart - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by Klochok

created 2019-06-25 17:10 UTC

AddToCartAction::run() B

↳ Parent: AddToCartAction

Complexity

Conditions	6
Paths	12

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
dl	0
loc	36
ccs	0
cts	28
cp	0
rs	8.7217
c	0
b	0
f	0
cc	6
nc	12
nop	0
crap	42

<?php

/*
 * Cart module for Yii2
 *
 * @link      https://github.com/hiqdev/yii2-cart
 * @package   yii2-cart
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\yii2\cart\actions;

use hipanel\modules\finance\cart\AbstractCartPosition;
use hiqdev\hiart\Collection;
use hiqdev\yii2\cart\CartPositionInterface;
use hiqdev\yii2\cart\Module as CartModule;
use Yii;

class AddToCartAction extends \yii\base\Action
{
    /**
     * @var CartPositionInterface The class for new product
     */
    public $productClass;

    /**
     * @var boolean whether the action expects bulk models load using `selection`
     */
    public $bulkLoad = false;

    /**
     * @var bool whether client should be redirected to the cart in case of success item adding
     */
    public $redirectToCart = false;

    /**
     * @var bool whether any errors occurred during save
     */
    protected $hasErrors = false;

    /**
     * Returns the cart module.
     * @return CartModule
     */
    public function getCartModule()
    {
        return CartModule::getInstance();
    }

    public function run()
    {
        $data = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $request = Yii::$app->request;
        /** @var CartPositionInterface $model */
        $model = Yii::createObject($this->productClass);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $collection = new Collection(); // TODO: drop dependency
        $collection->setModel($model);

        if (!$this->bulkLoad) {
            $data = [$request->post() ?: $request->get()];
            $collection->load($data);
        } else {
            $collection->load();
        }

        $positions = [];
        foreach ($collection->models as $position) {
            /** @var CartPositionInterface|AbstractCartPosition $position */
            if (!$position->validate()) {

                $this->hasErrors = true;
                $error = $collection->getFirstError();
                if (empty($error)) {
                    $error = Yii::t('cart', 'Failed to add item to the cart');
                }
                Yii::$app->session->addFlash('warning', $error);
                Yii::warning('Failed to add item to cart', 'cart');

                continue;
            }

            $positions[] = $position;
        }

        $this->putPositionsToCart($positions);
    }

    protected function putPositionsToCart($positions)
    {
        $cart = $this->getCartModule()->getCart();
        $cart->putPositions($positions);
    }

    protected function afterRun()
    {
        $request = Yii::$app->request;

        if ($request->isAjax) {
            Yii::$app->end();
        }

        if ($this->redirectToCart && !$this->hasErrors) {
            return $this->controller->redirect('@cart');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        } elseif (isset($request->referrer)) {
            if (!$this->hasErrors) {
                Yii::$app->getSession()->setFlash('success', Yii::t('cart', 'Item has been added to cart'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            }
            return $this->controller->redirect($request->referrer);
        } else {
            return $this->controller->goHome();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }
    }
}


1			<?php
2
3			/*
4			* Cart module for Yii2
5			*
6			* @link https://github.com/hiqdev/yii2-cart
7			* @package yii2-cart
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hiqdev\yii2\cart\actions;
13
14			use hipanel\modules\finance\cart\AbstractCartPosition;
15			use hiqdev\hiart\Collection;
16			use hiqdev\yii2\cart\CartPositionInterface;
17			use hiqdev\yii2\cart\Module as CartModule;
18			use Yii;
19
20			class AddToCartAction extends \yii\base\Action
21			{
22			/**
23			* @var CartPositionInterface The class for new product
24			*/
25			public $productClass;
26
27			/**
28			* @var boolean whether the action expects bulk models load using `selection`
29			*/
30			public $bulkLoad = false;
31
32			/**
33			* @var bool whether client should be redirected to the cart in case of success item adding
34			*/
35			public $redirectToCart = false;
36
37			/**
38			* @var bool whether any errors occurred during save
39			*/
40			protected $hasErrors = false;
41
42			/**
43			* Returns the cart module.
44			* @return CartModule
45			*/
46			public function getCartModule()
47			{
48			return CartModule::getInstance();
49			}
50
51			public function run()
52			{
53			$data = null;
			0 ignored issues – show Unused Code introduced 2016-08-07 20:00 UTC by Report Bug Copy Issue Report `$data` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
54			$request = Yii::$app->request;
55			/** @var CartPositionInterface $model */
56			$model = Yii::createObject($this->productClass);
			0 ignored issues – show Documentation introduced 2016-08-07 20:00 UTC by Report Bug Copy Issue Report `$this->productClass` is of type `object<hiqdev\yii2\cart\CartPositionInterface>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
57			$collection = new Collection(); // TODO: drop dependency
58			$collection->setModel($model);
59
60			if (!$this->bulkLoad) {
61			$data = [$request->post() ?: $request->get()];
62			$collection->load($data);
63			} else {
64			$collection->load();
65			}
66
67			$positions = [];
68			foreach ($collection->models as $position) {
69			/** @var CartPositionInterface\|AbstractCartPosition $position */
70			if (!$position->validate()) {
			0 ignored issues – show Bug introduced 2016-08-07 20:00 UTC by Report Bug Copy Issue Report The method `validate()` does not seem to exist on `object<hiqdev\yii2\cart\CartPositionInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
71			$this->hasErrors = true;
72			$error = $collection->getFirstError();
73			if (empty($error)) {
74			$error = Yii::t('cart', 'Failed to add item to the cart');
75			}
76			Yii::$app->session->addFlash('warning', $error);
77			Yii::warning('Failed to add item to cart', 'cart');
78
79			continue;
80			}
81
82			$positions[] = $position;
83			}
84
85			$this->putPositionsToCart($positions);
86			}
87
88			protected function putPositionsToCart($positions)
89			{
90			$cart = $this->getCartModule()->getCart();
91			$cart->putPositions($positions);
92			}
93
94			protected function afterRun()
95			{
96			$request = Yii::$app->request;
97
98			if ($request->isAjax) {
99			Yii::$app->end();
100			}
101
102			if ($this->redirectToCart && !$this->hasErrors) {
103			return $this->controller->redirect('@cart');
			0 ignored issues – show Bug introduced 2017-12-07 16:39 UTC by Report Bug Copy Issue Report The method `redirect` does only exist in `yii\web\Controller`, but not in `yii\base\Controller and yii\console\Controller`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
104			} elseif (isset($request->referrer)) {
105			if (!$this->hasErrors) {
106			Yii::$app->getSession()->setFlash('success', Yii::t('cart', 'Item has been added to cart'));
			0 ignored issues – show Bug introduced 2018-04-19 15:02 UTC by Report Bug Copy Issue Report The method `getSession` does only exist in `yii\web\Application`, but not in `yii\console\Application`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
107			}
108			return $this->controller->redirect($request->referrer);
109			} else {
110			return $this->controller->goHome();
			0 ignored issues – show Bug introduced 2017-12-07 16:39 UTC by Report Bug Copy Issue Report The method `goHome` does only exist in `yii\web\Controller`, but not in `yii\base\Controller and yii\console\Controller`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
111			}
112			}
113			}
114

hiqdev / yii2-cart

Pull Request — master (#10)

AddToCartAction::run() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like