Issues in AbstractUnit.php (master) - Issues in master - hiqdev/php-units - Measure and Improve Code Quality continuously with Scrutinizer

Issues (23)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/AbstractUnit.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * PHP Units of Measure Library
 *
 * @link      https://github.com/hiqdev/php-units
 * @package   php-units
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\units;

use JsonSerializable;
use hiqdev\php\units\exceptions\InvalidConfigException;

/**
 * Abstract Unit of measure. E.g.
 * Almost final.
 * Only findCoverter can be changed.
 *
 * @see UnitInterface
 * @author Andrii Vasyliev <[email protected]>
 */
abstract class AbstractUnit implements UnitInterface, JsonSerializable
{
    /**
     * @var string
     */
    private $name;

    /**
     * @var ConverterInterface
     */
    private $converter;

    private function __construct($name, ConverterInterface $converter)
    {
        $this->name = $name;
        $this->converter = $converter;
    }

    private function getConverter()
    {
        return $this->converter;
    }

    /**
     * {@inheritdoc}
     */
    final public function getName()
    {
        return $this->name;
    }

    /**
     * {@inheritdoc}
     */
    final public function getMeasure()
    {
        return $this->getConverter()->getMeasure($this);
    }

    /**
     * {@inheritdoc}
     */
    final public function getCalculator()
    {
        return $this->getConverter()->getCalculator($this);
    }

    /**
     * {@inheritdoc}
     */
    final public function equals(UnitInterface $other)
    {
        return $this->getConverter()->equals($this, $other);
    }

    /**
     * {@inheritdoc}
     */
    final public function isConvertible(UnitInterface $other)
    {
        return $this->getConverter()->isConvertible($this, $other);
    }

    /**
     * {@inheritdoc}
     */
    final public function convert(UnitInterface $other, $quantity)
    {
        return $this->getConverter()->convert($this, $other, $quantity);
    }

    /**
     * @var Unit[]
     */
    protected static $units;

    final public static function __callStatic($name, $args)
    {
        return static::create($name);
    }

    public static function create($name)
    {
        if (!isset(static::$units[$name])) {
            static::$units[$name] = new static($name, static::findConverter($name));
        }

        return static::$units[$name];
    }

    /**
     * Returns converter for given unit name.
     * The only function to change in child classes.
     * XXX Should be defined as abstract but not supported in PHP5.
     * @param string $name
     * @throws InvalidConfigException
     * @return ConverterInterface
     */
    protected static function findConverter($name)

    {
        throw new InvalidConfigException('findConverter method must be redefined');
    }

    public function jsonSerialize()
    {
        return ['name' => $this->name];
    }
}


1		<?php
2		/**
3		* PHP Units of Measure Library
4		*
5		* @link https://github.com/hiqdev/php-units
6		* @package php-units
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2017-2018, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hiqdev\php\units;
12
13		use JsonSerializable;
14		use hiqdev\php\units\exceptions\InvalidConfigException;
15
16		/**
17		* Abstract Unit of measure. E.g.
18		* Almost final.
19		* Only findCoverter can be changed.
20		*
21		* @see UnitInterface
22		* @author Andrii Vasyliev <[email protected]>
23		*/
24		abstract class AbstractUnit implements UnitInterface, JsonSerializable
25		{
26		/**
27		* @var string
28		*/
29		private $name;
30
31		/**
32		* @var ConverterInterface
33		*/
34		private $converter;
35
36	5	private function __construct($name, ConverterInterface $converter)
37		{
38	5	$this->name = $name;
39	5	$this->converter = $converter;
40	5	}
41
42	12	private function getConverter()
43		{
44	12	return $this->converter;
45		}
46
47		/**
48		* {@inheritdoc}
49		*/
50	17	final public function getName()
51		{
52	17	return $this->name;
53		}
54
55		/**
56		* {@inheritdoc}
57		*/
58	10	final public function getMeasure()
59		{
60	10	return $this->getConverter()->getMeasure($this);
61		}
62
63		/**
64		* {@inheritdoc}
65		*/
66	5	final public function getCalculator()
67		{
68	5	return $this->getConverter()->getCalculator($this);
69		}
70
71		/**
72		* {@inheritdoc}
73		*/
74	2	final public function equals(UnitInterface $other)
75		{
76	2	return $this->getConverter()->equals($this, $other);
77		}
78
79		/**
80		* {@inheritdoc}
81		*/
82	2	final public function isConvertible(UnitInterface $other)
83		{
84	2	return $this->getConverter()->isConvertible($this, $other);
85		}
86
87		/**
88		* {@inheritdoc}
89		*/
90	7	final public function convert(UnitInterface $other, $quantity)
91		{
92	7	return $this->getConverter()->convert($this, $other, $quantity);
93		}
94
95		/**
96		* @var Unit[]
97		*/
98		protected static $units;
99
100	18	final public static function __callStatic($name, $args)
101		{
102	18	return static::create($name);
103		}
104
105	18	public static function create($name)
106		{
107	18	if (!isset(static::$units[$name])) {
108	5	static::$units[$name] = new static($name, static::findConverter($name));
109		}
110
111	18	return static::$units[$name];
112		}
113
114		/**
115		* Returns converter for given unit name.
116		* The only function to change in child classes.
117		* XXX Should be defined as abstract but not supported in PHP5.
118		* @param string $name
119		* @throws InvalidConfigException
120		* @return ConverterInterface
121		*/
122		protected static function findConverter($name)
		0 ignored issues – show Unused Code introduced 2017-03-31 09:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$name` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
123		{
124		throw new InvalidConfigException('findConverter method must be redefined');
125		}
126
127		public function jsonSerialize()
128		{
129		return ['name' => $this->name];
130		}
131		}
132

hiqdev / php-units

Issues (23)

Security Analysis no request data

src/AbstractUnit.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like