hiqdev\php\merchant\merchants\twocheckoutplus\TwoCheckoutPlusMerchant

Complexity

Total Complexity

3

Size/Duplication

Total Lines	63
Duplicated Lines	22.22 %

Coupling/Cohesion

Components	2
Dependencies	13

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	createGateway()	0	9	1
A	requestPurchase()	0	22	1
A	completePurchase()	14	14	1

<?php
/**
 * Generalization over Omnipay and Payum
 *
 * @link      https://github.com/hiqdev/php-merchant
 * @package   php-merchant
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\merchant\merchants\twocheckoutplus;

use hiqdev\php\merchant\InvoiceInterface;
use hiqdev\php\merchant\merchants\AbstractMerchant;
use hiqdev\php\merchant\response\CompletePurchaseResponse;
use hiqdev\php\merchant\response\RedirectPurchaseResponse;
use Money\Currency;
use Money\Money;
use Omnipay\TwoCheckoutPlus\Gateway;

/**
 * Class TwoCheckoutPlusMerchant.
 *
 * @author Dmytro Naumenko <d.naumenko.a@gmail.com>
 */
class TwoCheckoutPlusMerchant extends AbstractMerchant
{
    /**
     * @var Gateway
     */
    protected $gateway;

    protected function createGateway()
    {
        return $this->gatewayFactory->build('TwoCheckoutPlusMerchant', [
            'account_number' => $this->credentials->getPurse(),
            'secret_word'  => $this->credentials->getKey1(),
            'testMode' => $this->credentials->isTestMode(),
            'demoMode' => $this->credentials->isTestMode(),
        ]);
    }

    /**
     * @param InvoiceInterface $invoice
     * @return RedirectPurchaseResponse
     */
    public function requestPurchase(InvoiceInterface $invoice)
    {
        $gateway = clone $this->gateway;
        $gateway->setCart([
            [
                'product' => 'product',
                'description' => $invoice->getDescription(),
                'price' => $this->moneyFormatter->format($invoice->getAmount()),
                'quantity' => 1,
            ]
        ]);
        /**
         * @var \Omnipay\TwoCheckoutPlus\Message\PurchaseResponse
         */
        $response = $this->gateway->purchase([
            'transactionId' => $invoice->getId(),
            'currency' => $invoice->getCurrency()->getCode(),
            'returnUrl' => $invoice->getReturnUrl(),
        ])->send();

        return (new RedirectPurchaseResponse($response->getRedirectUrl(), []))->setMethod('GET');
    }

    /**
     * @param array $data
     * @return CompletePurchaseResponse
     */
    public function completePurchase($data)

This method seems to be duplicated in your project.

    {
        /** @var \Omnipay\WebMoney\Message\CompletePurchaseResponse $response */
        $response = $this->gateway->completePurchase($data)->send();

        return (new CompletePurchaseResponse())
            ->setIsSuccessful($response->isSuccessful())

$response->isSuccessful() is of type boolean, but the function expects a string.

            ->setAmount($this->moneyParser->parse($response->getAmount(), $response->getCurrency()))
            ->setFee(new Money(0, new Currency($response->getCurrency())))
            ->setTransactionReference($response->getTransactionReference())
            ->setTransactionId($response->getTransactionId())
            ->setPayer($response->getData()['LMI_PAYER_PURSE'])
            ->setTime(new \DateTime($response->getData()['LMI_SYS_TRANS_DATE']));
    }
}