PayPalExpressMerchant - Code Metrics - Inspection of "quickfixed epayservice test: changed check_key" - hiqdev/php-merchant - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 259fd8...a43b07 )

by Andrii

created 2017-11-26 11:12 UTC

PayPalExpressMerchant A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	56
Duplicated Lines	100 %

Coupling/Cohesion

Components	2
Dependencies	13

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	3
lcom	2
cbo	13
dl	56
loc	56
ccs	25
cts	25
cp	1
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	createGateway()	7	7	1
A	requestPurchase()	17	17	1
A	completePurchase()	14	14	1

How to fix Duplicated Code

<?php
/**
 * Generalization over Omnipay and Payum
 *
 * @link      https://github.com/hiqdev/php-merchant
 * @package   php-merchant
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\merchant\merchants\paypal;

use hiqdev\php\merchant\InvoiceInterface;
use hiqdev\php\merchant\merchants\AbstractMerchant;
use hiqdev\php\merchant\response\CompletePurchaseResponse;
use hiqdev\php\merchant\response\RedirectPurchaseResponse;
use Omnipay\PayPal\Gateway;

/**
 * Class PayPalExpressMerchant.
 *
 * @author Dmytro Naumenko <[email protected]>
 */
class PayPalExpressMerchant extends AbstractMerchant

{
    /**
     * @var Gateway
     */
    protected $gateway;

    protected function createGateway()
    {
        return $this->gatewayFactory->build('PayPal', [
            'purse' => $this->credentials->getPurse(),
            'secret' => $this->credentials->getKey1(),
        ]);
    }

    /**
     * @param InvoiceInterface $invoice
     * @return RedirectPurchaseResponse
     */
    public function requestPurchase(InvoiceInterface $invoice)
    {
        /**
         * @var \Omnipay\BitPay\Message\PurchaseResponse
         */
        $response = $this->gateway->purchase([
            'transactionId' => $invoice->getId(),
            'description' => $invoice->getDescription(),
            'amount' => $this->moneyFormatter->format($invoice->getAmount()),
            'currency' => $invoice->getCurrency()->getCode(),
            'returnUrl' => $invoice->getReturnUrl(),
            'notifyUrl' => $invoice->getNotifyUrl(),
            'cancelUrl' => $invoice->getCancelUrl(),
        ])->send();

        return new RedirectPurchaseResponse($response->getRedirectUrl(), $response->getRedirectData());
    }

    /**
     * @param array $data
     * @return CompletePurchaseResponse
     */
    public function completePurchase($data)
    {
        /** @var \Omnipay\PayPal\Message\CompletePurchaseResponse $response */
        $response = $this->gateway->completePurchase($data)->send();

        return (new CompletePurchaseResponse())
            ->setIsSuccessful($response->isSuccessful())
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setAmount($this->moneyParser->parse($response->getAmount(), $response->getCurrency()))
            ->setFee($this->moneyParser->parse($response->getFee(), $response->getCurrency()))
            ->setTransactionReference($response->getTransactionReference())
            ->setTransactionId($response->getTransactionId())
            ->setPayer($response->getPayer())
            ->setTime(new \DateTime($response->getTime()));
    }
}


1			<?php
2			/**
3			* Generalization over Omnipay and Payum
4			*
5			* @link https://github.com/hiqdev/php-merchant
6			* @package php-merchant
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\php\merchant\merchants\paypal;
12
13			use hiqdev\php\merchant\InvoiceInterface;
14			use hiqdev\php\merchant\merchants\AbstractMerchant;
15			use hiqdev\php\merchant\response\CompletePurchaseResponse;
16			use hiqdev\php\merchant\response\RedirectPurchaseResponse;
17			use Omnipay\PayPal\Gateway;
18
19			/**
20			* Class PayPalExpressMerchant.
21			*
22			* @author Dmytro Naumenko <[email protected]>
23			*/
24		View Code Duplication	class PayPalExpressMerchant extends AbstractMerchant
			0 ignored issues – show Duplication introduced 2017-10-20 09:54 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25			{
26			/**
27			* @var Gateway
28			*/
29			protected $gateway;
30
31	3		protected function createGateway()
32			{
33	3		return $this->gatewayFactory->build('PayPal', [
34	3		'purse' => $this->credentials->getPurse(),
35	3		'secret' => $this->credentials->getKey1(),
36			]);
37			}
38
39			/**
40			* @param InvoiceInterface $invoice
41			* @return RedirectPurchaseResponse
42			*/
43	1		public function requestPurchase(InvoiceInterface $invoice)
44			{
45			/**
46			* @var \Omnipay\BitPay\Message\PurchaseResponse
47			*/
48	1		$response = $this->gateway->purchase([
49	1		'transactionId' => $invoice->getId(),
50	1		'description' => $invoice->getDescription(),
51	1		'amount' => $this->moneyFormatter->format($invoice->getAmount()),
52	1		'currency' => $invoice->getCurrency()->getCode(),
53	1		'returnUrl' => $invoice->getReturnUrl(),
54	1		'notifyUrl' => $invoice->getNotifyUrl(),
55	1		'cancelUrl' => $invoice->getCancelUrl(),
56	1		])->send();
57
58	1		return new RedirectPurchaseResponse($response->getRedirectUrl(), $response->getRedirectData());
59			}
60
61			/**
62			* @param array $data
63			* @return CompletePurchaseResponse
64			*/
65	1		public function completePurchase($data)
66			{
67			/** @var \Omnipay\PayPal\Message\CompletePurchaseResponse $response */
68	1		$response = $this->gateway->completePurchase($data)->send();
69
70	1		return (new CompletePurchaseResponse())
71	1		->setIsSuccessful($response->isSuccessful())
			0 ignored issues – show Documentation introduced 2017-11-26 11:15 UTC by Report Bug Copy Issue Report `$response->isSuccessful()` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
72	1		->setAmount($this->moneyParser->parse($response->getAmount(), $response->getCurrency()))
73	1		->setFee($this->moneyParser->parse($response->getFee(), $response->getCurrency()))
74	1		->setTransactionReference($response->getTransactionReference())
75	1		->setTransactionId($response->getTransactionId())
76	1		->setPayer($response->getPayer())
77	1		->setTime(new \DateTime($response->getTime()));
78			}
79			}
80

hiqdev / php-merchant

Push — master ( 259fd8...a43b07 )

PayPalExpressMerchant A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like