AbstractMerchant::__construct() - Code Metrics - Inspection of "[WIP] Completely refactored" - hiqdev/php-merchant - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Dmitry

created 2017-10-24 14:25 UTC

AbstractMerchant::__construct() A

↳ Parent: AbstractMerchant

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	1
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	4
crap	2

<?php

namespace hiqdev\php\merchant\merchants;

use hiqdev\php\merchant\credentials\CredentialsInterface;
use hiqdev\php\merchant\factories\GatewayFactoryInterface;
use Money\MoneyFormatter;
use Money\MoneyParser;
use Omnipay\Common\GatewayInterface;

abstract class AbstractMerchant implements MerchantInterface
{
    /**
     * @var GatewayInterface
     */
    protected $gateway;
    /**
     * @var CredentialsInterface
     */
    protected $credentials;
    /**
     * @var GatewayFactoryInterface
     */
    protected $gatewayFactory;
    /**
     * @var MoneyFormatter
     */
    protected $moneyFormatter;
    /**
     * @var MoneyParser
     */
    protected $moneyParser;

    public function __construct(
        CredentialsInterface $credentials,
        GatewayFactoryInterface $gatewayFactory,
        MoneyFormatter $moneyFormatter,
        MoneyParser $moneyParser
    ) {
        $this->credentials = $credentials;
        $this->gatewayFactory = $gatewayFactory;
        $this->moneyFormatter = $moneyFormatter;
        $this->moneyParser = $moneyParser;
        $this->gateway = $this->createGateway();
    }

    /**
     * @return CredentialsInterface
     */
    public function getCredentials(): CredentialsInterface
    {
        return $this->credentials;
    }

    /**
     * @return GatewayInterface
     */
    abstract protected function createGateway();

}


1			<?php
2
3			namespace hiqdev\php\merchant\merchants;
4
5			use hiqdev\php\merchant\credentials\CredentialsInterface;
6			use hiqdev\php\merchant\factories\GatewayFactoryInterface;
7			use Money\MoneyFormatter;
8			use Money\MoneyParser;
9			use Omnipay\Common\GatewayInterface;
10
11			abstract class AbstractMerchant implements MerchantInterface
12			{
13			/**
14			* @var GatewayInterface
15			*/
16			protected $gateway;
17			/**
18			* @var CredentialsInterface
19			*/
20			protected $credentials;
21			/**
22			* @var GatewayFactoryInterface
23			*/
24			protected $gatewayFactory;
25			/**
26			* @var MoneyFormatter
27			*/
28			protected $moneyFormatter;
29			/**
30			* @var MoneyParser
31			*/
32			protected $moneyParser;
33
34			public function __construct(
35			CredentialsInterface $credentials,
36			GatewayFactoryInterface $gatewayFactory,
37			MoneyFormatter $moneyFormatter,
38			MoneyParser $moneyParser
39			) {
40			$this->credentials = $credentials;
41			$this->gatewayFactory = $gatewayFactory;
42			$this->moneyFormatter = $moneyFormatter;
43			$this->moneyParser = $moneyParser;
44			$this->gateway = $this->createGateway();
45			}
46
47			/**
48			* @return CredentialsInterface
49			*/
50			public function getCredentials(): CredentialsInterface
51			{
52			return $this->credentials;
53			}
54
55			/**
56			* @return GatewayInterface
57			*/
58			abstract protected function createGateway();
59
60			}
61

hiqdev / php-merchant

Pull Request — master (#1)

AbstractMerchant::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like