These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | /** |
||
3 | * Generalization over Omnipay and Payum |
||
4 | * |
||
5 | * @link https://github.com/hiqdev/php-merchant |
||
6 | * @package php-merchant |
||
7 | * @license BSD-3-Clause |
||
8 | * @copyright Copyright (c) 2015-2018, HiQDev (http://hiqdev.com/) |
||
9 | */ |
||
10 | |||
11 | namespace hiqdev\php\merchant\merchants\okpay; |
||
12 | |||
13 | use hiqdev\php\merchant\InvoiceInterface; |
||
14 | use hiqdev\php\merchant\merchants\AbstractMerchant; |
||
15 | use hiqdev\php\merchant\response\CompletePurchaseResponse; |
||
16 | use hiqdev\php\merchant\response\RedirectPurchaseResponse; |
||
17 | |||
18 | /** |
||
19 | * Class OkpayMerchant. |
||
20 | * |
||
21 | * @author Dmytro Naumenko <[email protected]> |
||
22 | */ |
||
23 | View Code Duplication | class OkpayMerchant extends AbstractMerchant |
|
24 | { |
||
25 | /** |
||
26 | * @var \Omnipay\Common\GatewayInterface |
||
27 | */ |
||
28 | protected $gateway; |
||
29 | |||
30 | 3 | protected function createGateway() |
|
31 | { |
||
32 | 3 | return $this->gatewayFactory->build('OKPAY', [ |
|
33 | 3 | 'purse' => $this->credentials->getPurse(), |
|
34 | 3 | 'secret' => $this->credentials->getKey1(), |
|
35 | 3 | 'secret2' => $this->credentials->getKey2(), |
|
36 | ]); |
||
37 | } |
||
38 | |||
39 | /** |
||
40 | * @param InvoiceInterface $invoice |
||
41 | * @return RedirectPurchaseResponse |
||
42 | */ |
||
43 | 1 | public function requestPurchase(InvoiceInterface $invoice) |
|
44 | { |
||
45 | /** |
||
46 | * @var \Omnipay\BitPay\Message\PurchaseResponse |
||
47 | */ |
||
48 | 1 | $response = $this->gateway->purchase([ |
|
0 ignored issues
–
show
|
|||
49 | 1 | 'transactionId' => $invoice->getId(), |
|
50 | 1 | 'description' => $invoice->getDescription(), |
|
51 | 1 | 'amount' => $this->moneyFormatter->format($invoice->getAmount()), |
|
52 | 1 | 'currency' => $invoice->getCurrency()->getCode(), |
|
53 | 1 | 'returnUrl' => $invoice->getReturnUrl(), |
|
54 | 1 | 'notifyUrl' => $invoice->getNotifyUrl(), |
|
55 | 1 | 'cancelUrl' => $invoice->getCancelUrl(), |
|
56 | 1 | ])->send(); |
|
57 | |||
58 | 1 | return new RedirectPurchaseResponse($response->getRedirectUrl(), $response->getRedirectData()); |
|
59 | } |
||
60 | |||
61 | /** |
||
62 | * @param array $data |
||
63 | * @return CompletePurchaseResponse |
||
64 | */ |
||
65 | 1 | public function completePurchase($data) |
|
66 | { |
||
67 | /** @var \Omnipay\OKPAY\Message\CompletePurchaseResponse $response */ |
||
68 | 1 | $response = $this->gateway->completePurchase($data)->send(); |
|
0 ignored issues
–
show
It seems like you code against a concrete implementation and not the interface
Omnipay\Common\GatewayInterface as the method completePurchase() does only exist in the following implementations of said interface: Omnipay\BitPay\Gateway , Omnipay\CoinGate\Gateway , Omnipay\FreeKassa\Gateway , Omnipay\Ikajo\Gateway , Omnipay\InterKassa\Gateway , Omnipay\OKPAY\Gateway , Omnipay\Paxum\Gateway , Omnipay\PayPal\Gateway , Omnipay\RoboKassa\Gateway , Omnipay\TwoCheckoutPlus\Gateway , Omnipay\WebMoney\Gateway , Omnipay\YandexKassa\Gateway , Omnipay\YandexMoney\P2pGateway , Omnipay\ePayService\Gateway , Omnipay\ePayments\Gateway .
Let’s take a look at an example: interface User
{
/** @return string */
public function getPassword();
}
class MyUser implements User
{
public function getPassword()
{
// return something
}
public function getDisplayName()
{
// return some name.
}
}
class AuthSystem
{
public function authenticate(User $user)
{
$this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
// do something.
}
}
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types
inside the if block in such a case.
Loading history...
|
|||
69 | |||
70 | 1 | return (new CompletePurchaseResponse()) |
|
71 | 1 | ->setIsSuccessful($response->isSuccessful()) |
|
72 | 1 | ->setAmount($this->moneyParser->parse($response->getAmount(), $response->getCurrency())) |
|
73 | 1 | ->setFee($this->moneyParser->parse($response->getFee(), $response->getCurrency())) |
|
74 | 1 | ->setTransactionReference($response->getTransactionReference()) |
|
75 | 1 | ->setTransactionId($response->getTransactionId()) |
|
76 | 1 | ->setPayer($response->getPayer()) |
|
77 | 1 | ->setTime($response->getTime()); |
|
78 | } |
||
79 | } |
||
80 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: