Issues in InterKassaMerchant.php - All Issues - Inspection of "Updated IkajoMerchantTest to follow Ikajo changes" - hiqdev/php-merchant - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 576b56...533c2b )

by Dmitry

created 2019-05-21 15:44 UTC

src/merchants/interkassa/InterKassaMerchant.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Generalization over Omnipay and Payum
 *
 * @link      https://github.com/hiqdev/php-merchant
 * @package   php-merchant
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\merchant\merchants\interkassa;

use hiqdev\php\merchant\InvoiceInterface;
use hiqdev\php\merchant\merchants\AbstractMerchant;
use hiqdev\php\merchant\response\CompletePurchaseResponse;
use hiqdev\php\merchant\response\RedirectPurchaseResponse;
use Omnipay\InterKassa\Gateway;

/**
 * Class PaxumMerchant.
 *
 * @author Dmytro Naumenko <[email protected]>
 */
class InterKassaMerchant extends AbstractMerchant

{
    /**
     * @var Gateway
     */
    protected $gateway;

    protected function createGateway()
    {
        return $this->gatewayFactory->build('InterKassa', [
            'checkoutId' => $this->credentials->getPurse(),
            'signKey'  => $this->credentials->getKey1(),
            'signAlgorithm' => 'md5',
        ]);
    }

    /**
     * @param InvoiceInterface $invoice
     * @return RedirectPurchaseResponse
     */
    public function requestPurchase(InvoiceInterface $invoice)
    {
        /**
         * @var \Omnipay\Paxum\Message\PurchaseResponse
         */
        $response = $this->gateway->purchase([
            'transactionId' => $invoice->getId(),
            'description' => $invoice->getDescription(),
            'amount' => $this->moneyFormatter->format($invoice->getAmount()),
            'currency' => $invoice->getCurrency()->getCode(),
            'returnUrl' => $invoice->getReturnUrl(),
            'notifyUrl' => $invoice->getNotifyUrl(),
            'cancelUrl' => $invoice->getCancelUrl(),
        ])->send();

        return new RedirectPurchaseResponse($response->getRedirectUrl(), $response->getRedirectData());
    }

    /**
     * @param array $data
     * @return CompletePurchaseResponse
     */
    public function completePurchase($data)
    {
        /** @var \Omnipay\InterKassa\Message\CompletePurchaseResponse $response */
        $response = $this->gateway->completePurchase($data)->send();

        return (new CompletePurchaseResponse())
            ->setIsSuccessful($response->isSuccessful())
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setAmount($this->moneyParser->parse($response->getAmount(), $response->getCurrency()))
            ->setTransactionReference($response->getTransactionReference())
            ->setTransactionId($response->getTransactionId())
            ->setPayer($response->getPayer())
            ->setTime((new \DateTime($response->getTime()))->setTimezone(new \DateTimeZone('UTC')));
    }
}


1			<?php
2			/**
3			* Generalization over Omnipay and Payum
4			*
5			* @link https://github.com/hiqdev/php-merchant
6			* @package php-merchant
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2018, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\php\merchant\merchants\interkassa;
12
13			use hiqdev\php\merchant\InvoiceInterface;
14			use hiqdev\php\merchant\merchants\AbstractMerchant;
15			use hiqdev\php\merchant\response\CompletePurchaseResponse;
16			use hiqdev\php\merchant\response\RedirectPurchaseResponse;
17			use Omnipay\InterKassa\Gateway;
18
19			/**
20			* Class PaxumMerchant.
21			*
22			* @author Dmytro Naumenko <[email protected]>
23			*/
24		View Code Duplication	class InterKassaMerchant extends AbstractMerchant
			0 ignored issues – show Duplication introduced 2017-10-20 09:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25			{
26			/**
27			* @var Gateway
28			*/
29			protected $gateway;
30
31	3		protected function createGateway()
32			{
33	3		return $this->gatewayFactory->build('InterKassa', [
34	3		'checkoutId' => $this->credentials->getPurse(),
35	3		'signKey' => $this->credentials->getKey1(),
36	3		'signAlgorithm' => 'md5',
37			]);
38			}
39
40			/**
41			* @param InvoiceInterface $invoice
42			* @return RedirectPurchaseResponse
43			*/
44	1		public function requestPurchase(InvoiceInterface $invoice)
45			{
46			/**
47			* @var \Omnipay\Paxum\Message\PurchaseResponse
48			*/
49	1		$response = $this->gateway->purchase([
50	1		'transactionId' => $invoice->getId(),
51	1		'description' => $invoice->getDescription(),
52	1		'amount' => $this->moneyFormatter->format($invoice->getAmount()),
53	1		'currency' => $invoice->getCurrency()->getCode(),
54	1		'returnUrl' => $invoice->getReturnUrl(),
55	1		'notifyUrl' => $invoice->getNotifyUrl(),
56	1		'cancelUrl' => $invoice->getCancelUrl(),
57	1		])->send();
58
59	1		return new RedirectPurchaseResponse($response->getRedirectUrl(), $response->getRedirectData());
60			}
61
62			/**
63			* @param array $data
64			* @return CompletePurchaseResponse
65			*/
66	1		public function completePurchase($data)
67			{
68			/** @var \Omnipay\InterKassa\Message\CompletePurchaseResponse $response */
69	1		$response = $this->gateway->completePurchase($data)->send();
70
71	1		return (new CompletePurchaseResponse())
72	1		->setIsSuccessful($response->isSuccessful())
			0 ignored issues – show Documentation introduced 2017-10-20 09:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$response->isSuccessful()` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
73	1		->setAmount($this->moneyParser->parse($response->getAmount(), $response->getCurrency()))
74	1		->setTransactionReference($response->getTransactionReference())
75	1		->setTransactionId($response->getTransactionId())
76	1		->setPayer($response->getPayer())
77	1		->setTime((new \DateTime($response->getTime()))->setTimezone(new \DateTimeZone('UTC')));
78			}
79			}
80

hiqdev / php-merchant

Push — master ( 576b56...533c2b )

src/merchants/interkassa/InterKassaMerchant.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like