Completed
Push — master ( 576b56...533c2b )
by Dmitry
14:42
created

EpaymentsMerchant::completePurchase()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 15

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 10
CRAP Score 1

Importance

Changes 0
Metric Value
dl 0
loc 15
ccs 10
cts 10
cp 1
rs 9.7666
c 0
b 0
f 0
cc 1
nc 1
nop 1
crap 1
1
<?php
2
/**
3
 * Generalization over Omnipay and Payum
4
 *
5
 * @link      https://github.com/hiqdev/php-merchant
6
 * @package   php-merchant
7
 * @license   BSD-3-Clause
8
 * @copyright Copyright (c) 2015-2018, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace hiqdev\php\merchant\merchants\epayments;
12
13
use hiqdev\php\merchant\InvoiceInterface;
14
use hiqdev\php\merchant\merchants\AbstractMerchant;
15
use hiqdev\php\merchant\response\CompletePurchaseResponse;
16
use hiqdev\php\merchant\response\RedirectPurchaseResponse;
17
use Omnipay\ePayments\Message\DetailsResponse;
18
use Omnipay\ePayments\Message\PurchaseResponse;
19
20
/**
21
 * Class EpaymentsMerchant.
22
 *
23
 * @author Dmytro Naumenko <[email protected]>
24
 *
25
 * @property \Omnipay\ePayments\Gateway $gateway
26
 */
27
class EpaymentsMerchant extends AbstractMerchant
28
{
29
    /**
30
     * @return \Omnipay\Common\GatewayInterface
31
     */
32 3
    protected function createGateway()
33
    {
34 3
        return $this->gatewayFactory->build('ePayments', [
35 3
            'partnerId' => $this->credentials->getPurse(),
36 3
            'secret'  => $this->credentials->getKey1(),
37
        ]);
38
    }
39
40
    /**
41
     * @param InvoiceInterface $invoice
42
     * @return RedirectPurchaseResponse
43
     */
44 1
    public function requestPurchase(InvoiceInterface $invoice)
45
    {
46
        /**
47
         * @var PurchaseResponse
48
         */
49 1
        $response = $this->gateway->purchase([
50 1
            'orderId' => $invoice->getId(),
51 1
            'details' => $invoice->getDescription(),
52 1
            'amount' => $this->moneyFormatter->format($invoice->getAmount()),
53 1
            'currency' => strtolower($invoice->getCurrency()->getCode()),
54 1
            'returnUrl' => $invoice->getReturnUrl(),
55 1
            'cancelUrl' => $invoice->getCancelUrl(),
56 1
        ])->send();
57
58 1
        return new RedirectPurchaseResponse($response->getRedirectUrl(), $response->getRedirectData());
59
    }
60
61
    /**
62
     * @param array $data
63
     * @return CompletePurchaseResponse
64
     */
65 1
    public function completePurchase($data)
66
    {
67
        /** @var \Omnipay\ePayments\Message\CompletePurchaseResponse $notification */
68 1
        $notification = $this->gateway->completePurchase($data)->send();
69
70 1
        $response = $this->fetchOrderDetails($notification->getOrderId());
71
72 1
        return (new CompletePurchaseResponse())
73 1
            ->setIsSuccessful($response->isSuccessful())
0 ignored issues
show
Documentation introduced by
$response->isSuccessful() is of type boolean, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
74 1
            ->setAmount($this->moneyParser->parse($response->getAmount(), $response->getCurrency()))
75 1
            ->setTransactionReference($response->getTransactionReference())
76 1
            ->setTransactionId($response->getTransactionId())
77 1
            ->setPayer($response->getTransactionReference())
78 1
            ->setTime($response->getPaymentDate());
79
    }
80
81
    protected function fetchOrderDetails(string $orderId): DetailsResponse
82
    {
83
        return $this->gateway->details(['orderId' => $orderId])->send();
0 ignored issues
show
Bug introduced by
The method send does only exist in Omnipay\Common\Message\AbstractRequest, but not in Omnipay\ePayments\Message\DetailsResponse.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
84
    }
85
}
86