Completed
Pull Request — master (#1)
by Dmitry
03:17
created

PayPalExpressMerchant::requestPurchase()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 17
Code Lines 11

Duplication

Lines 17
Ratio 100 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 17
loc 17
ccs 0
cts 10
cp 0
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 11
nc 1
nop 1
crap 2
1
<?php
2
3
namespace hiqdev\php\merchant\merchants\paypal;
4
5
use hiqdev\php\merchant\credentials\CredentialsInterface;
6
use hiqdev\php\merchant\factories\GatewayFactoryInterface;
7
use hiqdev\php\merchant\InvoiceInterface;
8
use hiqdev\php\merchant\merchants\AbstractMerchant;
9
use hiqdev\php\merchant\merchants\MerchantInterface;
10
use hiqdev\php\merchant\response\CompletePurchaseResponse;
11
use hiqdev\php\merchant\response\RedirectPurchaseResponse;
12
use Money\Currency;
13
use Money\Money;
14
use Money\MoneyFormatter;
15
use Money\MoneyParser;
16
use Omnipay\PayPal\Gateway;
17
18
/**
19
 * Class PayPalExpressMerchant
20
 *
21
 * @author Dmytro Naumenko <[email protected]>
22
 */
23 View Code Duplication
class PayPalExpressMerchant extends AbstractMerchant
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
24
{
25
    /**
26
     * @var Gateway
27
     */
28
    protected $gateway;
29
30
    protected function createGateway()
31
    {
32
        return $this->gatewayFactory->build('PayPal', [
33
            'purse' => $this->credentials->getPurse(),
34
            'secret' => $this->credentials->getKey1(),
35
        ]);
36
    }
37
38
    /**
39
     * @param InvoiceInterface $invoice
40
     * @return RedirectPurchaseResponse
41
     */
42
    public function requestPurchase(InvoiceInterface $invoice)
43
    {
44
        /**
45
         * @var \Omnipay\BitPay\Message\PurchaseResponse $response
46
         */
47
        $response = $this->gateway->purchase([
48
            'transactionId' => $invoice->getId(),
49
            'description' => $invoice->getDescription(),
50
            'amount' => $this->moneyFormatter->format($invoice->getAmount()),
51
            'currency' => $invoice->getCurrency()->getCode(),
52
            'returnUrl' => $invoice->getReturnUrl(),
53
            'notifyUrl' => $invoice->getNotifyUrl(),
54
            'cancelUrl' => $invoice->getCancelUrl(),
55
        ])->send();
56
57
        return new RedirectPurchaseResponse($response->getRedirectUrl(), $response->getRedirectData());
58
    }
59
60
    /**
61
     * @param array $data
62
     * @return CompletePurchaseResponse
63
     */
64
    public function completePurchase($data)
65
    {
66
        /** @var \Omnipay\PayPal\Message\CompletePurchaseResponse $response */
67
        $response = $this->gateway->completePurchase($data)->send();
68
69
        return (new CompletePurchaseResponse())
70
            ->setIsSuccessful($response->isSuccessful())
0 ignored issues
show
Documentation introduced by
$response->isSuccessful() is of type boolean, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
71
            ->setAmount($this->moneyParser->parse($response->getAmount(), $response->getCurrency()))
72
            ->setFee($this->moneyParser->parse($response->getFee(), $response->getCurrency()))
73
            ->setTransactionReference($response->getTransactionReference())
74
            ->setTransactionId($response->getTransactionId())
75
            ->setPayer($response->getPayer())
76
            ->setTime(new \DateTime($response->getTime()));
77
    }
78
}
79