ServiceTrait - Code Metrics - Inspection of "Changed FileStorage::getFullPath(), added Yii::get..." - hiqdev/php-confirmator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Klochok

created 2018-08-27 14:42 UTC

ServiceTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	10
lcom	0
cbo	1
dl	0
loc	50
ccs	0
cts	20
cp	0
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	removeToken()	4	1
A	issueToken()	7	1
A	checkToken()	9	2
A	findToken()	10	3
A	readToken()	4	2
A	writeToken()	4	1

<?php
/**
 * Library for confirmation tokens.
 *
 * @link      https://github.com/hiqdev/php-confirmator
 * @package   php-confirmator
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\php\confirmator;

trait ServiceTrait
{
    /**
     * @param array $data
     * @return Token
     */
    public function issueToken(array $data)
    {
        $token = new Token($this, $data);
        $this->writeToken($token);

        return $token;
    }

    public function checkToken($token, array $data)
    {
        $token = $this->findToken($token);
        if (!$token) {
            return false;
        }

        return $token->check($data);
    }

    public function findToken($token)
    {
        if ($token instanceof Token) {
            return $token;
        }

        $data = $this->readToken($token);

        return empty($data) ? null : new Token($this, $data, $token);
    }

    public function removeToken($token)
    {
        return $this->getStorage()->remove((string) $token);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    protected function readToken($string)
    {
        return $this->getStorage()->has($string) ? json_decode($this->getStorage()->get($string), true) : null;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    protected function writeToken(Token $token)
    {
        return $this->getStorage()->set((string) $token, json_encode($token->mget()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2			/**
3			* Library for confirmation tokens.
4			*
5			* @link https://github.com/hiqdev/php-confirmator
6			* @package php-confirmator
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2016-2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\php\confirmator;
12
13			trait ServiceTrait
14			{
15			/**
16			* @param array $data
17			* @return Token
18			*/
19			public function issueToken(array $data)
20			{
21			$token = new Token($this, $data);
22			$this->writeToken($token);
23
24			return $token;
25			}
26
27			public function checkToken($token, array $data)
28			{
29			$token = $this->findToken($token);
30			if (!$token) {
31			return false;
32			}
33
34			return $token->check($data);
35			}
36
37			public function findToken($token)
38			{
39			if ($token instanceof Token) {
40			return $token;
41			}
42
43			$data = $this->readToken($token);
44
45			return empty($data) ? null : new Token($this, $data, $token);
46			}
47
48			public function removeToken($token)
49			{
50			return $this->getStorage()->remove((string) $token);
			0 ignored issues – show Bug introduced 2016-10-27 13:28 UTC by Report Bug Copy Issue Report It seems like `getStorage()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
51			}
52
53			protected function readToken($string)
54			{
55			return $this->getStorage()->has($string) ? json_decode($this->getStorage()->get($string), true) : null;
			0 ignored issues – show Bug introduced 2016-10-13 08:33 UTC by Report Bug Copy Issue Report It seems like `getStorage()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
56			}
57
58			protected function writeToken(Token $token)
59			{
60			return $this->getStorage()->set((string) $token, json_encode($token->mget()));
			0 ignored issues – show Bug introduced 2016-10-13 08:33 UTC by Report Bug Copy Issue Report It seems like `getStorage()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
61			}
62			}
63

hiqdev / php-confirmator

Pull Request — master (#2)

ServiceTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like