hiqdev / omnipay-robokassa

src/Message/CompletePurchaseResponse.php

<?php
/**
 * RoboKassa driver for Omnipay PHP payment library.
 *
 * @link      https://github.com/hiqdev/omnipay-robokassa
 * @package   omnipay-robokassa
 * @license   MIT
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace Omnipay\RoboKassa\Message;

use Omnipay\Common\Exception\InvalidResponseException;
use Omnipay\Common\Message\AbstractResponse;
use Omnipay\Common\Message\RequestInterface;

/**
 * RoboKassa Complete Purchase Response.
 */
class CompletePurchaseResponse extends AbstractResponse
{
    /** @var RequestInterface|CompletePurchaseRequest */
    protected $request;

    public function __construct(RequestInterface $request, $data)
    {
        $this->request = $request;
        $this->data    = $data;

        if (strtolower($this->getSignatureValue(false)) !== $this->generateSignature()) {

The call to Omnipay\RoboKassa\Message\CompletePurchaseResponse::getSignatureValue() has too many arguments starting with false.

            if (strtolower($this->getSignatureValue(true) !== $this->generateSignature())) {

$this->getSignatureValue(true) !== $this->generateSignature() of type boolean is incompatible with the type string expected by parameter $string of strtolower().

                throw new InvalidResponseException('Invalid hash');
            }
        }
    }

    public function generateSignature(bool $includeCurrency = false): string
    {
        $params = [
            $this->getAmount(),
            $this->getTransactionReference(),
            $this->request->getSecretKey2()

The method getSecretKey2() does not exist on Omnipay\Common\Message\RequestInterface. It seems like you code against a sub-type of Omnipay\Common\Message\RequestInterface such as Omnipay\RoboKassa\Message\AbstractRequest.

        ];

        foreach ($this->getCustomFields($includeCurrency) as $field => $value) {
            $params[] = "$field=$value";
        }

        return md5(implode(':', $params));
    }

    public function getCustomFields(bool $includeCurrency = false): array
    {
        $fields = array_filter([
            'Shp_TransactionId' => $this->getTransactionId(),
            'Shp_Client' => $this->getClient(),
            'Shp_Currency' => $includeCurrency ? $this->getCurrency() : null,
        ]);

        ksort($fields);

        return $fields;
    }

    public function getSignatureValue()
    {
        return $this->data['SignatureValue'];
    }

    public function getClient()
    {
        return $this->data['Shp_Client'];
    }

    public function getAmount()
    {
        return $this->data['OutSum'];
    }

    public function getPayer()
    {
        return $this->data['PaymentMethod'];
    }

    public function getTransactionId()
    {
        return $this->data['Shp_TransactionId'];
    }

    public function getCurrency()
    {
        return $this->data['OutSumCurrency'] ?? 'RUB';
    }

    /**
     * RoboKassa does not provide real transaction reference (ID of payment on RoboKassa side) 😕
     *
     * @return string The InvId property, or 0 (zero) if InvId is not set.
     */
    public function getTransactionReference()
    {
        return $this->data['InvId'] ?? '0';
    }

    public function getInvId()
    {
        return $this->getTransactionReference();
    }

    public function isSuccessful()
    {
        return true;
    }
}