Omnipay\RoboKassa\Message\CompletePurchaseResponse

Complexity

Total Complexity

13

Size/Duplication

Total Lines	83
Duplicated Lines	31.33 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	2
A	generateSignature()	14	14	2
A	getCustomFields()	12	12	1
A	getSignatureValue()	0	4	1
A	getClient()	0	4	1
A	getAmount()	0	4	1
A	getPayer()	0	4	1
A	getTransactionId()	0	4	1
A	getCurrency()	0	4	1
A	getTransactionReference()	0	4	1
A	isSuccessful()	0	4	1

<?php
/**
 * RoboKassa driver for Omnipay PHP payment library.
 *
 * @link      https://github.com/hiqdev/omnipay-robokassa
 * @package   omnipay-robokassa
 * @license   MIT
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace Omnipay\RoboKassa\Message;

use Omnipay\Common\Exception\InvalidResponseException;
use Omnipay\Common\Message\AbstractResponse;
use Omnipay\Common\Message\RequestInterface;

/**
 * RoboKassa Complete Purchase Response.
 */
class CompletePurchaseResponse extends AbstractResponse
{
    /** @var RequestInterface|CompletePurchaseRequest */
    protected $request;

    public function __construct(RequestInterface $request, $data)
    {
        $this->request = $request;
        $this->data    = $data;

        if (strtolower($this->getSignatureValue()) !== $this->generateSignature()) {
            throw new InvalidResponseException('Invalid hash');
        }
    }

    public function generateSignature()

This method seems to be duplicated in your project.

    {
        $params = [
            $this->getAmount(),
            '',
            $this->request->getSecretKey2()

The method getSecretKey2 does only exist in Omnipay\RoboKassa\Message\CompletePurchaseRequest, but not in Omnipay\Common\Message\RequestInterface.

        ];

        foreach ($this->getCustomFields() as $field => $value) {
            $params[] = "$field=$value";
        }

        return md5(implode(':', $params));
    }

    public function getCustomFields()

This method seems to be duplicated in your project.

    {
        $fields = array_filter([
            'Shp_TransactionId' => $this->getTransactionId(),
            'Shp_Client' => $this->getClient(),
            'Shp_Currency' => $this->getCurrency(),
        ]);

        ksort($fields);

        return $fields;
    }

    public function getSignatureValue()
    {
        return $this->data['SignatureValue'];
    }

    public function getClient()
    {
        return $this->data['Shp_Client'];
    }

    public function getAmount()
    {
        return $this->data['OutSum'];
    }

    public function getPayer()
    {
        return $this->data['PaymentMethod'];
    }

    public function getTransactionId()
    {
        return $this->data['Shp_TransactionId'];
    }

    public function getCurrency()
    {
        return $this->data['Shp_Currency'];
    }

    public function getTransactionReference()
    {
        return '';
    }

    public function isSuccessful()
    {
        return true;
    }
}