CompletePurchaseRequestTest::testGetData() - Code Metrics - Inspection of "minor" - hiqdev/omnipay-paypal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0f907a...866d23 )

by Andrii

created 2016-02-03 09:58 UTC

CompletePurchaseRequestTest::testGetData() A

↳ Parent: CompletePurchaseRequestTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	8

Duplication

Lines	11
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	11
loc	11
rs	9.4285
cc	1
eloc	8
nc	1
nop	0

<?php

/*
 * PayPal driver for Omnipay PHP payment library
 *
 * @link      https://github.com/hiqdev/omnipay-paypal
 * @package   omnipay-paypal
 * @license   MIT
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace Omnipay\PayPal\Message;

use Guzzle\Http\Message\Response;
use Omnipay\Tests\TestCase;
use Symfony\Component\HttpFoundation\Request as HttpRequest;

class CompletePurchaseRequestTest extends TestCase
{
    private $request;

    private $purse                  = '[email protected]';
    private $secret                 = '*&^^&$sdf&(23';
    private $hash                   = '33bfff79d7eeffdca9a9ac7b34a78dfc';

    private $description            = 'Test Transaction long description';
    private $transactionId          = '12345ASD67890sd';
    private $transactionReference   = '12345678';
    private $timestamp              = '2016-02-02 16:56:56 UTC';

    private $payer                  = '[email protected]';
    private $amount                 = '1465.01';
    private $testMode               = false;
    private $response               = 'VERIFIED';

    public function setUp()
    {
        parent::setUp();

        $httpResponse = new Response(200, null, $this->response);

        $tmpRequest = $this->getMock('Guzzle\Http\Message\Request', ['send'], ['POST', '']);
        $tmpRequest->expects($this->any())->method('send')->will($this->returnValue($httpResponse));

        $httpClient = $this->getMock('Guzzle\Http\Client', ['setConfig', 'post']);
        $httpClient->expects($this->any())->method('post')->will($this->returnValue($tmpRequest));

        $httpRequest = new HttpRequest([], [
            'business'          => $this->purse,
            'payment_gross'     => $this->amount,
            'item_name'         => $this->description,
            'mc_currency'       => $this->currency,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'payer_email'       => $this->payer,
            'payment_date'      => $this->time,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'item_number'       => $this->transactionId,
            'txn_id'            => $this->transactionReference,
        ]);

        $this->request = new CompletePurchaseRequest($httpClient, $httpRequest);
        $this->request->initialize([
            'purse'     => $this->purse,
            'secret'    => $this->secret,
            'testMode'  => $this->testMode,
        ]);
    }

    public function testGetData()

    {
        $data = $this->request->getData();

        $this->assertSame($this->purse,         $data['business']);
        $this->assertSame($this->description,   $data['item_name']);
        $this->assertSame($this->transactionId, $data['item_number']);
        $this->assertSame($this->amount,        $data['payment_gross']);
        $this->assertSame($this->time,          $data['payment_date']);
        $this->assertSame($this->payer,         $data['payer_email']);
    }

    public function testSendData()
    {
        $data = $this->request->getData();
        $response = $this->request->sendData($data);
        $this->assertInstanceOf('Omnipay\PayPal\Message\CompletePurchaseResponse', $response);
    }
}


1		<?php
2
3		/*
4		* PayPal driver for Omnipay PHP payment library
5		*
6		* @link https://github.com/hiqdev/omnipay-paypal
7		* @package omnipay-paypal
8		* @license MIT
9		* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10		*/
11
12		namespace Omnipay\PayPal\Message;
13
14		use Guzzle\Http\Message\Response;
15		use Omnipay\Tests\TestCase;
16		use Symfony\Component\HttpFoundation\Request as HttpRequest;
17
18		class CompletePurchaseRequestTest extends TestCase
19		{
20		private $request;
21
22		private $purse = '[email protected]';
23		private $secret = '*&^^&$sdf&(23';
24		private $hash = '33bfff79d7eeffdca9a9ac7b34a78dfc';
		0 ignored issues – show Unused Code introduced 2016-02-03 10:00 UTC by Report Bug Copy Issue Report The property `$hash` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
25		private $description = 'Test Transaction long description';
26		private $transactionId = '12345ASD67890sd';
27		private $transactionReference = '12345678';
28		private $timestamp = '2016-02-02 16:56:56 UTC';
		0 ignored issues – show Unused Code introduced 2016-02-03 10:00 UTC by Report Bug Copy Issue Report The property `$timestamp` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
29		private $payer = '[email protected]';
30		private $amount = '1465.01';
31		private $testMode = false;
32		private $response = 'VERIFIED';
33
34		public function setUp()
35		{
36		parent::setUp();
37
38		$httpResponse = new Response(200, null, $this->response);
39
40		$tmpRequest = $this->getMock('Guzzle\Http\Message\Request', ['send'], ['POST', '']);
41		$tmpRequest->expects($this->any())->method('send')->will($this->returnValue($httpResponse));
42
43		$httpClient = $this->getMock('Guzzle\Http\Client', ['setConfig', 'post']);
44		$httpClient->expects($this->any())->method('post')->will($this->returnValue($tmpRequest));
45
46		$httpRequest = new HttpRequest([], [
47		'business' => $this->purse,
48		'payment_gross' => $this->amount,
49		'item_name' => $this->description,
50		'mc_currency' => $this->currency,
		0 ignored issues – show Bug introduced 2016-02-03 10:00 UTC by Report Bug Copy Issue Report The property `currency` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
51		'payer_email' => $this->payer,
52		'payment_date' => $this->time,
		0 ignored issues – show Bug introduced 2016-02-03 10:00 UTC by Report Bug Copy Issue Report The property `time` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
53		'item_number' => $this->transactionId,
54		'txn_id' => $this->transactionReference,
55		]);
56
57		$this->request = new CompletePurchaseRequest($httpClient, $httpRequest);
58		$this->request->initialize([
59		'purse' => $this->purse,
60		'secret' => $this->secret,
61		'testMode' => $this->testMode,
62		]);
63		}
64
65	View Code Duplication	public function testGetData()
		0 ignored issues – show Duplication introduced 2016-02-03 10:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		{
67		$data = $this->request->getData();
68
69		$this->assertSame($this->purse, $data['business']);
70		$this->assertSame($this->description, $data['item_name']);
71		$this->assertSame($this->transactionId, $data['item_number']);
72		$this->assertSame($this->amount, $data['payment_gross']);
73		$this->assertSame($this->time, $data['payment_date']);
74		$this->assertSame($this->payer, $data['payer_email']);
75		}
76
77		public function testSendData()
78		{
79		$data = $this->request->getData();
80		$response = $this->request->sendData($data);
81		$this->assertInstanceOf('Omnipay\PayPal\Message\CompletePurchaseResponse', $response);
82		}
83		}
84

hiqdev / omnipay-paypal

Push — master ( 0f907a...866d23 )

CompletePurchaseRequestTest::testGetData() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like