PurchaseResponse::getRedirectMethod() - Code Metrics - hiqdev/omnipay-paypal - Measure and Improve Code Quality continuously with Scrutinizer

PurchaseResponse::getRedirectMethod() A
last analyzed 2018-02-19 10:44 UTC

↳ Parent: PurchaseResponse

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	1
cts	1
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

/*
 * PayPal driver for Omnipay PHP payment library
 *
 * @link      https://github.com/hiqdev/omnipay-paypal
 * @package   omnipay-paypal
 * @license   MIT
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace Omnipay\PayPal\Message;

use Omnipay\Common\Message\AbstractResponse;
use Omnipay\Common\Message\RedirectResponseInterface;

/**
 * PayPal Purchase Response.
 */
class PurchaseResponse extends AbstractResponse implements RedirectResponseInterface
{
    public function isSuccessful()
    {
        return false;
    }

    public function isRedirect()
    {
        return true;
    }

    public function getRedirectUrl()
    {
        return $this->request->getEndpoint();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getRedirectMethod()
    {
        return 'POST';
    }

    public function getRedirectData()
    {
        return $this->data;
    }
}


1		<?php
2
3		/*
4		* PayPal driver for Omnipay PHP payment library
5		*
6		* @link https://github.com/hiqdev/omnipay-paypal
7		* @package omnipay-paypal
8		* @license MIT
9		* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10		*/
11
12		namespace Omnipay\PayPal\Message;
13
14		use Omnipay\Common\Message\AbstractResponse;
15		use Omnipay\Common\Message\RedirectResponseInterface;
16
17		/**
18		* PayPal Purchase Response.
19		*/
20		class PurchaseResponse extends AbstractResponse implements RedirectResponseInterface
21	1	{
22		public function isSuccessful()
23	1	{
24		return false;
25		}
26	1
27		public function isRedirect()
28	1	{
29		return true;
30		}
31	1
32		public function getRedirectUrl()
33	1	{
34		return $this->request->getEndpoint();
		0 ignored issues – show Bug introduced 2016-01-17 18:20 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Omnipay\Common\Message\RequestInterface` as the method `getEndpoint()` does only exist in the following implementations of said interface: `Omnipay\PayPal\Message\AbstractRequest`, `Omnipay\PayPal\Message\CompletePurchaseRequest`, `Omnipay\PayPal\Message\PurchaseRequest`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
35		}
36	1
37		public function getRedirectMethod()
38	1	{
39		return 'POST';
40		}
41	1
42		public function getRedirectData()
43	1	{
44		return $this->data;
45		}
46		}
47

hiqdev / omnipay-paypal

PurchaseResponse::getRedirectMethod() A last analyzed 2018-02-19 10:44 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

PurchaseResponse::getRedirectMethod() A
last analyzed 2018-02-19 10:44 UTC