Omnipay\OKPAY\Message\CompletePurchaseRequest::getData()

Complexity

Conditions	10
Paths	48

Size

Total Lines	48
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes

0

<?php
    public function getData()
    {
        $request = 'ok_verify=true';

        foreach ($this->httpRequest->request->all() as $key => $value) {
            $value = urlencode(stripslashes($value));
            $request .= "&$key=$value";
        }

        $fsocket = false;
        $result = false;

        if ($fp = @fsockopen('ssl://www.okpay.com', 443, $errno, $errstr, 30)) {
            // Connected via HTTPS
            $fsocket = true;
        } elseif ($fp = @fsockopen('www.okpay.com', 80, $errno, $errstr, 30)) {
            // Connected via HTTP
            $fsocket = true;
        }

        // If connected to OKPAY
        if ($fsocket === true) {
            $header = 'POST /ipn-verify.html HTTP/1.0' . "\r\n" .
                'Host: www.okpay.com' . "\r\n" .
                'Content-Type: application/x-www-form-urlencoded' . "\r\n" .
                'Content-Length: ' . strlen($request) . "\r\n" .
                'Connection: close' . "\r\n\r\n";

            @fputs($fp, $header . $request);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            $string = '';
            while (!@feof($fp)) {
                $res = @fgets($fp, 1024);
                $string .= $res;
                // Find verification result in response
                if ($res === 'VERIFIED' || $res === 'INVALID' || $res === 'TEST') {
                    $result = $res;
                    break;
                }
            }
            @fclose($fp);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }

        if ($result !== 'VERIFIED') {
            throw new InvalidResponseException('IPN verify failed: ' . $result);
        }

        return $this->httpRequest->request->all();
    }