Omnipay\OKPAY\Message\NoVerificationCompletePurchaseRequest

Complexity

Total Complexity

1

Size/Duplication

Total Lines	7
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getData()	0	4	1

<?php
/**
 * OKPAY driver for Omnipay PHP payment library.
 *
 * @link      https://github.com/hiqdev/omnipay-okpay
 * @package   omnipay-okpay
 * @license   MIT
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace Omnipay\OKPAY\Message;

use Omnipay\Tests\TestCase;
use Symfony\Component\HttpFoundation\Request as HttpRequest;

class CompletePurchaseRequestTest extends TestCase
{
    private $request;

    private $purse                  = 'OK426375940';
    private $description            = 'evo.ru-tld.ru: deposit valenp';
    private $transactionId          = 2705801;
    private $amount                 = 68.71;
    private $currency               = 'USD';

The property $currency is not used and could be removed.

    private $timestamp              = '2014-03-22 19:54:58';
    private $testMode               = true;

    private $data = [

Consider using a different property name as you override a private property of the parent class.

        'ok_charset' => 'utf-8',
        'ok_receiver' => 'OK426375940',
        'ok_receiver_id' => '532844008',
        'ok_receiver_wallet' => 'OK426375940',
        'ok_receiver_email' => 'ilia@krukover.com',
        'ok_txn_id' => 2705801,
        'ok_txn_kind' => 'payment_link',
        'ok_txn_payment_type' => 'instant',
        'ok_txn_payment_method' => 'OKB',
        'ok_txn_gross' => '68.71',
        'ok_txn_net' => '68.71',
        'ok_txn_fee' => '0.00',
        'ok_txn_currency' => 'USD',
        'ok_txn_datetime' => '2014-03-22 19:54:58',
        'ok_txn_status' => 'completed',
        'ok_invoice' => '',
        'ok_payer_status' => 'verified',
        'ok_payer_id' => '914126735',
        'ok_payer_reputation' => '0',
        'ok_payer_first_name' => 'Valentin',
        'ok_payer_last_name' => 'Perevalov',
        'ok_payer_email' => 'valenp@mail.ru',
        'ok_payer_phone' => '7-9080858303',
        'ok_payer_country' => 'Russia',
        'ok_payer_city' => 'Chelyabinsk',
        'ok_payer_country_code' => 'RU',
        'ok_payer_state' => 'Chelyabinskaya obl.',
        'ok_payer_address_status' => 'confirmed',
        'ok_payer_street' => 'Truda 24-136',
        'ok_payer_zip' => '454006',
        'ok_payer_address_name' => 'Postal',
        'ok_items_count' => '1',
        'ok_item_1_name' => 'evo.ru-tld.ru: deposit valenp',
        'ok_item_1_type' => 'digital',
        'ok_item_1_quantity' => '1',
        'ok_item_1_gross' => '68.71',
        'ok_item_1_price' => '68.71',
        'ok_ipn_id' => '2011795',
    ];

    public function setUp()
    {
        parent::setUp();

        $httpRequest = new HttpRequest([], $this->data);

        $this->request = new NoVerificationCompletePurchaseRequest($this->getHttpClient(), $httpRequest);
        $this->request->initialize([
            'purse'     => $this->purse,
            'secret'    => $this->secret,

The property secret does not exist. Did you maybe forget to declare it?

            'testMode'  => $this->testMode,
        ]);
    }

    public function testGetData()

This method seems to be duplicated in your project.

    {
        $data = $this->request->getData();

        $this->assertSame($this->description,   $data['ok_item_1_name']);
        $this->assertSame($this->transactionId, $data['ok_txn_id']);
        $this->assertEquals($this->amount,      $data['ok_txn_gross']);
        $this->assertSame($this->timestamp,     $data['ok_txn_datetime']);
        $this->assertSame($this->purse,         $data['ok_receiver']);
    }

    public function testSendData()
    {
        //        $data = $this->request->getData();

54% of this comment could be valid code. Did you maybe forget this after debugging?

        $response = $this->request->sendData($this->data);
        $this->assertInstanceOf('Omnipay\OKPAY\Message\CompletePurchaseResponse', $response);
    }
}

class NoVerificationCompletePurchaseRequest extends CompletePurchaseRequest

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    public function getData()
    {
        return $this->httpRequest->request->all();
    }
}