Omnipay\OKPAY\Message\CompletePurchaseRequest

Complexity

Total Complexity

11

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	5

Test Coverage

Coverage

7.14%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	sendData()	0	4	1
C	getData()	0	48	10

<?php
/**
 * OKPAY driver for Omnipay PHP payment library.
 *
 * @link      https://github.com/hiqdev/omnipay-okpay
 * @package   omnipay-okpay
 * @license   MIT
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace Omnipay\OKPAY\Message;

use Omnipay\Common\Exception\InvalidResponseException;

class CompletePurchaseRequest extends AbstractRequest
{
    public function getData()
    {
        $request = 'ok_verify=true';

        foreach ($this->httpRequest->request->all() as $key => $value) {
            $value = urlencode(stripslashes($value));
            $request .= "&$key=$value";
        }

        $fsocket = false;
        $result = false;

        if ($fp = @fsockopen('ssl://www.okpay.com', 443, $errno, $errstr, 30)) {
            // Connected via HTTPS
            $fsocket = true;
        } elseif ($fp = @fsockopen('www.okpay.com', 80, $errno, $errstr, 30)) {
            // Connected via HTTP
            $fsocket = true;
        }

        // If connected to OKPAY
        if ($fsocket === true) {
            $header = 'POST /ipn-verify.html HTTP/1.0' . "\r\n" .
                'Host: www.okpay.com' . "\r\n" .
                'Content-Type: application/x-www-form-urlencoded' . "\r\n" .
                'Content-Length: ' . strlen($request) . "\r\n" .
                'Connection: close' . "\r\n\r\n";

            @fputs($fp, $header . $request);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            $string = '';
            while (!@feof($fp)) {
                $res = @fgets($fp, 1024);
                $string .= $res;
                // Find verification result in response
                if ($res === 'VERIFIED' || $res === 'INVALID' || $res === 'TEST') {
                    $result = $res;
                    break;
                }
            }
            @fclose($fp);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }

        if ($result !== 'VERIFIED') {
            throw new InvalidResponseException('IPN verify failed: ' . $result);
        }

        return $this->httpRequest->request->all();
    }

    public function sendData($data)
    {
        return $this->response = new CompletePurchaseResponse($this, $data);
    }
}