PurchaseResponse - Code Metrics - hiqdev/omnipay-okpay - Measure and Improve Code Quality continuously with Scrutinizer

PurchaseResponse A
last analyzed 2019-10-17 15:54 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

85.71%

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	1
dl	0
loc	36
ccs	12
cts	14
cp	0.8571
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	__construct()	6	1
A	isSuccessful()	4	1
A	isRedirect()	4	1
A	getRedirectUrl()	4	1
A	getRedirectMethod()	4	1
A	getRedirectData()	4	1

<?php
/**
 * OKPAY driver for Omnipay PHP payment library.
 *
 * @link      https://github.com/hiqdev/omnipay-okpay
 * @package   omnipay-okpay
 * @license   MIT
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace Omnipay\OKPAY\Message;

use Omnipay\Common\Message\AbstractResponse;
use Omnipay\Common\Message\RedirectResponseInterface;
use Omnipay\Common\Message\RequestInterface;

class PurchaseResponse extends AbstractResponse implements RedirectResponseInterface
{
    protected $redirectUrl;

    public function __construct(RequestInterface $request, $data, $redirectUrl)
    {
        parent::__construct($request, $data);

        $this->redirectUrl = $redirectUrl;
    }

    public function isSuccessful()
    {
        return false;
    }

    public function isRedirect()
    {
        return true;
    }

    public function getRedirectUrl()
    {
        return $this->getRequest()->getEndpoint();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getRedirectMethod()
    {
        return 'POST';
    }

    public function getRedirectData()
    {
        return $this->data;
    }
}


1		<?php
2		/**
3		* OKPAY driver for Omnipay PHP payment library.
4		*
5		* @link https://github.com/hiqdev/omnipay-okpay
6		* @package omnipay-okpay
7		* @license MIT
8		* @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace Omnipay\OKPAY\Message;
12
13		use Omnipay\Common\Message\AbstractResponse;
14		use Omnipay\Common\Message\RedirectResponseInterface;
15		use Omnipay\Common\Message\RequestInterface;
16
17		class PurchaseResponse extends AbstractResponse implements RedirectResponseInterface
18		{
19		protected $redirectUrl;
20
21	2	public function __construct(RequestInterface $request, $data, $redirectUrl)
22		{
23	2	parent::__construct($request, $data);
24
25	2	$this->redirectUrl = $redirectUrl;
26	2	}
27
28	1	public function isSuccessful()
29		{
30	1	return false;
31		}
32
33	1	public function isRedirect()
34		{
35	1	return true;
36		}
37
38		public function getRedirectUrl()
39		{
40		return $this->getRequest()->getEndpoint();
		0 ignored issues – show Bug introduced 2017-10-10 12:01 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Omnipay\Common\Message\RequestInterface` as the method `getEndpoint()` does only exist in the following implementations of said interface: `Omnipay\OKPAY\Message\AbstractRequest`, `Omnipay\OKPAY\Message\CompletePurchaseRequest`, `Omnipay\OKPAY\Message\No...CompletePurchaseRequest`, `Omnipay\OKPAY\Message\PurchaseRequest`, `Omnipay\OKPAY\Message\RefundRequest`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
41		}
42
43	1	public function getRedirectMethod()
44		{
45	1	return 'POST';
46		}
47
48	1	public function getRedirectData()
49		{
50	1	return $this->data;
51		}
52		}
53

hiqdev / omnipay-okpay

PurchaseResponse A last analyzed 2019-10-17 15:54 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like

PurchaseResponse A
last analyzed 2019-10-17 15:54 UTC