Omnipay\InterKassa\Tests\Message\OldPurchaseResponseTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	64
Duplicated Lines	39.06 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	4
Bugs	0	Features	3

2 Methods

Rating	Name	Duplication	Size	Complexity
B	setUp()	25	25	1
B	testSuccess()	0	25	1

<?php

/*
 * InterKassa driver for the Omnipay PHP payment processing library
 *
 * @link      https://github.com/hiqdev/omnipay-interkassa
 * @package   omnipay-interkassa
 * @license   MIT
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace Omnipay\InterKassa\Tests\Message;

use Omnipay\InterKassa\Message\OldPurchaseRequest;
use Omnipay\InterKassa\Message\PurchaseResponse;
use Omnipay\InterKassa\Stubs\OldPurchaseResponseStub;

class OldPurchaseResponseTest extends PurchaseResponseTest
{
    /**
     * @var PurchaseResponse
     */
    protected $request;

    /**
     * @var OldPurchaseResponseStub
     */
    private $stub;

Consider using a different property name as you override a private property of the parent class.

    public function setUp()

This method seems to be duplicated in your project.

    {
        parent::setUp();

        $this->stub = new OldPurchaseResponseStub();
        $stub = $this->stub;

        $this->request = new OldPurchaseRequest($this->getHttpClient(), $this->getHttpRequest());

It seems like new \Omnipay\InterKassa\Message\OldPurchaseRequest($this->getHttpClient(), $this->getHttpRequest()) of type object<Omnipay\InterKassa\Message\OldPurchaseRequest> is incompatible with the declared type object<Omnipay\InterKassa\Message\PurchaseResponse> of property $request.

        $this->request->initialize([
            'purse' => $stub->purse,
            'signAlgorithm' => $stub->signAlgorithm,
            'signKey' => $stub->signKey,
            'testKey' => $stub->testKey,
            'returnUrl' => $stub->returnUrl,
            'cancelUrl' => $stub->cancelUrl,
            'notifyUrl' => $stub->notifyUrl,
            'returnMethod' => $stub->returnMethod,
            'cancelMethod' => $stub->cancelMethod,
            'notifyMethod' => $stub->notifyMethod,
            'description' => $stub->description,
            'transactionId' => $stub->transactionId,
            'amount' => $stub->amount,
            'currency' => $stub->currency,
        ]);
    }

    public function testSuccess()
    {
        /** @var PurchaseResponse $response */
        $response = $this->request->send();

The method send() does not seem to exist on object<Omnipay\InterKassa\Message\PurchaseResponse>.

        $stub = $this->stub;

        $this->assertFalse($response->isSuccessful());
        $this->assertTrue($response->isRedirect());
        $this->assertNull($response->getCode());
        $this->assertNull($response->getMessage());

        $this->assertSame('POST', $response->getRedirectMethod());
        $this->assertSame([
            'ik_shop_id' => $stub->purse,
            'ik_payment_amount' => $stub->amount,
            'ik_payment_id' => $stub->transactionId,
            'ik_payment_desc' => $stub->description,
            'ik_success_url' => $stub->returnUrl,
            'ik_success_method' => $stub->returnMethod,
            'ik_fail_url' => $stub->cancelUrl,
            'ik_fail_method' => $stub->cancelMethod,
            'ik_status_url' => $stub->notifyUrl,
            'ik_status_method' => $stub->notifyMethod,
        ], $response->getRedirectData());
    }
}