Completed
Push — master ( a52065...6a2a6b )
by Dmitry
02:22
created

CompletePurchaseResponse::getPayer()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 0
loc 4
ccs 0
cts 4
cp 0
rs 10
c 0
b 0
f 0
cc 1
eloc 2
nc 1
nop 0
crap 2
1
<?php
2
/**
3
 * FreeKassa driver for Omnipay PHP payment library
4
 *
5
 * @link      https://github.com/hiqdev/omnipay-freekassa
6
 * @package   omnipay-freekassa
7
 * @license   MIT
8
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace Omnipay\FreeKassa\Message;
12
13
use Omnipay\Common\Exception\InvalidResponseException;
14
use Omnipay\Common\Message\AbstractResponse;
15
use Omnipay\Common\Message\RequestInterface;
16
17
/**
18
 * FreeKassa Complete Purchase Response.
19
 */
20
class CompletePurchaseResponse extends AbstractResponse
21
{
22
    /**
23
     * @var CompletePurchaseRequest|RequestInterface
24
     */
25
    protected $request;
26
27
    public function __construct(RequestInterface $request, $data)
28
    {
29
        $this->request = $request;
30
        $this->data    = $data;
31
32
        if ($this->getSign() !== $this->calculateSignature()) {
33
            throw new InvalidResponseException('Invalid hash');
34
        }
35
    }
36
37
    public function calculateSignature()
38
    {
39
        return md5(implode(':', [
40
            $this->getPurse(),
41
            $this->getAmount(),
42
            $this->request->getSecretKey2(),
0 ignored issues
show
Bug introduced by SilverFire - Dmitry Naumenko
The method getSecretKey2 does only exist in Omnipay\FreeKassa\Message\CompletePurchaseRequest, but not in Omnipay\Common\Message\RequestInterface.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
43
            $this->getTransactionId()
44
        ]));
45
    }
46
47
    public function getTransactionId()
48
    {
49
        return $this->data['MERCHANT_ORDER_ID'];
50
    }
51
52
    public function isSuccessful()
53
    {
54
        return true;
55
    }
56
57
    public function getPayer()
58
    {
59
        return $this->data['P_EMAIL'] . ' / ' . $this->getPaymentSystem();
60
    }
61
62
    public function getTransactionReference()
63
    {
64
        return $this->data['intid'];
65
    }
66
67
    public function getPurse()
68
    {
69
        return $this->data['MERCHANT_ID'];
70
    }
71
72
    public function getAmount()
73
    {
74
        return (string)$this->data['AMOUNT'];
75
    }
76
77
    public function getSign()
78
    {
79
        return $this->data['SIGN'];
80
    }
81
82
    public function getTime()
83
    {
84
        return $this->data['us_time'];
85
    }
86
87
    /**
88
     * @see http://www.free-kassa.ru/docs/api.php#ex_currencies
89
     * @return string
90
     */
91
    protected function getPaymentSystem()
92
    {
93
        $map = [
94
            1 => 'WebMoney WMR',
95
            2 => 'WebMoney WMZ',
96
            3 => 'WebMoney WME',
97
            45 => 'Яндекс.Деньги',
98
            60 => 'OKPAY RUB',
99
            61 => 'OKPAY EUR',
100
            62 => 'OKPAY USD',
101
            63 => 'QIWI кошелек',
102
            64 => 'Perfect Money USD',
103
            67 => 'VISA/MASTERCARD UAH',
104
            69 => 'Perfect Money EUR',
105
            70 => 'PayPal',
106
            79 => 'Альфа-банк RUR',
107
            80 => 'Сбербанк RUR',
108
            82 => 'Мобильный Платеж Мегафон',
109
            83 => 'Мобильный Платеж Билайн',
110
            84 => 'Мобильный Платеж МТС',
111
            87 => 'OOOPAY USD',
112
            94 => 'VISA/MASTERCARD RUB',
113
            99 => 'Терминалы России',
114
            106 => 'OOOPAY RUR',
115
            109 => 'OOOPAY EUR',
116
            110 => 'Промсвязьбанк',
117
            114 => 'PAYEER RUB',
118
            116 => 'Bitcoin',
119
            117 => 'Денежные переводы',
120
            118 => 'Салоны связи',
121
            121 => 'WMR',
122
            124 => 'VISA/MASTERCARD EUR',
123
            130 => 'WMR-bill',
124
            131 => 'WMZ-bill',
125
            132 => 'Мобильный Платеж Tele2',
126
            133 => 'FK WALLET RUB',
127
            136 => 'ADVCASH USD',
128
            137 => 'Мобильный Платеж МегаФон Северо-Западный филиал',
129
            138 => 'Мобильный Платеж МегаФон Сибирский филиал',
130
            139 => 'Мобильный Платеж МегаФон Кавказский филиал',
131
            140 => 'Мобильный Платеж МегаФон Поволжский филиал',
132
            141 => 'Мобильный Платеж МегаФон Уральский филиал',
133
            142 => 'Мобильный Платеж МегаФон Дальневосточный филиал',
134
            143 => 'Мобильный Платеж МегаФон Центральный филиал',
135
            147 => 'Litecoin',
136
            150 => 'ADVCASH RUB',
137
            153 => 'VISA/MASTERCARD+ RUB',
138
            154 => 'Skin pay',
139
            155 => 'QIWI WALLET',
140
            156 => 'QIWI RUB',
141
            157 => 'VISA UAH CASHOUT',
142
            158 => 'VISA/MC INT',
143
            159 => 'CARD P2P',
144
        ];
145
146
        return isset($map[$this->data['CUR_ID']])
147
            ? $map[$this->data['CUR_ID']]
148
            : '';
149
    }
150
}
151