CompletePurchaseResponse   A
last analyzed

Complexity

Total Complexity 13

Size/Duplication

Total Lines 134
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 2

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
wmc 13
lcom 1
cbo 2
dl 0
loc 134
ccs 0
cts 105
cp 0
rs 10
c 0
b 0
f 0

12 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 9 2
A calculateSignature() 0 9 1
A getTransactionId() 0 4 1
A isSuccessful() 0 4 1
A getPayer() 0 4 1
A getTransactionReference() 0 4 1
A getPurse() 0 4 1
A getAmount() 0 4 1
A getSign() 0 4 1
A getTime() 0 4 1
A getCurrency() 0 4 1
B getPaymentSystem() 0 57 1
1
<?php
2
/**
3
 * FreeKassa driver for Omnipay PHP payment library
4
 *
5
 * @link      https://github.com/hiqdev/omnipay-freekassa
6
 * @package   omnipay-freekassa
7
 * @license   MIT
8
 * @copyright Copyright (c) 2017, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace Omnipay\FreeKassa\Message;
12
13
use Omnipay\Common\Exception\InvalidResponseException;
14
use Omnipay\Common\Message\AbstractResponse;
15
use Omnipay\Common\Message\RequestInterface;
16
17
/**
18
 * FreeKassa Complete Purchase Response.
19
 */
20
class CompletePurchaseResponse extends AbstractResponse
21
{
22
    /**
23
     * @var CompletePurchaseRequest|RequestInterface
24
     */
25
    protected $request;
26
27
    public function __construct(RequestInterface $request, $data)
28
    {
29
        $this->request = $request;
30
        $this->data    = $data;
31
32
        if ($this->getSign() !== $this->calculateSignature()) {
33
            throw new InvalidResponseException('Invalid hash');
34
        }
35
    }
36
37
    public function calculateSignature()
38
    {
39
        return md5(implode(':', [
40
            $this->getPurse(),
41
            $this->getAmount(),
42
            $this->request->getSecretKey2(),
0 ignored issues
show
Bug introduced by SilverFire - Dmitry Naumenko
The method getSecretKey2 does only exist in Omnipay\FreeKassa\Message\CompletePurchaseRequest, but not in Omnipay\Common\Message\RequestInterface.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
43
            $this->getTransactionId()
44
        ]));
45
    }
46
47
    public function getTransactionId()
48
    {
49
        return $this->data['MERCHANT_ORDER_ID'];
50
    }
51
52
    public function isSuccessful()
53
    {
54
        return true;
55
    }
56
57
    public function getPayer()
58
    {
59
        return $this->data['P_EMAIL'] . ' / ' . $this->getPaymentSystem();
60
    }
61
62
    public function getTransactionReference()
63
    {
64
        return $this->data['intid'];
65
    }
66
67
    public function getPurse()
68
    {
69
        return $this->data['MERCHANT_ID'];
70
    }
71
72
    public function getAmount()
73
    {
74
        return (string)$this->data['AMOUNT'];
75
    }
76
77
    public function getSign()
78
    {
79
        return $this->data['SIGN'];
80
    }
81
82
    public function getTime()
83
    {
84
        return $this->data['us_time'];
85
    }
86
87
    public function getCurrency()
88
    {
89
        return $this->data['us_currency'] ?? 'RUB';
90
    }
91
92
    /**
93
     * @see http://www.free-kassa.ru/docs/api.php#ex_currencies
94
     * @return string
95
     */
96
    protected function getPaymentSystem()
97
    {
98
        $map = [
99
            1 => 'WebMoney WMR',
100
            2 => 'WebMoney WMZ',
101
            3 => 'WebMoney WME',
102
            45 => 'Яндекс.Деньги',
103
            60 => 'OKPAY RUB',
104
            61 => 'OKPAY EUR',
105
            62 => 'OKPAY USD',
106
            63 => 'QIWI кошелек',
107
            64 => 'Perfect Money USD',
108
            67 => 'VISA/MASTERCARD UAH',
109
            69 => 'Perfect Money EUR',
110
            70 => 'PayPal',
111
            79 => 'Альфа-банк RUR',
112
            80 => 'Сбербанк RUR',
113
            82 => 'Мобильный Платеж Мегафон',
114
            83 => 'Мобильный Платеж Билайн',
115
            84 => 'Мобильный Платеж МТС',
116
            87 => 'OOOPAY USD',
117
            94 => 'VISA/MASTERCARD RUB',
118
            99 => 'Терминалы России',
119
            106 => 'OOOPAY RUR',
120
            109 => 'OOOPAY EUR',
121
            110 => 'Промсвязьбанк',
122
            114 => 'PAYEER RUB',
123
            116 => 'Bitcoin',
124
            117 => 'Денежные переводы',
125
            118 => 'Салоны связи',
126
            121 => 'WMR',
127
            124 => 'VISA/MASTERCARD EUR',
128
            130 => 'WMR-bill',
129
            131 => 'WMZ-bill',
130
            132 => 'Мобильный Платеж Tele2',
131
            133 => 'FK WALLET RUB',
132
            136 => 'ADVCASH USD',
133
            137 => 'Мобильный Платеж МегаФон Северо-Западный филиал',
134
            138 => 'Мобильный Платеж МегаФон Сибирский филиал',
135
            139 => 'Мобильный Платеж МегаФон Кавказский филиал',
136
            140 => 'Мобильный Платеж МегаФон Поволжский филиал',
137
            141 => 'Мобильный Платеж МегаФон Уральский филиал',
138
            142 => 'Мобильный Платеж МегаФон Дальневосточный филиал',
139
            143 => 'Мобильный Платеж МегаФон Центральный филиал',
140
            147 => 'Litecoin',
141
            150 => 'ADVCASH RUB',
142
            153 => 'VISA/MASTERCARD+ RUB',
143
            154 => 'Skin pay',
144
            155 => 'QIWI WALLET',
145
            156 => 'QIWI RUB',
146
            157 => 'VISA UAH CASHOUT',
147
            158 => 'VISA/MC INT',
148
            159 => 'CARD P2P',
149
        ];
150
151
        return $map[$this->data['CUR_ID']] ?? '';
152
    }
153
}
154