IniterTest::testReinit() - Code Metrics - Inspection of "Optimized tests: changed to run `reinit` only once" - hiqdev/hipanel-rbac - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 244792...f2153d )

by Andrii

created 2019-02-24 12:15 UTC

IniterTest::testReinit() A

↳ Parent: IniterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php
/**
 * RBAC implementation for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-rbac
 * @package   hipanel-rbac
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\rbac\tests\unit;

use hipanel\rbac\AuthManager;
use hipanel\rbac\Initer;

/**
 * AuthManagerTest class.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class IniterTest extends \PHPUnit\Framework\TestCase
filter:
    dependency_paths: ["lib/*"]
{
    use CheckAccessTrait;

    /**
     * @var AuthManager
     */
    protected $auth;

    protected function setUp()
    {
        $this->auth = $this->createObject(AuthManager::class);

        $this->setAssignments();
    }

    public function testReinit()
    {
        $this->assertNull((new Initer())->reinit($this->auth));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    protected function createObject($config)
    {
        return class_exists('Yii') ? \Yii::createObject($config) : \yii\helpers\Yii::createObject($config);
filter:
    dependency_paths: ["lib/*"]
    }
}


1			<?php
2			/**
3			* RBAC implementation for HiPanel
4			*
5			* @link https://github.com/hiqdev/hipanel-rbac
6			* @package hipanel-rbac
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2016-2019, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hipanel\rbac\tests\unit;
12
13			use hipanel\rbac\AuthManager;
14			use hipanel\rbac\Initer;
15
16			/**
17			* AuthManagerTest class.
18			*
19			* @author Andrii Vasyliev <[email protected]>
20			*/
21			class IniterTest extends \PHPUnit\Framework\TestCase
			0 ignored issues – show Bug introduced 2018-11-19 17:04 UTC by Report Bug Copy Issue Report The type `PHPUnit\Framework\TestCase` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
22			{
23			use CheckAccessTrait;
24
25			/**
26			* @var AuthManager
27			*/
28			protected $auth;
29
30			protected function setUp()
31			{
32			$this->auth = $this->createObject(AuthManager::class);
33
34			$this->setAssignments();
35			}
36
37			public function testReinit()
38			{
39			$this->assertNull((new Initer())->reinit($this->auth));
			0 ignored issues – show Bug introduced 2019-02-24 12:17 UTC by Report Bug Copy Issue Report Are you sure the usage of `new hipanel\rbac\Initer()->reinit($this->auth)` targeting `hipanel\rbac\AbstractIniter::reinit()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
40			}
41
42			protected function createObject($config)
43			{
44			return class_exists('Yii') ? \Yii::createObject($config) : \yii\helpers\Yii::createObject($config);
			0 ignored issues – show Bug introduced 2019-02-19 20:16 UTC by Report Bug Copy Issue Report The type `yii\helpers\Yii` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
45			}
46			}
47

hiqdev / hipanel-rbac

Push — master ( 244792...f2153d )

IniterTest::testReinit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like