CheckAccessTrait::testDeny() - Code Metrics - Inspection of "refactored tests for simplicity" - hiqdev/hipanel-rbac - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 98ec57...b39146 )

by Andrii

created 2017-08-04 17:18 UTC

CheckAccessTrait::testDeny() A

↳ Parent: CheckAccessTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	9
rs	9.6666
cc	1
eloc	5
nc	1
nop	0

<?php
/**
 * RBAC implementation for HiPanel.
 *
 * @link      https://github.com/hiqdev/hipanel-rbac
 * @package   hipanel-rbac
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016-2017, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\rbac\tests\unit;

trait CheckAccessTrait
{
    public function setAssignments()
    {
        foreach ($this->auth->getAllItems() as $item) {
            $this->auth->setAssignment($item->name, $item->name);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
    }

    public function testPermission()
    {
        foreach ($this->auth->getPermissions() as $user) {
            foreach ($this->auth->getPermissions() as $perm) {
                $this->assertSame($user->name === $perm->name, $this->auth->checkAccess($user->name, $perm->name));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        }
    }

    public function assertAccesses($userId, array $allowedPermissions)
    {
        $allPermissions = array_keys($this->auth->getPermissions());
        foreach ($allPermissions as $key => $permission) {
            if (strncmp('deny:', $permission, 5) === 0) {
                unset($allPermissions[$key]);
            }
        }
        $deniedPermissions = array_diff($allPermissions, $allowedPermissions);

        $this->assertAccess($userId, true, $allowedPermissions);
        $this->assertAccess($userId, false, $deniedPermissions);
    }

    public function assertAccess($userId, $isAllowed, array $permissions)
    {
        foreach ($permissions as $permission) {
            $checked = $this->auth->checkAccess($userId, $permission);
            if ($checked !== $isAllowed) {
                var_dump(compact('userId', 'isAllowed', 'permission'));

            }
            $this->assertSame($isAllowed, $checked);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    public function testUnauthorized()
    {
        $this->assertAccesses('', [
            'restore-password', 'deposit',
        ]);
    }

    public function testClient()
    {
        $this->assertAccesses('role:client', [
            'restore-password', 'deposit',
            'domain.pay', 'domain.push', 'server.pay',
        ]);
    }

    public function testSupport()
    {
        $this->assertAccesses('role:support', [
            'support',
        ]);
    }

    public function testManager()
    {
        $this->assertAccesses('role:manager', [
            'support', 'manage',
            'domain.pay', 'domain.push',
            'server.pay', 'server.sell',
            'document.manage', 'contact.force-verify',
            'mailing.prepare', 'mailing.send',
        ]);
    }

    public function testEmployee()
    {
        $this->assertAccesses('role:employee', [
            'restore-password', 'deposit',
            'domain.pay', 'domain.push', 'server.pay',
            'employee.read',
        ]);
    }

    public function testMighty()
    {
        $this->auth->setAssignments('role:admin,role:manager,bill.create,domain.freeze,domain.force-push,domain.delete,employee.read', 'user:mighty');

        $this->assertAccesses('user:mighty', [
            'support', 'manage', 'admin',
            'employee.read', 'bill.create',
            'domain.freeze', 'domain.push', 'domain.force-push', 'domain.delete',
            'domain.pay', 'server.pay', 'server.sell',
            'document.manage', 'contact.force-verify',
            'mailing.prepare', 'mailing.send',
        ]);
    }

    public function testDeny()
    {
        $this->auth->setAssignments('role:client,deny:deposit,deny:domain.push,deny:server.pay', 'user:limited');

        $this->assertAccesses('user:limited', [
            'restore-password',
            'domain.pay',
        ]);
    }
}


1			<?php
2			/**
3			* RBAC implementation for HiPanel.
4			*
5			* @link https://github.com/hiqdev/hipanel-rbac
6			* @package hipanel-rbac
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2016-2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hipanel\rbac\tests\unit;
12
13			trait CheckAccessTrait
14			{
15			public function setAssignments()
16			{
17			foreach ($this->auth->getAllItems() as $item) {
18			$this->auth->setAssignment($item->name, $item->name);
			0 ignored issues – show Bug introduced 2016-11-04 10:47 UTC by Report Bug Copy Issue Report The property `auth` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			}
20			}
21
22			public function testPermission()
23			{
24			foreach ($this->auth->getPermissions() as $user) {
25			foreach ($this->auth->getPermissions() as $perm) {
26			$this->assertSame($user->name === $perm->name, $this->auth->checkAccess($user->name, $perm->name));
			0 ignored issues – show Bug introduced 2016-11-04 10:47 UTC by Report Bug Copy Issue Report It seems like `assertSame()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			}
28			}
29			}
30
31			public function assertAccesses($userId, array $allowedPermissions)
32			{
33			$allPermissions = array_keys($this->auth->getPermissions());
34			foreach ($allPermissions as $key => $permission) {
35			if (strncmp('deny:', $permission, 5) === 0) {
36			unset($allPermissions[$key]);
37			}
38			}
39			$deniedPermissions = array_diff($allPermissions, $allowedPermissions);
40
41			$this->assertAccess($userId, true, $allowedPermissions);
42			$this->assertAccess($userId, false, $deniedPermissions);
43			}
44
45			public function assertAccess($userId, $isAllowed, array $permissions)
46			{
47			foreach ($permissions as $permission) {
48			$checked = $this->auth->checkAccess($userId, $permission);
49			if ($checked !== $isAllowed) {
50			var_dump(compact('userId', 'isAllowed', 'permission'));
			0 ignored issues – show Security Debugging Code introduced 2017-08-04 17:20 UTC by Report Bug Copy Issue Report `var_dump(compact('userId...lowed', 'permission'));` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
51			}
52			$this->assertSame($isAllowed, $checked);
			0 ignored issues – show Bug introduced 2017-08-04 17:20 UTC by Report Bug Copy Issue Report It seems like `assertSame()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
53			}
54			}
55
56			public function testUnauthorized()
57			{
58			$this->assertAccesses('', [
59			'restore-password', 'deposit',
60			]);
61			}
62
63			public function testClient()
64			{
65			$this->assertAccesses('role:client', [
66			'restore-password', 'deposit',
67			'domain.pay', 'domain.push', 'server.pay',
68			]);
69			}
70
71			public function testSupport()
72			{
73			$this->assertAccesses('role:support', [
74			'support',
75			]);
76			}
77
78			public function testManager()
79			{
80			$this->assertAccesses('role:manager', [
81			'support', 'manage',
82			'domain.pay', 'domain.push',
83			'server.pay', 'server.sell',
84			'document.manage', 'contact.force-verify',
85			'mailing.prepare', 'mailing.send',
86			]);
87			}
88
89			public function testEmployee()
90			{
91			$this->assertAccesses('role:employee', [
92			'restore-password', 'deposit',
93			'domain.pay', 'domain.push', 'server.pay',
94			'employee.read',
95			]);
96			}
97
98			public function testMighty()
99			{
100			$this->auth->setAssignments('role:admin,role:manager,bill.create,domain.freeze,domain.force-push,domain.delete,employee.read', 'user:mighty');
101
102			$this->assertAccesses('user:mighty', [
103			'support', 'manage', 'admin',
104			'employee.read', 'bill.create',
105			'domain.freeze', 'domain.push', 'domain.force-push', 'domain.delete',
106			'domain.pay', 'server.pay', 'server.sell',
107			'document.manage', 'contact.force-verify',
108			'mailing.prepare', 'mailing.send',
109			]);
110			}
111
112			public function testDeny()
113			{
114			$this->auth->setAssignments('role:client,deny:deposit,deny:domain.push,deny:server.pay', 'user:limited');
115
116			$this->assertAccesses('user:limited', [
117			'restore-password',
118			'domain.pay',
119			]);
120			}
121			}
122

hiqdev / hipanel-rbac

Push — master ( 98ec57...b39146 )

CheckAccessTrait::testDeny() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like