CheckAccessTrait::testClient() - Code Metrics - Inspection of "Added server.sell permission" - hiqdev/hipanel-rbac - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 44a76b...721920 )

by Dmitry

created 2017-07-11 15:33 UTC

CheckAccessTrait::testClient() B

↳ Parent: CheckAccessTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	24
Code Lines	21

Duplication

Lines	24
Ratio	100 %

Importance

Changes	12
Bugs	0	Features	3

Metric	Value
c	12
b	0
f	3
dl	24
loc	24
rs	8.9713
cc	1
eloc	21
nc	1
nop	0

<?php
/**
 * RBAC implementation for HiPanel.
 *
 * @link      https://github.com/hiqdev/hipanel-rbac
 * @package   hipanel-rbac
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016-2017, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\rbac\tests\unit;

trait CheckAccessTrait
{
    public function setAssignments()
    {
        foreach ($this->auth->getAllItems() as $item) {
            $this->auth->setAssignment($item->name, $item->name);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
    }

    public function testClient()

    {
        $this->assertTrue($this->auth->checkAccess('role:client', 'restore-password'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:client', 'deposit'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:client', 'domain.pay'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:client', 'domain.push'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:client', 'server.pay'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->assertFalse($this->auth->checkAccess('role:client', 'support'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'manage'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'employee.read'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'domain.freeze'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'domain.unfreeze'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'domain.force-push'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'domain.delete'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'admin'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'resell'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'own'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'document.manage'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'contact.force-verify'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'mailing.prepare'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'mailing.send'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:client', 'server.sell'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function testSupport()

    {
        $this->assertTrue($this->auth->checkAccess('role:support', 'support'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->assertFalse($this->auth->checkAccess('role:support', 'deposit'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'domain.pay'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'server.pay'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'server.sell'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'restore-password'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'manage'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'employee.read'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'domain.freeze'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'domain.unfreeze'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'domain.force-push'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'domain.delete'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'admin'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'resell'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'own'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'document.manage'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'contact.force-verify'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'mailing.prepare'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:support', 'mailing.send'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function testManager()
    {
        $this->assertTrue($this->auth->checkAccess('role:manager', 'support'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:manager', 'manage'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:manager', 'domain.pay'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:manager', 'server.pay'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:manager', 'server.sell'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:manager', 'document.manage'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:manager', 'contact.force-verify'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:manager', 'mailing.prepare'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:manager', 'mailing.send'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->assertFalse($this->auth->checkAccess('role:manager', 'employee.read'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:manager', 'deposit'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:manager', 'restore-password'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:manager', 'admin'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:manager', 'resell'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:manager', 'own'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:manager', 'domain.freeze'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:manager', 'domain.unfreeze'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:manager', 'domain.force-push'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:manager', 'domain.delete'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:manager', 'bill.create'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:manager', 'bill.update'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:manager', 'bill.delete'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function testEmployee()
    {
        $this->assertTrue($this->auth->checkAccess('role:employee', 'role:client'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('role:employee', 'employee.read'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->assertFalse($this->auth->checkAccess('role:employee', 'role:support'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:employee', 'role:manager'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:employee', 'employee.create'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:employee', 'employee.update'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:employee', 'employee.delete'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('role:employee', 'server.sell'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function testPermission()
    {
        foreach ($this->auth->getPermissions() as $user) {
            foreach ($this->auth->getPermissions() as $perm) {
                $this->assertSame($user->name === $perm->name, $this->auth->checkAccess($user->name, $perm->name));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        }
    }

    public function testMighty()
    {
        $this->auth->setAssignments('role:admin,role:manager,bill.create,domain.freeze,domain.force-push,domain.delete,employee.read', 'user:mighty');

        $this->assertTrue($this->auth->checkAccess('user:mighty', 'support'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'manage'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'employee.read'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'domain.freeze'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'domain.force-push'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'domain.delete'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'admin'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'bill.create'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'domain.pay'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'server.pay'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'document.manage'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'contact.force-verify'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'mailing.prepare'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:mighty', 'mailing.send'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->assertFalse($this->auth->checkAccess('user:mighty', 'deposit'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:mighty', 'restore-password'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:mighty', 'resell'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:mighty', 'own'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:mighty', 'bill.update'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:mighty', 'bill.delete'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:mighty', 'employee.create'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:mighty', 'employee.update'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:mighty', 'employee.delete'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:mighty', 'domain.unfreeze'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function testDeny()

    {
        $this->auth->setAssignments('role:client,deny:deposit,deny:domain.push,deny:server.pay', 'user:limited');

        $this->assertTrue($this->auth->checkAccess('user:limited', 'restore-password'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($this->auth->checkAccess('user:limited', 'domain.pay'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->assertFalse($this->auth->checkAccess('user:limited', 'deposit'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'domain.push'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'server.pay'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->assertFalse($this->auth->checkAccess('user:limited', 'support'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'manage'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'employee.read'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'domain.freeze'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'domain.unfreeze'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'domain.force-push'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'domain.delete'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'admin'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'resell'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'own'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'document.manage'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'contact.force-verify'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'mailing.prepare'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertFalse($this->auth->checkAccess('user:limited', 'mailing.send'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2		/**
3		* RBAC implementation for HiPanel.
4		*
5		* @link https://github.com/hiqdev/hipanel-rbac
6		* @package hipanel-rbac
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2016-2017, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hipanel\rbac\tests\unit;
12
13		trait CheckAccessTrait
14		{
15		public function setAssignments()
16		{
17		foreach ($this->auth->getAllItems() as $item) {
18		$this->auth->setAssignment($item->name, $item->name);
		0 ignored issues – show Bug introduced 2016-11-04 10:47 UTC by Report Bug Copy Issue Report The property `auth` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19		}
20		}
21
22	View Code Duplication	public function testClient()
		0 ignored issues – show Duplication introduced 2016-09-27 14:32 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		$this->assertTrue($this->auth->checkAccess('role:client', 'restore-password'));
		0 ignored issues – show Bug introduced 2016-10-07 09:23 UTC by Report Bug Copy Issue Report It seems like `assertTrue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25		$this->assertTrue($this->auth->checkAccess('role:client', 'deposit'));
		0 ignored issues – show Bug introduced 2016-09-27 14:32 UTC by Report Bug Copy Issue Report It seems like `assertTrue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26		$this->assertTrue($this->auth->checkAccess('role:client', 'domain.pay'));
		0 ignored issues – show Bug introduced 2016-11-11 11:34 UTC by Report Bug Copy Issue Report It seems like `assertTrue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27		$this->assertTrue($this->auth->checkAccess('role:client', 'domain.push'));
		0 ignored issues – show Bug introduced 2016-11-11 11:34 UTC by Report Bug Copy Issue Report It seems like `assertTrue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28		$this->assertTrue($this->auth->checkAccess('role:client', 'server.pay'));
		0 ignored issues – show Bug introduced 2016-11-11 11:34 UTC by Report Bug Copy Issue Report It seems like `assertTrue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29
30		$this->assertFalse($this->auth->checkAccess('role:client', 'support'));
		0 ignored issues – show Bug introduced 2016-09-27 14:32 UTC by Report Bug Copy Issue Report It seems like `assertFalse()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31		$this->assertFalse($this->auth->checkAccess('role:client', 'manage'));
		0 ignored issues – show Bug introduced 2017-02-21 15:45 UTC by Report Bug Copy Issue Report It seems like `assertFalse()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...

hiqdev / hipanel-rbac

Push — master ( 44a76b...721920 )

CheckAccessTrait::testClient() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like