Answer::canSetSpent() - Code Metrics - Inspection of "Fixed Answer update. Added Answer::canSetSpent()" - hiqdev/hipanel-module-ticket - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1b7907...d81d91 )

by Klochok

created 2017-10-30 10:25 UTC

Answer::canSetSpent() A

↳ Parent: Answer

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	0
cts	0
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php
/**
 * HiPanel tickets module
 *
 * @link      https://github.com/hiqdev/hipanel-module-ticket
 * @package   hipanel-module-ticket
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\ticket\models;

use hipanel\models\File;
use Yii;

/**
 * Class Ticket.
 */
class Answer extends \hipanel\base\Model
{
    use \hipanel\base\ModelTrait;

    public static $i18nDictionary = 'hipanel:ticket';

    public static function tableName()
    {
        return 'thread';
    }

    public function init()
    {
        $this->on(static::EVENT_BEFORE_INSERT, [$this, 'beforeChange']);
        $this->on(static::EVENT_BEFORE_UPDATE, [$this, 'beforeChange']);
    }

    public function load($data, $formName = null)
    {
        $result = parent::load($data, $formName);
        $this->prepareSpentTime();

        return $result;
    }

    public function beforeChange($event)

    {
        $this->switchId();

        return true;
    }

    private function switchId()
    {
        if ($this->scenario === 'update') {
            $this->id = $this->answer_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }

    /**
     * @return array
     */
    public function behaviors()

    {
        return [
            [
                'class' => 'hipanel\behaviors\File',
                'attribute' => 'file',
                'targetAttribute' => 'file_ids',
                'scenarios' => ['create', 'answer'],
            ],
        ];
    }

    /**
     * @return array
     */
    public function attributes()
    {
        return [
            'id',
            'answer_id',
            'message',
            'private',
            'is_private',
            'is_answer',
            'changed_num',
            'author',
            'author_id',
            'author_seller',
            'seller_id',
            'account',
            'email_hash',
            'create_time',
            'spent',
            'spent_hours',
            'is_moved',
            'ip',
            'file',
        ];
    }

    /**
     * {@inheritdoc}
     */
    public function rules()
    {
        return [
            [
                ['id', 'answer_id', 'spent', 'spent_hours'],
                'integer',
                'enableClientValidation' => false,
            ],
            [
                ['message', 'id', 'answer_id'],
                'required',
                'on' => 'update',
            ],
            [
                ['spent', '!spent_hours'],
                'safe',
                'on' => 'update',
            ],
            [
                ['is_private'],
                'boolean',
                'on' => 'update',
                'when' => function () {
                    return Yii::$app->user->can('support');
                },
            ],
        ];
    }

    /**
     * {@inheritdoc}
     */
    public function attributeLabels()
    {
        return $this->mergeAttributeLabels([
            'author' => Yii::t('hipanel:ticket', 'Author'),
            'author_id' => Yii::t('hipanel:ticket', 'Author'),
            'recipient' => Yii::t('hipanel:ticket', 'Recipient'),
            'is_private' => Yii::t('hipanel:ticket', 'Make private'),
            'responsible' => Yii::t('hipanel:ticket', 'Assignee'),
            'responsible_id' => Yii::t('hipanel:ticket', 'Assignee'),
            'spent' => Yii::t('hipanel:ticket', 'Spent time'),
            'create_time' => Yii::t('hipanel:ticket', 'Created'),
            'a_reply_time' => Yii::t('hipanel:ticket', 'a_reply_time'),
            'file' => Yii::t('hipanel:ticket', 'Files'),
            'lastanswer' => Yii::t('hipanel:ticket', 'Last answer'),
            'author_seller' => Yii::t('hipanel:ticket', 'Seller'),
        ]);
    }

    public function getClient()
    {
        return $this->author;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getClient_id()
    {
        return $this->author_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getSeller()
    {
        return $this->author_seller;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getSeller_id()
    {
        return $this->author_seller_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function prepareSpentTime()
    {
        list($this->spent_hours, $this->spent) = explode(':', $this->spent, 2);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getThread()
    {
        return $this->hasOne(Thread::class, ['id' => 'id']);
    }

    public function getFiles()
    {
        return $this->hasMany(File::class, ['object_id' => 'id']);
    }

    public function scenarioActions()
    {
        return [
            'update' => 'update-answer',
        ];
    }

    public function canSetSpent()
    {
        return $this->thread->canSetSpent();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1		<?php
2		/**
3		* HiPanel tickets module
4		*
5		* @link https://github.com/hiqdev/hipanel-module-ticket
6		* @package hipanel-module-ticket
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hipanel\modules\ticket\models;
12
13		use hipanel\models\File;
14		use Yii;
15
16		/**
17		* Class Ticket.
18		*/
19		class Answer extends \hipanel\base\Model
20		{
21		use \hipanel\base\ModelTrait;
22
23		public static $i18nDictionary = 'hipanel:ticket';
24
25		public static function tableName()
26		{
27		return 'thread';
28		}
29
30		public function init()
31		{
32		$this->on(static::EVENT_BEFORE_INSERT, [$this, 'beforeChange']);
33		$this->on(static::EVENT_BEFORE_UPDATE, [$this, 'beforeChange']);
34		}
35
36		public function load($data, $formName = null)
37		{
38		$result = parent::load($data, $formName);
39		$this->prepareSpentTime();
40
41		return $result;
42		}
43
44		public function beforeChange($event)
		0 ignored issues – show Unused Code introduced 2017-08-08 17:22 UTC by Report Bug Copy Issue Report The parameter `$event` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
45		{
46		$this->switchId();
47
48		return true;
49		}
50
51		private function switchId()
52		{
53		if ($this->scenario === 'update') {
54		$this->id = $this->answer_id;
		0 ignored issues – show Documentation introduced 2016-06-24 07:57 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<hipanel\modules\ticket\models\Answer>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-06-24 07:57 UTC by Report Bug Copy Issue Report The property `answer_id` does not exist on `object<hipanel\modules\ticket\models\Answer>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
55		}
56		}
57
58		/**
59		* @return array
60		*/
61	View Code Duplication	public function behaviors()
		0 ignored issues – show Duplication introduced 2017-10-04 12:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		{
63		return [
64		[
65		'class' => 'hipanel\behaviors\File',
66		'attribute' => 'file',
67		'targetAttribute' => 'file_ids',
68		'scenarios' => ['create', 'answer'],
69		],
70		];
71		}
72
73		/**
74		* @return array
75		*/
76		public function attributes()
77		{
78		return [
79		'id',
80		'answer_id',
81		'message',
82		'private',
83		'is_private',
84		'is_answer',
85		'changed_num',
86		'author',
87		'author_id',
88		'author_seller',
89		'seller_id',
90		'account',
91		'email_hash',
92		'create_time',
93		'spent',
94		'spent_hours',
95		'is_moved',
96		'ip',
97		'file',
98		];
99		}
100
101		/**
102		* {@inheritdoc}
103		*/
104		public function rules()
105		{
106		return [
107		[
108		['id', 'answer_id', 'spent', 'spent_hours'],
109		'integer',
110		'enableClientValidation' => false,
111		],
112		[
113		['message', 'id', 'answer_id'],
114		'required',
115		'on' => 'update',
116		],
117		[
118		['spent', '!spent_hours'],
119		'safe',
120		'on' => 'update',
121		],
122		[
123		['is_private'],
124		'boolean',
125		'on' => 'update',
126		'when' => function () {
127		return Yii::$app->user->can('support');
128		},
129		],
130		];
131		}
132
133		/**
134		* {@inheritdoc}
135		*/
136		public function attributeLabels()
137		{
138		return $this->mergeAttributeLabels([
139		'author' => Yii::t('hipanel:ticket', 'Author'),
140		'author_id' => Yii::t('hipanel:ticket', 'Author'),
141		'recipient' => Yii::t('hipanel:ticket', 'Recipient'),
142		'is_private' => Yii::t('hipanel:ticket', 'Make private'),
143		'responsible' => Yii::t('hipanel:ticket', 'Assignee'),
144		'responsible_id' => Yii::t('hipanel:ticket', 'Assignee'),
145		'spent' => Yii::t('hipanel:ticket', 'Spent time'),
146		'create_time' => Yii::t('hipanel:ticket', 'Created'),
147		'a_reply_time' => Yii::t('hipanel:ticket', 'a_reply_time'),
148		'file' => Yii::t('hipanel:ticket', 'Files'),
149		'lastanswer' => Yii::t('hipanel:ticket', 'Last answer'),
150		'author_seller' => Yii::t('hipanel:ticket', 'Seller'),
151		]);
152		}
153
154		public function getClient()
155		{
156		return $this->author;
		0 ignored issues – show Documentation introduced 2017-08-08 17:22 UTC by Report Bug Copy Issue Report The property `author` does not exist on `object<hipanel\modules\ticket\models\Answer>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
157		}
158
159		public function getClient_id()
160		{
161		return $this->author_id;
		0 ignored issues – show Documentation introduced 2017-08-08 17:22 UTC by Report Bug Copy Issue Report The property `author_id` does not exist on `object<hipanel\modules\ticket\models\Answer>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
162		}
163
164		public function getSeller()
165		{
166		return $this->author_seller;
		0 ignored issues – show Documentation introduced 2017-08-08 17:22 UTC by Report Bug Copy Issue Report The property `author_seller` does not exist on `object<hipanel\modules\ticket\models\Answer>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
167		}
168
169		public function getSeller_id()
170		{
171		return $this->author_seller_id;
		0 ignored issues – show Documentation introduced 2016-06-24 07:57 UTC by Report Bug Copy Issue Report The property `author_seller_id` does not exist on `object<hipanel\modules\ticket\models\Answer>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
172		}
173
174		public function prepareSpentTime()
175		{
176		list($this->spent_hours, $this->spent) = explode(':', $this->spent, 2);
		0 ignored issues – show Documentation introduced 2016-06-24 07:57 UTC by Report Bug Copy Issue Report The property `spent_hours` does not exist on `object<hipanel\modules\ticket\models\Answer>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-06-24 07:57 UTC by Report Bug Copy Issue Report The property `spent` does not exist on `object<hipanel\modules\ticket\models\Answer>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
177		}
178
179		public function getThread()
180		{
181		return $this->hasOne(Thread::class, ['id' => 'id']);
182		}
183
184		public function getFiles()
185		{
186		return $this->hasMany(File::class, ['object_id' => 'id']);
187		}
188
189		public function scenarioActions()
190		{
191		return [
192		'update' => 'update-answer',
193		];
194		}
195
196		public function canSetSpent()
197		{
198		return $this->thread->canSetSpent();
		0 ignored issues – show Documentation introduced 2017-10-30 10:38 UTC by Report Bug Copy Issue Report The property `thread` does not exist on `object<hipanel\modules\ticket\models\Answer>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
199		}
200		}
201

hiqdev / hipanel-module-ticket

Push — master ( 1b7907...d81d91 )

Answer::canSetSpent() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like