Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class TicketCest |
||
| 12 | { |
||
| 13 | private IndexPage $index; |
||
|
|
|||
| 14 | |||
| 15 | public function _before(Admin $I): void |
||
| 16 | { |
||
| 17 | $this->index = new IndexPage($I); |
||
| 18 | } |
||
| 19 | |||
| 20 | public function ensureIndexPageWorks(Admin $I): void |
||
| 21 | { |
||
| 22 | $I->login(); |
||
| 23 | $I->needPage(Url::to('@ticket')); |
||
| 24 | $I->see('Tickets', 'h1'); |
||
| 25 | $I->seeLink('Create ticket', Url::to('@ticket/create')); |
||
| 26 | $this->ensureICanSeeAdvancedSearchBox($I); |
||
| 27 | $this->ensureICanSeeBulkSearchBox(); |
||
| 28 | } |
||
| 29 | |||
| 30 | private function ensureICanSeeAdvancedSearchBox(Admin $I): void |
||
| 31 | { |
||
| 32 | $this->index->containsFilters([ |
||
| 33 | Input::asAdvancedSearch($I, 'Subject or 1st message'), |
||
| 34 | Input::asAdvancedSearch($I, 'Message'), |
||
| 35 | Input::asAdvancedSearch($I, 'Ticket numbers separated by commas'), |
||
| 36 | Select2::asAdvancedSearch($I, 'Author'), |
||
| 37 | Select2::asAdvancedSearch($I, 'Recipient'), |
||
| 38 | Select2::asAdvancedSearch($I, 'Status'), |
||
| 39 | Select2::asAdvancedSearch($I, 'Assignee'), |
||
| 40 | Select2::asAdvancedSearch($I, 'Priority'), |
||
| 41 | Select2::asAdvancedSearch($I, 'Watchers'), |
||
| 42 | Select2::asAdvancedSearch($I, 'Topics'), |
||
| 43 | ]); |
||
| 44 | } |
||
| 45 | |||
| 46 | private function ensureICanSeeBulkSearchBox(): void |
||
| 47 | { |
||
| 48 | $this->index->containsBulkButtons([ |
||
| 49 | 'Subscribe', |
||
| 50 | 'Unsubscribe', |
||
| 51 | 'Close', |
||
| 52 | ]); |
||
| 53 | $this->index->containsColumns([ |
||
| 54 | 'Subject', |
||
| 55 | 'Author', |
||
| 56 | 'Assignee', |
||
| 57 | 'Recipient', |
||
| 58 | 'Answers', |
||
| 59 | ]); |
||
| 60 | } |
||
| 61 | } |
||
| 62 |