Issues (213)

src/views/server/_form.php (1 issue)

Checks if accessed properties are documented accessible via '__get()'.

Best Practice Bug Major
1
<?php
2
3
use hipanel\helpers\Url;
4
use hipanel\widgets\DynamicFormCopyButton;
5
use hipanel\widgets\DynamicFormWidget;
6
use yii\bootstrap\ActiveForm;
7
use yii\bootstrap\Html;
8
9
/** @var \hipanel\modules\server\forms\ServerForm $model */
10
/** @var \hipanel\modules\server\forms\ServerForm[] $models */
11
$model->ips = is_array($model->ips) ? implode(',', $model->ips) : $model->ips;
12
?>
13
<?php $form = ActiveForm::begin([
14
    'id' => 'server-dynamic-form',
15
    'enableClientValidation' => true,
16
    'validateOnBlur' => true,
17
    'enableAjaxValidation' => true,
18
    'validationUrl' => Url::toRoute(['validate-crud-form', 'scenario' => $model->scenario]),
19
]) ?>
20
21
<?php DynamicFormWidget::begin([
22
    'widgetContainer' => 'dynamicform_wrapper', // required: only alphanumeric characters plus "_" [A-Za-z0-9_]
23
    'widgetBody' => '.container-items', // required: css class selector
24
    'widgetItem' => '.item', // required: css class
25
    'limit' => 99, // the maximum times, an element can be cloned (default 999)
26
    'min' => 1, // 0 or 1 (default 1)
27
    'insertButton' => '.add-item', // css class
28
    'deleteButton' => '.remove-item', // css class
29
    'model' => $model,
30
    'formId' => 'server-dynamic-form',
31
    'formFields' => [
32
        'id',
33
        'server',
34
        'dc',
35
        'type',
36
        'state',
37
        'ips',
38
        'mac',
39
        'order_no',
40
        'label',
41
        'hwsummary',
42
    ],
43
]) ?>
44
45
<div class="container-items">
46
    <?php foreach ($models as $i => $model) : ?>
47
        <div class="item">
48
            <?php if (!$model->isNewRecord) : ?>
49
                <?= Html::activeHiddenInput($model, "[$i]id") ?>
50
            <?php endif; ?>
51
52
            <div class="box box-widget">
53
                <?php if ($model->isNewRecord) : ?>
54
                    <div class="box-header with-border">
55
                        <h3 class="box-title">&nbsp;</h3>
56
                        <div class="box-tools pull-right">
57
                            <div class="btn-group">
58
                                <button type="button" class="add-item btn btn-success btn-sm"><i
59
                                            class="glyphicon glyphicon-plus"></i></button>
60
                                <?= DynamicFormCopyButton::widget() ?>
61
                                <button type="button" class="remove-item btn btn-danger btn-sm"><i
62
                                            class="glyphicon glyphicon-minus"></i></button>
63
                            </div>
64
                        </div>
65
                    </div>
66
                <?php endif; ?>
67
                <div class="box-body">
68
                    <div class="row">
69
                        <div class="col-md-12">
70
                            <div class="row">
71
                                <div class="col-md-3">
72
                                    <?= $form->field($model, "[$i]server") ?>
73
                                </div>
74
                                <div class="col-md-3">
75
                                    <?= $form->field($model, "[$i]dc") ?>
76
                                </div>
77
                                <div class="col-md-1">
78
                                    <?= $form->field($model, "[$i]type")->dropDownList($model->typeOptions, ['prompt' => '--']) ?>
0 ignored issues
show
Bug Best Practice introduced by
The property typeOptions does not exist on hipanel\modules\server\forms\ServerForm. Since you implemented __get, consider adding a @property annotation.
Loading history...
79
                                </div>
80
                                <div class="col-md-3">
81
                                    <?= $form->field($model, "[$i]ips") ?>
82
                                </div>
83
                                <div class="col-md-2">
84
                                    <?= $form->field($model, "[$i]mac") ?>
85
                                </div>
86
                            </div>
87
                        </div>
88
                        <div class="col-md-12">
89
                            <div class="row">
90
                                <div class="col-md-3">
91
                                    <?= $form->field($model, "[$i]order_no") ?>
92
                                </div>
93
                                <div class="col-md-3">
94
                                    <?= $form->field($model, "[$i]label") ?>
95
                                </div>
96
                                <div class="col-md-1">
97
                                    <?= $form->field($model, "[$i]state")->dropDownList($model->getStateOptions()) ?>
98
                                </div>
99
                                <div class="col-md-5">
100
                                    <?= $form->field($model, "[$i]hwsummary") ?>
101
                                </div>
102
                            </div>
103
                        </div>
104
                        <div class="col-md-12">
105
                            <div class="row">
106
                                <div class="col-md-5">
107
                                    <?= $form->field($model, "[$i]hwcomment") ?>
108
                                </div>
109
                            </div>
110
                        </div>
111
                    </div>
112
                </div>
113
            </div>
114
        </div>
115
    <?php endforeach; ?>
116
</div>
117
118
119
<?php DynamicFormWidget::end() ?>
120
121
<div class="row">
122
    <div class="col-md-12 no">
123
        <?= Html::submitButton(Yii::t('hipanel', 'Save'), ['class' => 'btn btn-success']) ?>
124
        &nbsp;
125
        <?= Html::button(Yii::t('hipanel', 'Cancel'), ['class' => 'btn btn-default', 'onclick' => 'history.go(-1)']) ?>
126
    </div>
127
</div>
128
<?php ActiveForm::end() ?>
129