hipanel\modules\server\controllers\OrderController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	75
Duplicated Lines	18.67 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	behaviors()	0	12	1
A	actions()	0	10	1
A	actionOrder()	0	12	1
A	actionIndex()	0	4	1
A	actionXenSsd()	7	7	1
A	actionOpenVz()	7	7	1
A	actionTariffsDetails()	0	4	1
A	actionAdvantages()	0	4	1
A	actionWhatIsVds()	0	4	1

<?php
/**
 * Server module for HiPanel.
 *
 * @link      https://github.com/hiqdev/hipanel-module-server
 * @package   hipanel-module-server
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\server\controllers;

use hipanel\base\CrudController;
use hipanel\modules\finance\models\Tariff;
use hipanel\modules\server\cart\ServerOrderProduct;
use hipanel\modules\server\helpers\ServerHelper;
use hipanel\filters\EasyAccessControl;
use hiqdev\yii2\cart\actions\AddToCartAction;
use Yii;

class OrderController extends CrudController
{
    public function behaviors()
    {
        return array_merge(parent::behaviors(), [
            [
                'class' => EasyAccessControl::class,
                'actions' => [
                    'add-to-cart' => 'server.pay',
                    '*' => 'server.read',
                ],
            ],
        ]);
    }

    public function actions()
    {
        return [
            'add-to-cart' => [
                'class' => AddToCartAction::class,
                'productClass' => ServerOrderProduct::class,
                'redirectToCart' => true,
            ],
        ];
    }

    public function actionOrder($id)
    {
        $package = ServerHelper::getAvailablePackages(null, $id);
        $osImages = ServerHelper::getOsimages($package->tariff->type);

        return $this->render('order', [
            'package' => $package,
            'product' => new ServerOrderProduct(['tariff_id' => $package->tariff->id]),
            'groupedOsimages' => ServerHelper::groupOsimages($osImages),

It seems like $osImages defined by \hipanel\modules\server\helpers\ServerHelper::getOsimages($package->tariff->type) on line 50 can also be of type null; however, hipanel\modules\server\helpers\ServerHelper::groupOsimages() does only seem to accept array<integer,object<hipanel\modules\server\models\Osimage>>, maybe add an additional type check?

            'panels' => ServerHelper::getPanels(),
        ]);
    }

    public function actionIndex()
    {
        return $this->render('index');
    }

    public function actionXenSsd()

This method seems to be duplicated in your project.

    {
        return $this->render('xen_ssd', [
            'packages' => ServerHelper::getAvailablePackages(Tariff::TYPE_XEN),
            'tariffTypes' => Yii::$app->params['vdsproduct'],
        ]);
    }

    public function actionOpenVz()

This method seems to be duplicated in your project.

    {
        return $this->render('open_vz', [
            'packages' => ServerHelper::getAvailablePackages(Tariff::TYPE_OPENVZ),
            'tariffTypes' => Yii::$app->params['vdsproduct'],
        ]);
    }

    public function actionTariffsDetails()
    {
        return $this->render('tariffs_details');
    }

    public function actionAdvantages()
    {
        return $this->render('advantages');
    }

    public function actionWhatIsVds()
    {
        return $this->render('what_is_vds');
    }
}