ServerOrderDedicatedProduct::load() - Code Metrics - Inspection of "Added additional links for ServerOrderDedicatedPro..." - hiqdev/hipanel-module-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e34068...10a872 )

by Klochok

created 2019-10-01 13:40 UTC

ServerOrderDedicatedProduct::load() A

↳ Parent: ServerOrderDedicatedProduct

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
eloc	3
c	1
b	0
f	1
dl	0
loc	7
ccs	0
cts	6
cp	0
rs	10
cc	2
nc	2
nop	2
crap	6

<?php
/**
 * Server module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-server
 * @package   hipanel-module-server
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\server\cart;

use hipanel\modules\server\models\Config;
use hipanel\modules\server\models\Osimage;
use hipanel\modules\server\widgets\cart\OrderPositionDescriptionWidget;
use Yii;
use yii\base\InvalidConfigException;
use yii\helpers\ArrayHelper;
use yii\helpers\Html;

class ServerOrderDedicatedProduct extends AbstractServerProduct
{
    /** {@inheritdoc} */
    protected $_purchaseModel = ServerOrderDedicatedPurchase::class;

    /** @var Config */
    protected $_model;

    /** {@inheritdoc} */
    protected $_calculationModel = ConfigCalculation::class;

    /** {@inheritdoc} */
    protected $duration = [1];

    /**
     * @var Osimage the selected OS image detailed information
     */
    protected $_image;

    /**
     * @var string
     */
    public $location;

    /**
     * @var integer
     */
    public $object_id;

    /**
     * @var integer
     */
    public $tariff_id;

    /**
     * @var string
     */
    public $label;

    /**
     * @var string link to any kind of social network
     */
    public $administration;

    /**
     * @var string osimage name. Is used to load [[_image]] on product initialisation
     */
    public $osimage;

    /**
     * @var string software package name
     */
    public $softpack;

    /** {@inheritdoc} */
    public function load($data, $formName = null)
    {
        if ($result = parent::load($data, '')) {
            $this->ensureRelatedData();
        }

        return $result;
    }

    /** {@inheritdoc} */
    protected function ensureRelatedData()
    {
        $availableConfig = Config::find(['batch' => true])->getAvailable()->withPrices()->withSellerOptions()->andWhere(['id' => $this->object_id])->limit(1)->createCommand()->send()->getData();
        if (empty($availableConfig)) {
            throw new InvalidConfigException('Failed to find config');
        }
        $config = new Config();
        $config->setAttributes(reset($availableConfig));
        $this->_model = $config;

        $this->_image = Osimage::find()->where(['osimage' => $this->osimage, 'type' => 'dedicated'])->one();
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        if ($this->_image === null) {
            throw new InvalidConfigException('Failed to find osimage');
        }
        $this->name = $this->_model->name;
        $this->description = $this->_model->descr;

    }

    /** {@inheritdoc} */
    public function getId()
    {
        if ($this->_id === null) {
            $this->_id = hash('crc32b', implode('_', ['server', 'order', 'dedicated', $this->_model->id, mt_rand()]));

        }

        return $this->_id;
    }

    /** {@inheritdoc} */
    public function getCalculationModel($options = [])
    {
        return parent::getCalculationModel(array_merge([
            'tariff_id' => $this->tariff_id,
            'object_id' => $this->object_id,
            'location' => $this->location,
            'image' => $this->osimage,
        ], $options));
    }

    /** {@inheritdoc} */
    public function getPurchaseModel($options = [])
    {
        $this->ensureRelatedData();

        $options = array_merge([
            'image' => $this->osimage,
            'config_id' => $this->object_id,
            'label' => $this->label,
            'administration' => $this->administration,
            'softpack' => $this->softpack,
            'tariff_id' => $this->tariff_id,
            'location' => $this->location,
        ], $options);

        return parent::getPurchaseModel($options);
    }

    /** {@inheritdoc} */
    public function rules()
    {
        return array_merge(parent::rules(), [
            [['object_id', 'tariff_id'], 'integer'],
            [['administration', 'osimage', 'label', 'location'], 'string'],
            [['tariff_id', 'object_id', 'osimage', 'location'], 'required'],
        ]);
    }

    /** {@inheritdoc} */
    public function attributeLabels()
    {
        return ArrayHelper::merge(parent::attributeLabels(), [
            'object_id' => Yii::t('hipanel:server:order', 'Server config'),
            'label' => Yii::t('hipanel:server:order', 'Label'),
        ]);
    }

    /** {@inheritdoc} */
    public function attributeHints()
    {
        return ArrayHelper::merge(parent::attributeHints(), [
            'label' => Yii::t('hipanel:server:order', 'How are you going to use the server?'),
            'administration' => Yii::t('hipanel:server:order', 'Any social network link. Will be used in case of emergency contact'),
        ]);
    }

    /** {@inheritdoc} */
    public function renderDescription()
    {
        return OrderPositionDescriptionWidget::widget(['position' => $this]);
    }

    /**
     * @return Osimage
     */
    public function getImage()
    {
        return $this->_image;
    }

    protected function serializationMap()
    {
        $parent = parent::serializationMap();
        $parent['object_id'] = $this->object_id;
        $parent['osimage'] = $this->osimage;
        $parent['label'] = $this->label;
        $parent['administration'] = $this->administration;
        $parent['softpack'] = $this->softpack;
        $parent['tariff_id'] = $this->tariff_id;
        $parent['location'] = $this->location;
        $parent['_image'] = $this->_image;

        return $parent;
    }

    public function getDisplayAdministration(): string
    {
        $map = [
            'unmanaged' => Yii::t('hipanel:server:order', 'Basic maintenance'),
            'managed' => Yii::t('hipanel:server:order', 'Expert service 24/7'),
        ];

        return $map[$this->administration] ?? 'unknown state of administration';
    }

    public function getDisplayLocation(): string
    {
        $map = [
            'nl' => Yii::t('hipanel:server:order', 'Netherlands'),
            'us' => Yii::t('hipanel:server:order', 'USA'),
        ];

        return $map[$this->location] ?? 'unknown place';
    }

    public function getAdditionalLinks(): array
    {
        return  ['//beta-hipanel.advancedhosting.com/server/order/dedicated', Yii::t('hipanel:server:order', 'Order another server')];
    }
}


1			<?php
2			/**
3			* Server module for HiPanel
4			*
5			* @link https://github.com/hiqdev/hipanel-module-server
6			* @package hipanel-module-server
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hipanel\modules\server\cart;
12
13			use hipanel\modules\server\models\Config;
14			use hipanel\modules\server\models\Osimage;
15			use hipanel\modules\server\widgets\cart\OrderPositionDescriptionWidget;
16			use Yii;
17			use yii\base\InvalidConfigException;
18			use yii\helpers\ArrayHelper;
19			use yii\helpers\Html;
20
21			class ServerOrderDedicatedProduct extends AbstractServerProduct
22			{
23			/** {@inheritdoc} */
24			protected $_purchaseModel = ServerOrderDedicatedPurchase::class;
25
26			/** @var Config */
27			protected $_model;
28
29			/** {@inheritdoc} */
30			protected $_calculationModel = ConfigCalculation::class;
31
32			/** {@inheritdoc} */
33			protected $duration = [1];
34
35			/**
36			* @var Osimage the selected OS image detailed information
37			*/
38			protected $_image;
39
40			/**
41			* @var string
42			*/
43			public $location;
44
45			/**
46			* @var integer
47			*/
48			public $object_id;
49
50			/**
51			* @var integer
52			*/
53			public $tariff_id;
54
55			/**
56			* @var string
57			*/
58			public $label;
59
60			/**
61			* @var string link to any kind of social network
62			*/
63			public $administration;
64
65			/**
66			* @var string osimage name. Is used to load [[_image]] on product initialisation
67			*/
68			public $osimage;
69
70			/**
71			* @var string software package name
72			*/
73			public $softpack;
74
75			/** {@inheritdoc} */
76			public function load($data, $formName = null)
77			{
78			if ($result = parent::load($data, '')) {
79			$this->ensureRelatedData();
80			}
81
82			return $result;
83			}
84
85			/** {@inheritdoc} */
86			protected function ensureRelatedData()
87			{
88			$availableConfig = Config::find(['batch' => true])->getAvailable()->withPrices()->withSellerOptions()->andWhere(['id' => $this->object_id])->limit(1)->createCommand()->send()->getData();
89			if (empty($availableConfig)) {
90			throw new InvalidConfigException('Failed to find config');
91			}
92			$config = new Config();
93			$config->setAttributes(reset($availableConfig));
94			$this->_model = $config;
95
96			$this->_image = Osimage::find()->where(['osimage' => $this->osimage, 'type' => 'dedicated'])->one();
			0 ignored issues – show Documentation Bug introduced 2019-06-14 15:05 UTC by Report Bug Copy Issue Report It seems like `hipanel\modules\server\m...=> 'dedicated'))->one()` can also be of type `array`. However, the property `$_image` is declared as type `hipanel\modules\server\models\Osimage`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
97			if ($this->_image === null) {
98			throw new InvalidConfigException('Failed to find osimage');
99			}
100			$this->name = $this->_model->name;
101			$this->description = $this->_model->descr;
			0 ignored issues – show Bug Best Practice introduced 2019-10-01 09:58 UTC by Report Bug Copy Issue Report The property `descr` does not exist on `hipanel\modules\server\models\Config`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
102			}
103
104			/** {@inheritdoc} */
105			public function getId()
106			{
107			if ($this->_id === null) {
108			$this->_id = hash('crc32b', implode('_', ['server', 'order', 'dedicated', $this->_model->id, mt_rand()]));
			0 ignored issues – show Bug Best Practice introduced 2019-10-01 09:58 UTC by Report Bug Copy Issue Report The property `id` does not exist on `hipanel\modules\server\models\Config`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
109			}
110
111			return $this->_id;
112			}
113
114			/** {@inheritdoc} */
115			public function getCalculationModel($options = [])
116			{
117			return parent::getCalculationModel(array_merge([
118			'tariff_id' => $this->tariff_id,
119			'object_id' => $this->object_id,
120			'location' => $this->location,
121			'image' => $this->osimage,
122			], $options));
123			}
124
125			/** {@inheritdoc} */
126			public function getPurchaseModel($options = [])
127			{
128			$this->ensureRelatedData();
129
130			$options = array_merge([
131			'image' => $this->osimage,
132			'config_id' => $this->object_id,
133			'label' => $this->label,
134			'administration' => $this->administration,
135			'softpack' => $this->softpack,
136			'tariff_id' => $this->tariff_id,
137			'location' => $this->location,
138			], $options);
139
140			return parent::getPurchaseModel($options);
141			}
142
143			/** {@inheritdoc} */
144			public function rules()
145			{
146			return array_merge(parent::rules(), [
147			[['object_id', 'tariff_id'], 'integer'],
148			[['administration', 'osimage', 'label', 'location'], 'string'],
149			[['tariff_id', 'object_id', 'osimage', 'location'], 'required'],
150			]);
151			}
152
153			/** {@inheritdoc} */
154			public function attributeLabels()
155			{
156			return ArrayHelper::merge(parent::attributeLabels(), [
157			'object_id' => Yii::t('hipanel:server:order', 'Server config'),
158			'label' => Yii::t('hipanel:server:order', 'Label'),
159			]);
160			}
161
162			/** {@inheritdoc} */
163			public function attributeHints()
164			{
165			return ArrayHelper::merge(parent::attributeHints(), [
166			'label' => Yii::t('hipanel:server:order', 'How are you going to use the server?'),
167			'administration' => Yii::t('hipanel:server:order', 'Any social network link. Will be used in case of emergency contact'),
168			]);
169			}
170
171			/** {@inheritdoc} */
172			public function renderDescription()
173			{
174			return OrderPositionDescriptionWidget::widget(['position' => $this]);
175			}
176
177			/**
178			* @return Osimage
179			*/
180			public function getImage()
181			{
182			return $this->_image;
183			}
184
185			protected function serializationMap()
186			{
187			$parent = parent::serializationMap();
188			$parent['object_id'] = $this->object_id;
189			$parent['osimage'] = $this->osimage;
190			$parent['label'] = $this->label;
191			$parent['administration'] = $this->administration;
192			$parent['softpack'] = $this->softpack;
193			$parent['tariff_id'] = $this->tariff_id;
194			$parent['location'] = $this->location;
195			$parent['_image'] = $this->_image;
196
197			return $parent;
198			}
199
200			public function getDisplayAdministration(): string
201			{
202			$map = [
203			'unmanaged' => Yii::t('hipanel:server:order', 'Basic maintenance'),
204			'managed' => Yii::t('hipanel:server:order', 'Expert service 24/7'),
205			];
206
207			return $map[$this->administration] ?? 'unknown state of administration';
208			}
209
210			public function getDisplayLocation(): string
211			{
212			$map = [
213			'nl' => Yii::t('hipanel:server:order', 'Netherlands'),
214			'us' => Yii::t('hipanel:server:order', 'USA'),
215			];
216
217			return $map[$this->location] ?? 'unknown place';
218			}
219
220			public function getAdditionalLinks(): array
221			{
222			return ['//beta-hipanel.advancedhosting.com/server/order/dedicated', Yii::t('hipanel:server:order', 'Order another server')];
223			}
224			}
225

hiqdev / hipanel-module-server

Push — master ( e34068...10a872 )

ServerOrderDedicatedProduct::load() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like