ServerRenewPurchase - Code Metrics - Inspection of "implemented server order class" - hiqdev/hipanel-module-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 441ca2...ee333a )

by Dmitry

created 2016-04-15 15:10 UTC

ServerRenewPurchase A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	21.88 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
wmc	3
c	2
b	0
f	2
lcom	1
cbo	3
dl	7
loc	32
ccs	0
cts	18
cp	0
rs	10

3 Methods

Rating	Name	Duplication	Size	Complexity
A	operation()	0	4	1
A	init()	0	7	1
A	rules()	7	7	1

How to fix Duplicated Code

<?php

/*
 * Server module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-server
 * @package   hipanel-module-server
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\server\cart;

use hipanel\base\ModelTrait;

/**
 * Class ServerRenewPurchase
 *
 * @package hipanel\modules\server\cart
 */
class ServerRenewPurchase extends AbstractServerPurchase
{
    use ModelTrait;

    /** {@inheritdoc} */
    public static function operation()
    {
        return 'Renew';
    }

    /** {@inheritdoc} */
    public function init()
    {
        parent::init();

        $this->server = $this->position->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->amount = $this->position->getQuantity();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * @var string domain expiration datetime
     */
    public $expires;

    public function rules()

    {
        return array_merge(parent::rules(), [
            [['server', 'expires'], 'safe'],
            [['expires', 'amount'], 'required'],
        ]);
    }
}


1		<?php
2
3		/*
4		* Server module for HiPanel
5		*
6		* @link https://github.com/hiqdev/hipanel-module-server
7		* @package hipanel-module-server
8		* @license BSD-3-Clause
9		* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10		*/
11
12		namespace hipanel\modules\server\cart;
13
14		use hipanel\base\ModelTrait;
15
16		/**
17		* Class ServerRenewPurchase
18		*
19		* @package hipanel\modules\server\cart
20		*/
21		class ServerRenewPurchase extends AbstractServerPurchase
22		{
23		use ModelTrait;
24
25		/** {@inheritdoc} */
26		public static function operation()
27		{
28		return 'Renew';
29		}
30
31		/** {@inheritdoc} */
32		public function init()
33		{
34		parent::init();
35
36		$this->server = $this->position->name;
		0 ignored issues – show Documentation introduced 2016-04-15 15:14 UTC by Report Bug Copy Issue Report The property `server` does not exist on `object<hipanel\modules\s...rt\ServerRenewPurchase>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
37		$this->amount = $this->position->getQuantity();
		0 ignored issues – show Documentation introduced 2016-04-15 15:14 UTC by Report Bug Copy Issue Report The property `amount` does not exist on `object<hipanel\modules\s...rt\ServerRenewPurchase>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38		}
39
40		/**
41		* @var string domain expiration datetime
42		*/
43		public $expires;
44
45	View Code Duplication	public function rules()
		0 ignored issues – show Duplication introduced 2016-04-15 15:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		{
47		return array_merge(parent::rules(), [
48		[['server', 'expires'], 'safe'],
49		[['expires', 'amount'], 'required'],
50		]);
51		}
52		}
53

hiqdev / hipanel-module-server

Push — master ( 441ca2...ee333a )

ServerRenewPurchase A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like