VNCFormatter::run() - Code Metrics - Inspection of "fixed broken namespace" - hiqdev/hipanel-module-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0d6829...effd5a )

by Andrii

created 2016-05-19 15:53 UTC

VNCFormatter::run() A

↳ Parent: VNCFormatter

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
c	4
b	0
f	0
dl	0
loc	13
ccs	0
cts	12
cp	0
rs	9.4285
cc	1
eloc	8
nc	1
nop	0
crap	2

<?php

/*
 * Server module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-server
 * @package   hipanel-module-server
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\server\widgets;

use Yii;
use yii\base\Widget;
use yii\db\ActiveRecord;
use yii\helpers\Html;
use yii\web\View;

class VNCFormatter extends Widget
{
    /**
     * @var ActiveRecord
     */
    public $model;

    public function init()
    {
        parent::init();
    }

    public function run()
    {
        $this->getView()->registerJs("$('.discount-popover').popover();", View::POS_READY, 'discount-popover');

        return Html::tag($this->tagName,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            Yii::$app->formatter->asPercent($this->current / 100),
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            [
                'title'        => Yii::t('hipanel/server', 'Next discount'),
                'class'        => 'btn btn-default btn-xs discount-popover',
                'data-trigger' => 'focus',
                'data-content' => Yii::$app->formatter->asPercent($this->next / 100),
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ]);
    }
}


1			<?php
2
3			/*
4			* Server module for HiPanel
5			*
6			* @link https://github.com/hiqdev/hipanel-module-server
7			* @package hipanel-module-server
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hipanel\modules\server\widgets;
13
14			use Yii;
15			use yii\base\Widget;
16			use yii\db\ActiveRecord;
17			use yii\helpers\Html;
18			use yii\web\View;
19
20			class VNCFormatter extends Widget
21			{
22			/**
23			* @var ActiveRecord
24			*/
25			public $model;
26
27			public function init()
28			{
29			parent::init();
30			}
31
32			public function run()
33			{
34			$this->getView()->registerJs("$('.discount-popover').popover();", View::POS_READY, 'discount-popover');
35
36			return Html::tag($this->tagName,
			0 ignored issues – show Documentation introduced 2016-05-19 16:05 UTC by Report Bug Copy Issue Report The property `tagName` does not exist on `object<hipanel\modules\s...r\widgets\VNCFormatter>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
37			Yii::$app->formatter->asPercent($this->current / 100),
			0 ignored issues – show Documentation introduced 2016-05-19 16:05 UTC by Report Bug Copy Issue Report The property `current` does not exist on `object<hipanel\modules\s...r\widgets\VNCFormatter>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38			[
39			'title' => Yii::t('hipanel/server', 'Next discount'),
40			'class' => 'btn btn-default btn-xs discount-popover',
41			'data-trigger' => 'focus',
42			'data-content' => Yii::$app->formatter->asPercent($this->next / 100),
			0 ignored issues – show Documentation introduced 2016-05-19 16:05 UTC by Report Bug Copy Issue Report The property `next` does not exist on `object<hipanel\modules\s...r\widgets\VNCFormatter>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
43			]);
44			}
45			}
46

hiqdev / hipanel-module-server

Push — master ( 0d6829...effd5a )

VNCFormatter::run() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like