PrefixGridView - Code Metrics - Inspection of "Imporved IPAM stuff" - hiqdev/hipanel-module-hosting - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3bd96a...d26825 )

by Klochok

created 2020-09-01 13:54 UTC

PrefixGridView A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	57
Duplicated Lines	5.26 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	3
dl	3
loc	57
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	columns()	3	54	1

How to fix Duplicated Code

<?php
/**
 * Hosting Plugin for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-hosting
 * @package   hipanel-module-hosting
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\hosting\grid;

use hipanel\grid\BoxedGridView;
use hipanel\grid\DataColumn;
use hipanel\grid\RefColumn;
use hipanel\grid\XEditableColumn;
use hipanel\modules\hosting\menus\PrefixActionsMenu;
use hipanel\modules\hosting\models\Prefix;
use hiqdev\yii2\menus\grid\MenuColumn;
use Yii;
use yii\helpers\Html;
use yii\helpers\IpHelper;

class PrefixGridView extends BoxedGridView
{
    public function columns()
    {
        return array_merge(parent::columns(), [
            'ip' => [
                'format' => 'html',
                'value' => static function (Prefix $prefix) {

                    return Html::a($prefix->ip, ['@prefix/view', 'id' => $prefix->id], ['class' => 'text-bold']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                },
            ],
            'type' => [
                'class' => RefColumn::class,
                'i18nDictionary' => 'hipanel.hosting.ipam',
                'format' => 'raw',
                'gtype' => 'type,ip_prefix',
            ],
            'vrf' => [
                'class' => RefColumn::class,
                'i18nDictionary' => 'hipanel.hosting.ipam',
                'format' => 'raw',
                'gtype' => 'type,ip_vrf',
            ],
            'role' => [
                'class' => RefColumn::class,
                'i18nDictionary' => 'hipanel.hosting.ipam',
                'format' => 'raw',
                'gtype' => 'type,ip_prefix_role',
            ],
            'site' => [
                'class' => RefColumn::class,
                'i18nDictionary' => 'hipanel.hosting.ipam',
                'format' => 'raw',
                'gtype' => 'type,location',
            ],
            'family' => [
                'class' => FamilyColumn::class,
            ],
            'utilization' => [
                'class' => UtilizationColumn::class,
            ],
            'note' => [
                'class' => XEditableColumn::class,
                'pluginOptions' => [
                    'url' => 'set-note',
                ],
                'filter' => true,
                'popover' => Yii::t('hipanel', 'Make any notes for your convenience'),
            ],
            'actions' => [
                'class' => MenuColumn::class,
                'contentOptions' => ['style' => 'width: 1%; white-space:nowrap;'],
                'menuClass' => PrefixActionsMenu::class,
            ],
        ]);
    }
}


1		<?php
2		/**
3		* Hosting Plugin for HiPanel
4		*
5		* @link https://github.com/hiqdev/hipanel-module-hosting
6		* @package hipanel-module-hosting
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hipanel\modules\hosting\grid;
12
13		use hipanel\grid\BoxedGridView;
14		use hipanel\grid\DataColumn;
15		use hipanel\grid\RefColumn;
16		use hipanel\grid\XEditableColumn;
17		use hipanel\modules\hosting\menus\PrefixActionsMenu;
18		use hipanel\modules\hosting\models\Prefix;
19		use hiqdev\yii2\menus\grid\MenuColumn;
20		use Yii;
21		use yii\helpers\Html;
22		use yii\helpers\IpHelper;
23
24		class PrefixGridView extends BoxedGridView
25		{
26		public function columns()
27		{
28		return array_merge(parent::columns(), [
29		'ip' => [
30		'format' => 'html',
31	View Code Duplication	'value' => static function (Prefix $prefix) {
		0 ignored issues – show Duplication introduced 2020-09-01 14:07 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		return Html::a($prefix->ip, ['@prefix/view', 'id' => $prefix->id], ['class' => 'text-bold']);
		0 ignored issues – show Documentation introduced 2020-08-20 14:10 UTC by Report Bug Copy Issue Report The property `ip` does not exist on `object<hipanel\modules\hosting\models\Prefix>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2020-08-20 14:10 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<hipanel\modules\hosting\models\Prefix>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
33		},
34		],
35		'type' => [
36		'class' => RefColumn::class,
37		'i18nDictionary' => 'hipanel.hosting.ipam',
38		'format' => 'raw',
39		'gtype' => 'type,ip_prefix',
40		],
41		'vrf' => [
42		'class' => RefColumn::class,
43		'i18nDictionary' => 'hipanel.hosting.ipam',
44		'format' => 'raw',
45		'gtype' => 'type,ip_vrf',
46		],
47		'role' => [
48		'class' => RefColumn::class,
49		'i18nDictionary' => 'hipanel.hosting.ipam',
50		'format' => 'raw',
51		'gtype' => 'type,ip_prefix_role',
52		],
53		'site' => [
54		'class' => RefColumn::class,
55		'i18nDictionary' => 'hipanel.hosting.ipam',
56		'format' => 'raw',
57		'gtype' => 'type,location',
58		],
59		'family' => [
60		'class' => FamilyColumn::class,
61		],
62		'utilization' => [
63		'class' => UtilizationColumn::class,
64		],
65		'note' => [
66		'class' => XEditableColumn::class,
67		'pluginOptions' => [
68		'url' => 'set-note',
69		],
70		'filter' => true,
71		'popover' => Yii::t('hipanel', 'Make any notes for your convenience'),
72		],
73		'actions' => [
74		'class' => MenuColumn::class,
75		'contentOptions' => ['style' => 'width: 1%; white-space:nowrap;'],
76		'menuClass' => PrefixActionsMenu::class,
77		],
78		]);
79		}
80		}
81

hiqdev / hipanel-module-hosting

Push — master ( 3bd96a...d26825 )

PrefixGridView A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like