Request::getObject() - Code Metrics - Inspection of "Merge pull request #24 from tafid/improved_request..." - hiqdev/hipanel-module-hosting - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1bd2dd...5f78b9 )

by Dmitry

created 2019-01-30 17:25 UTC

Request::getObject() A

↳ Parent: Request

Complexity

Conditions	2
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	0
cp	0
rs	10
c	0
b	0
f	0
cc	2
nc	1
nop	0
crap	6

<?php
/**
 * Hosting Plugin for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-hosting
 * @package   hipanel-module-hosting
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

/**
 * @see    http://hiqdev.com/hipanel-module-hosting
 * @license http://hiqdev.com/hipanel-module-hosting/license
 * @copyright Copyright (c) 2015 HiQDev
 */

namespace hipanel\modules\hosting\models;

use Yii;

class Request extends \hipanel\base\Model
{
    use \hipanel\base\ModelTrait;

    /** {@inheritdoc} */
    public function rules()
    {
        return [
            [['id', 'object_id', 'service_id', 'client_id', 'account_id', 'server_id'], 'integer'],
            [['realm', 'service', 'client', 'account', 'server', 'type_ids'], 'safe'],
            [['child', 'parent'], 'string'],
            [['type', 'type_label', 'state', 'state_label', 'action', 'object_class', 'classes', 'class_label'], 'safe'],
            [['parent_id', 'child_id', 'tries_left', 'pid', 'time_lag'], 'integer'],
            [['object_name'], 'safe'],
            [['time', 'create_time', 'update_time'], 'date'],
            [['id'], 'integer', 'on' => ['delete']],
        ];
    }

    /** {@inheritdoc} */
    public function attributeLabels()
    {
        return $this->mergeAttributeLabels([
            'object_name' => Yii::t('hipanel:hosting', 'Object Name'),
            'object' => Yii::t('hipanel:hosting', 'Object'),
            'classes' => Yii::t('hipanel:hosting', 'Object'),
            'type_ids' => Yii::t('hipanel', 'Types'),
            'time' => Yii::t('hipanel:hosting', 'Scheduled time'),
            'pid' => Yii::t('hipanel:hosting', 'PID'),
        ]);
    }

    public function getObject(): string
    {
        return sprintf('%s %s', $this->server, empty($this->object_name) ? $this->class_label : $this->object_name);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2			/**
3			* Hosting Plugin for HiPanel
4			*
5			* @link https://github.com/hiqdev/hipanel-module-hosting
6			* @package hipanel-module-hosting
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			/**
12			* @see http://hiqdev.com/hipanel-module-hosting
13			* @license http://hiqdev.com/hipanel-module-hosting/license
14			* @copyright Copyright (c) 2015 HiQDev
15			*/
16
17			namespace hipanel\modules\hosting\models;
18
19			use Yii;
20
21			class Request extends \hipanel\base\Model
22			{
23			use \hipanel\base\ModelTrait;
24
25			/** {@inheritdoc} */
26			public function rules()
27			{
28			return [
29			[['id', 'object_id', 'service_id', 'client_id', 'account_id', 'server_id'], 'integer'],
30			[['realm', 'service', 'client', 'account', 'server', 'type_ids'], 'safe'],
31			[['child', 'parent'], 'string'],
32			[['type', 'type_label', 'state', 'state_label', 'action', 'object_class', 'classes', 'class_label'], 'safe'],
33			[['parent_id', 'child_id', 'tries_left', 'pid', 'time_lag'], 'integer'],
34			[['object_name'], 'safe'],
35			[['time', 'create_time', 'update_time'], 'date'],
36			[['id'], 'integer', 'on' => ['delete']],
37			];
38			}
39
40			/** {@inheritdoc} */
41			public function attributeLabels()
42			{
43			return $this->mergeAttributeLabels([
44			'object_name' => Yii::t('hipanel:hosting', 'Object Name'),
45			'object' => Yii::t('hipanel:hosting', 'Object'),
46			'classes' => Yii::t('hipanel:hosting', 'Object'),
47			'type_ids' => Yii::t('hipanel', 'Types'),
48			'time' => Yii::t('hipanel:hosting', 'Scheduled time'),
49			'pid' => Yii::t('hipanel:hosting', 'PID'),
50			]);
51			}
52
53			public function getObject(): string
54			{
55			return sprintf('%s %s', $this->server, empty($this->object_name) ? $this->class_label : $this->object_name);
			0 ignored issues – show Documentation introduced 2019-01-29 16:22 UTC by Report Bug Copy Issue Report The property `server` does not exist on `object<hipanel\modules\hosting\models\Request>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2019-01-29 16:22 UTC by Report Bug Copy Issue Report The property `object_name` does not exist on `object<hipanel\modules\hosting\models\Request>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2019-01-29 16:22 UTC by Report Bug Copy Issue Report The property `class_label` does not exist on `object<hipanel\modules\hosting\models\Request>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
56			}
57			}
58

hiqdev / hipanel-module-hosting

Push — master ( 1bd2dd...5f78b9 )

Request::getObject() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like