Link::type() - Code Metrics - Inspection of "changed index/type -> `from` in ActiveRecord" - hiqdev/hipanel-module-hosting - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 94a779...358534 )

by Andrii

created 2017-01-27 15:44 UTC

Link::type() A

↳ Parent: Link::rules()

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php
/**
 * Hosting Plugin for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-hosting
 * @package   hipanel-module-hosting
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\hosting\models;

use yii\web\JsExpression;

class Link extends \hipanel\base\Model
{
    use \hipanel\base\ModelTrait;

    public static function from()
    {
        return 'ip';
    }

    public function rules()
    {
        return [
            [['id', 'ip_id', 'device_id', 'service_id', 'soft_id'], 'integer'],
            [['ip', 'service', 'soft', 'soft_type', 'soft_type_label', 'device_ptype'], 'safe'],
            [['device'], 'safe', 'on' => ['create', 'update']],
            [['service_id', 'ip_id', 'id'], 'integer', 'on' => ['create', 'update']],
            [['id'], 'required', 'on' => ['delete']],
            [['service_id'], 'required', 'when' => function ($model) {

                return !empty($this->server);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }, 'whenClient' => new JsExpression("function (attribute, value) {
                return $(attribute).parent('.item').find('[data-attribute=server]').val();
            }"), 'on' => ['create', 'update']],
        ];
    }
}


1			<?php
2			/**
3			* Hosting Plugin for HiPanel
4			*
5			* @link https://github.com/hiqdev/hipanel-module-hosting
6			* @package hipanel-module-hosting
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hipanel\modules\hosting\models;
12
13			use yii\web\JsExpression;
14
15			class Link extends \hipanel\base\Model
16			{
17			use \hipanel\base\ModelTrait;
18
19			public static function from()
20			{
21			return 'ip';
22			}
23
24			public function rules()
25			{
26			return [
27			[['id', 'ip_id', 'device_id', 'service_id', 'soft_id'], 'integer'],
28			[['ip', 'service', 'soft', 'soft_type', 'soft_type_label', 'device_ptype'], 'safe'],
29			[['device'], 'safe', 'on' => ['create', 'update']],
30			[['service_id', 'ip_id', 'id'], 'integer', 'on' => ['create', 'update']],
31			[['id'], 'required', 'on' => ['delete']],
32			[['service_id'], 'required', 'when' => function ($model) {
			0 ignored issues – show Unused Code introduced 2016-06-24 07:58 UTC by Report Bug Copy Issue Report The parameter `$model` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
33			return !empty($this->server);
			0 ignored issues – show Documentation introduced 2016-06-24 07:58 UTC by Report Bug Copy Issue Report The property `server` does not exist on `object<hipanel\modules\hosting\models\Link>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
34			}, 'whenClient' => new JsExpression("function (attribute, value) {
35			return $(attribute).parent('.item').find('[data-attribute=server]').val();
36			}"), 'on' => ['create', 'update']],
37			];
38			}
39			}
40

hiqdev / hipanel-module-hosting

Push — master ( 94a779...358534 )

Link::type() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like