IpGridView::columns() - Code Metrics - Inspection of "Updated to follow higrid API changes" - hiqdev/hipanel-module-hosting - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9ea30c...5bd098 )

by Dmitry

created 2017-08-08 12:32 UTC

IpGridView::columns() C

↳ Parent: IpGridView

Complexity

Conditions	12
Paths	1

Size

Total Lines	128
Code Lines	87

Duplication

Lines	14
Ratio	10.94 %

Code Coverage

Tests	0
CRAP Score	156

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	14
loc	128
ccs	0
cts	108
cp	0
rs	5.034
cc	12
eloc	87
nc	1
nop	0
crap	156

How to fix Long Method Complexity

<?php
/**
 * Hosting Plugin for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-hosting
 * @package   hipanel-module-hosting
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\hosting\grid;

use hipanel\grid\MainColumn;
use hipanel\helpers\FontIcon;
use hipanel\helpers\Url;
use hipanel\modules\hosting\menus\IpActionsMenu;
use hipanel\modules\hosting\models\HdomainSearch;
use hipanel\modules\hosting\widgets\ip\IpTag;
use hipanel\widgets\ArraySpoiler;
use hipanel\widgets\XEditable;
use hiqdev\yii2\menus\grid\MenuColumn;
use Yii;
use yii\base\InvalidParamException;
use yii\helpers\Html;
use hipanel\grid\XEditableColumn;

class IpGridView extends \hipanel\grid\BoxedGridView
{
    public $controllerUrl = '@ip';

    public $ipTags = [];

    public function columns()
    {
        return array_merge(parent::columns(), [
            'ip' => [
                'class' => MainColumn::class,
                'filterAttribute' => 'ip_like',
            ],
            'note' => [
                'class' => XEditableColumn::class,
                'pluginOptions' => [
                    'url'       => Url::to('set-note'),
                ],
                'widgetOptions' => [
                    'linkOptions' => [
                        'data-type' => 'textarea',
                    ],
                ],
                'visible' => Yii::$app->user->can('admin'),
            ],
            'tags' => [
                'format' => 'raw',
                'attribute' => 'tag',
                'header' => Yii::t('hipanel:hosting', 'Tags'),
                'visible' => Yii::$app->user->can('admin'),
                'filter' => function ($column, $model) {
                    return Html::activeDropDownList($model, 'tag_in', array_merge(['' => Yii::t('hipanel', '---')], $this->ipTags), ['class' => 'form-control']);
                },
                'value' => function ($model) {
                    $labels = [];
                    foreach ($model->tags as $tag) {
                        $labels[] = IpTag::widget(['tag' => $tag]);
                    }
                    return implode(' ', $labels);
                },
            ],
            'counters' => [
                'format' => 'html',
                'header' => Yii::t('hipanel:hosting', 'Counters'),
                'value' => function ($model) {
                    $html = '';
                    foreach ($model->objects_count as $count) {
                        if ($count['type'] === 'hdomain') {
                            $url['ok'] = ['@hdomain', (new HdomainSearch())->formName() => ['ip_like' => $model->ip]];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                            $url['deleted'] = ['@hdomain', (new HdomainSearch())->formName() => ['ip_like' => $model->ip, 'state' => 'deleted']];
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                            $type = function ($count) {
                                return Yii::t('hipanel:hosting', '{0, plural, one{domain} other{domains}}', (int) $count);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                            };
                        } else {
                            throw new InvalidParamException('The object type is not supported', $model);
                        }

                        if ($count['ok']) {

                            $html .= Html::a(
                                (int) $count['ok'] . '&nbsp;' . FontIcon::i('fa-check') . ' ' . $type($count['ok']),
                                $url['ok'],
                                ['class' => 'btn btn-success btn-xs']
                            );
                        }
                        $html .= ' ';
                        if ($count['deleted'] > 0) {

                            $html .= Html::a(
                                (int) $count['deleted'] . '&nbsp;' . FontIcon::i('fa-trash') . ' ' . $type($count['deleted']),
                                $url['deleted'],
                                ['class' => 'btn btn-xs btn-warning']
                            );
                        }
                    }

                    return $html;
                },
            ],
            'links' => [
                'format' => 'html',
                'value' => function ($model) {
                    $items = [];
                    foreach ($model->links as $link) {
                        $item = Html::a($link->device, ['@server/view', 'id' => $link->device_id]);
                        if ($link->service_id) {
                            $item .= '&nbsp;' . FontIcon::i('fa-long-arrow-right');
                            $item .= '&nbsp;' . Html::a($link->service ?: $link->soft, ['@service/view', 'id' => $link->service_id]);
                        }
                        $items[] = $item;
                    }
                    return ArraySpoiler::widget(['data' => $items, 'visibleCount' => 3]);
                },
            ],
            'services' => [
                'attribute' => 'links',
                'format' => 'html',
                'label' => Yii::t('hipanel:server', 'Services'),
                'value' => function ($model) {
                    return ArraySpoiler::widget([
                        'data' => $model->links,
                        'formatter' => function ($link) {
                            if (Yii::$app->user->can('support') && Yii::getAlias('@service', false)) {
                                return Html::a($link->service, ['@service/view', 'id' => $link->service_id]);
                            }

                            return $link->service;
                        },
                    ]);
                },
            ],
            'actions' => [
                'class' => MenuColumn::class,
                'menuClass' => IpActionsMenu::class,
            ],
            'ptr' => [
                'options' => [
                    'style' => 'width: 40%',
                ],
                'format' => 'raw',
                'value' => function ($model) {
                    if ($model->canSetPtr()) {
                        return XEditable::widget([
                            'model' => $model,
                            'attribute' => 'ptr',
                            'pluginOptions' => [
                                'url' => Url::to('@ip/set-ptr'),
                            ],
                        ]);
                    }

                    return null;
                },
            ],
        ]);
    }
}


1		<?php
2		/**
3		* Hosting Plugin for HiPanel
4		*
5		* @link https://github.com/hiqdev/hipanel-module-hosting
6		* @package hipanel-module-hosting
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hipanel\modules\hosting\grid;
12
13		use hipanel\grid\MainColumn;
14		use hipanel\helpers\FontIcon;
15		use hipanel\helpers\Url;
16		use hipanel\modules\hosting\menus\IpActionsMenu;
17		use hipanel\modules\hosting\models\HdomainSearch;
18		use hipanel\modules\hosting\widgets\ip\IpTag;
19		use hipanel\widgets\ArraySpoiler;
20		use hipanel\widgets\XEditable;
21		use hiqdev\yii2\menus\grid\MenuColumn;
22		use Yii;
23		use yii\base\InvalidParamException;
24		use yii\helpers\Html;
25		use hipanel\grid\XEditableColumn;
26
27		class IpGridView extends \hipanel\grid\BoxedGridView
28		{
29		public $controllerUrl = '@ip';
30
31		public $ipTags = [];
32
33		public function columns()
34		{
35		return array_merge(parent::columns(), [
36		'ip' => [
37		'class' => MainColumn::class,
38		'filterAttribute' => 'ip_like',
39		],
40		'note' => [
41		'class' => XEditableColumn::class,
42		'pluginOptions' => [
43		'url' => Url::to('set-note'),
44		],
45		'widgetOptions' => [
46		'linkOptions' => [
47		'data-type' => 'textarea',
48		],
49		],
50		'visible' => Yii::$app->user->can('admin'),
51		],
52		'tags' => [
53		'format' => 'raw',
54		'attribute' => 'tag',
55		'header' => Yii::t('hipanel:hosting', 'Tags'),
56		'visible' => Yii::$app->user->can('admin'),
57		'filter' => function ($column, $model) {
58		return Html::activeDropDownList($model, 'tag_in', array_merge(['' => Yii::t('hipanel', '---')], $this->ipTags), ['class' => 'form-control']);
59		},
60		'value' => function ($model) {
61		$labels = [];
62		foreach ($model->tags as $tag) {
63		$labels[] = IpTag::widget(['tag' => $tag]);
64		}
65		return implode(' ', $labels);
66		},
67		],
68		'counters' => [
69		'format' => 'html',
70		'header' => Yii::t('hipanel:hosting', 'Counters'),
71		'value' => function ($model) {
72		$html = '';
73		foreach ($model->objects_count as $count) {
74		if ($count['type'] === 'hdomain') {
75		$url['ok'] = ['@hdomain', (new HdomainSearch())->formName() => ['ip_like' => $model->ip]];
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-06-24 07:58 UTC by Report Bug Copy Issue Report `$url` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$url = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
76		$url['deleted'] = ['@hdomain', (new HdomainSearch())->formName() => ['ip_like' => $model->ip, 'state' => 'deleted']];
		0 ignored issues – show Bug introduced 2016-06-24 07:58 UTC by Report Bug Copy Issue Report The variable `$url` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
77		$type = function ($count) {
78		return Yii::t('hipanel:hosting', '{0, plural, one{domain} other{domains}}', (int) $count);
		0 ignored issues – show Documentation introduced 2016-06-24 07:58 UTC by Report Bug Copy Issue Report `(int) $count` is of type `integer`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
79		};
80		} else {
81		throw new InvalidParamException('The object type is not supported', $model);
82		}
83
84	View Code Duplication	if ($count['ok']) {
		0 ignored issues – show Duplication introduced 2016-06-24 07:58 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85		$html .= Html::a(
86		(int) $count['ok'] . ' ' . FontIcon::i('fa-check') . ' ' . $type($count['ok']),
87		$url['ok'],
88		['class' => 'btn btn-success btn-xs']
89		);
90		}
91		$html .= ' ';
92	View Code Duplication	if ($count['deleted'] > 0) {
		0 ignored issues – show Duplication introduced 2016-06-24 07:58 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
93		$html .= Html::a(
94		(int) $count['deleted'] . ' ' . FontIcon::i('fa-trash') . ' ' . $type($count['deleted']),
95		$url['deleted'],
96		['class' => 'btn btn-xs btn-warning']
97		);
98		}
99		}
100
101		return $html;
102		},
103		],
104		'links' => [
105		'format' => 'html',
106		'value' => function ($model) {
107		$items = [];
108		foreach ($model->links as $link) {
109		$item = Html::a($link->device, ['@server/view', 'id' => $link->device_id]);
110		if ($link->service_id) {
111		$item .= ' ' . FontIcon::i('fa-long-arrow-right');
112		$item .= ' ' . Html::a($link->service ?: $link->soft, ['@service/view', 'id' => $link->service_id]);
113		}
114		$items[] = $item;
115		}
116		return ArraySpoiler::widget(['data' => $items, 'visibleCount' => 3]);
117		},
118		],
119		'services' => [
120		'attribute' => 'links',
121		'format' => 'html',
122		'label' => Yii::t('hipanel:server', 'Services'),
123		'value' => function ($model) {
124		return ArraySpoiler::widget([
125		'data' => $model->links,
126		'formatter' => function ($link) {
127		if (Yii::$app->user->can('support') && Yii::getAlias('@service', false)) {
128		return Html::a($link->service, ['@service/view', 'id' => $link->service_id]);
129		}
130
131		return $link->service;
132		},
133		]);
134		},
135		],
136		'actions' => [
137		'class' => MenuColumn::class,
138		'menuClass' => IpActionsMenu::class,
139		],
140		'ptr' => [
141		'options' => [
142		'style' => 'width: 40%',
143		],
144		'format' => 'raw',
145		'value' => function ($model) {
146		if ($model->canSetPtr()) {
147		return XEditable::widget([
148		'model' => $model,
149		'attribute' => 'ptr',
150		'pluginOptions' => [
151		'url' => Url::to('@ip/set-ptr'),
152		],
153		]);
154		}
155
156		return null;
157		},
158		],
159		]);
160		}
161		}
162

hiqdev / hipanel-module-hosting

Push — master ( 9ea30c...5bd098 )

IpGridView::columns() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like