ServiceGridView::defaultColumns() - Code Metrics - Inspection of "Updated ServiceGridView to follow API changes" - hiqdev/hipanel-module-hosting - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 210ee5...399696 )

by Dmitry

created 2016-09-12 15:21 UTC

ServiceGridView::defaultColumns() C

↳ Parent: ServiceGridView

Complexity

Conditions	7
Paths	1

Size

Total Lines	92
Code Lines	64

Duplication

Lines	14
Ratio	15.22 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	14
loc	92
c	1
b	0
f	0
ccs	0
cts	82
cp	0
rs	6.4983
cc	7
eloc	64
nc	1
nop	0
crap	56

How to fix Long Method

<?php

/*
 * Hosting Plugin for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-hosting
 * @package   hipanel-module-hosting
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\hosting\grid;

use hipanel\grid\ActionColumn;
use hipanel\grid\MainColumn;
use hipanel\grid\RefColumn;
use hipanel\helpers\FontIcon;
use hipanel\modules\hosting\models\DbSearch;
use hipanel\modules\hosting\models\HdomainSearch;
use hipanel\modules\hosting\models\Soft;
use hipanel\modules\server\grid\ServerColumn;
use hipanel\widgets\ArraySpoiler;
use hipanel\widgets\State;
use Yii;
use yii\helpers\Html;

class ServiceGridView extends \hipanel\grid\BoxedGridView
{
    public static function defaultColumns()
    {
        return [
            'service' => [
                'class' => MainColumn::class,
                'attribute' => 'name',
                'filterAttribute' => 'service_like',
            ],
            'server' => [
                'class' => ServerColumn::class,
            ],
            'object' => [
                'format' => 'raw',
                'header' => Yii::t('hipanel/hosting', 'Object'),
                'value' => function ($model) {
                    $html = $model->name . ' ';

                    if ($model->soft_type === Soft::TYPE_WEB) {
                        $url['ok'] = ['@hdomain', (new HdomainSearch)->formName() => ['server' => $model->server, 'service' => $model->name]];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                        $url['deleted'] = ['@hdomain', (new HdomainSearch)->formName() => ['server' => $model->server, 'service' => $model->name, 'state' => 'deleted']];
                        $type = function ($count) {
                            return Yii::t('hipanel/hosting', '{0, plural, one{domain} other{domains}}', (int)$count);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                        };
                    } elseif ($model->soft_type === Soft::TYPE_DB) {
                        $url['ok'] = ['@db', (new DbSearch)->formName() => ['server' => $model->server, 'service' => $model->name]];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                        $url['deleted'] = ['@db', (new DbSearch)->formName() => ['server' => $model->server, 'service' => $model->name, 'state' => 'deleted']];
                        $type = function ($count) {
                            return Yii::t('hipanel/hosting', '{0, plural, one{# DB} other{# DBs}}', (int)$count);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                        };
                    } else {
                        return $html;
                    }

                    if ($count = $model->objects_count['ok']) {

                        $html .= Html::a(
                            (int)$count . '&nbsp;' . FontIcon::i('fa-check') . ' ' . $type($count),
                            $url['ok'],
                            ['class' => 'btn btn-success btn-xs']
                        );
                    }
                    $html .= ' ';
                    if (($count = $model->objects_count['deleted']) > 0) {

                        $html .= Html::a(
                            (int)$count . '&nbsp;' . FontIcon::i('fa-trash') . ' ' . $type($count),
                            $url['deleted'],
                            ['class' => 'btn btn-xs btn-warning']
                        );
                    }

                    return $html;
                },
            ],
            'ip' => [
                'format' => 'raw',
                'label' => Yii::t('hipanel/hosting', 'IP'),
                'value' => function ($model) {
                    return ArraySpoiler::widget(['data' => array_unique(array_merge((array)$model->ip, (array)$model->ips))]);
                },
            ],
            'bin' => [
                'format' => 'html',
                'value' => function ($model) {
                    return $model->bin ? Html::tag('code', $model->bin) : '';
                }
            ],
            'etc' => [
                'format' => 'html',
                'value' => function ($model) {
                    return $model->etc ? Html::tag('code', $model->etc) : '';
                }
            ],
            'soft' => [
                'value' => function ($model) {
                    return $model->soft;
                }
            ],
            'state' => [
                'class' => RefColumn::class,
                'i18nDictionary' => 'hipanel/hosting',
                'format' => 'raw',
                'value' => function ($model) {
                    return State::widget(compact('model'));
                },
                'gtype' => 'state,service',
            ],
            'actions' => [
                'class' => ActionColumn::class,
                'template' => '{view}',
                'header' => Yii::t('hipanel/hosting', 'Actions'),
            ],
        ];
    }
}


1		<?php
2
3		/*
4		* Hosting Plugin for HiPanel
5		*
6		* @link https://github.com/hiqdev/hipanel-module-hosting
7		* @package hipanel-module-hosting
8		* @license BSD-3-Clause
9		* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10		*/
11
12		namespace hipanel\modules\hosting\grid;
13
14		use hipanel\grid\ActionColumn;
15		use hipanel\grid\MainColumn;
16		use hipanel\grid\RefColumn;
17		use hipanel\helpers\FontIcon;
18		use hipanel\modules\hosting\models\DbSearch;
19		use hipanel\modules\hosting\models\HdomainSearch;
20		use hipanel\modules\hosting\models\Soft;
21		use hipanel\modules\server\grid\ServerColumn;
22		use hipanel\widgets\ArraySpoiler;
23		use hipanel\widgets\State;
24		use Yii;
25		use yii\helpers\Html;
26
27		class ServiceGridView extends \hipanel\grid\BoxedGridView
28		{
29		public static function defaultColumns()
30		{
31		return [
32		'service' => [
33		'class' => MainColumn::class,
34		'attribute' => 'name',
35		'filterAttribute' => 'service_like',
36		],
37		'server' => [
38		'class' => ServerColumn::class,
39		],
40		'object' => [
41		'format' => 'raw',
42		'header' => Yii::t('hipanel/hosting', 'Object'),
43		'value' => function ($model) {
44		$html = $model->name . ' ';
45
46		if ($model->soft_type === Soft::TYPE_WEB) {
47		$url['ok'] = ['@hdomain', (new HdomainSearch)->formName() => ['server' => $model->server, 'service' => $model->name]];
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-09-12 15:29 UTC by Report Bug Copy Issue Report `$url` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$url = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
48		$url['deleted'] = ['@hdomain', (new HdomainSearch)->formName() => ['server' => $model->server, 'service' => $model->name, 'state' => 'deleted']];
49		$type = function ($count) {
50		return Yii::t('hipanel/hosting', '{0, plural, one{domain} other{domains}}', (int)$count);
		0 ignored issues – show Documentation introduced 2016-09-12 15:29 UTC by Report Bug Copy Issue Report `(int) $count` is of type `integer`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
51		};
52		} elseif ($model->soft_type === Soft::TYPE_DB) {
53		$url['ok'] = ['@db', (new DbSearch)->formName() => ['server' => $model->server, 'service' => $model->name]];
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-09-12 15:29 UTC by Report Bug Copy Issue Report `$url` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$url = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
54		$url['deleted'] = ['@db', (new DbSearch)->formName() => ['server' => $model->server, 'service' => $model->name, 'state' => 'deleted']];
55		$type = function ($count) {
56		return Yii::t('hipanel/hosting', '{0, plural, one{# DB} other{# DBs}}', (int)$count);
		0 ignored issues – show Documentation introduced 2016-09-12 15:29 UTC by Report Bug Copy Issue Report `(int) $count` is of type `integer`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
57		};
58		} else {
59		return $html;
60		}
61
62	View Code Duplication	if ($count = $model->objects_count['ok']) {
		0 ignored issues – show Duplication introduced 2016-09-12 15:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		$html .= Html::a(
64		(int)$count . ' ' . FontIcon::i('fa-check') . ' ' . $type($count),
65		$url['ok'],
66		['class' => 'btn btn-success btn-xs']
67		);
68		}
69		$html .= ' ';
70	View Code Duplication	if (($count = $model->objects_count['deleted']) > 0) {
		0 ignored issues – show Duplication introduced 2016-09-12 15:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		$html .= Html::a(
72		(int)$count . ' ' . FontIcon::i('fa-trash') . ' ' . $type($count),
73		$url['deleted'],
74		['class' => 'btn btn-xs btn-warning']
75		);
76		}
77
78		return $html;
79		},
80		],
81		'ip' => [
82		'format' => 'raw',
83		'label' => Yii::t('hipanel/hosting', 'IP'),
84		'value' => function ($model) {
85		return ArraySpoiler::widget(['data' => array_unique(array_merge((array)$model->ip, (array)$model->ips))]);
86		},
87		],
88		'bin' => [
89		'format' => 'html',
90		'value' => function ($model) {
91		return $model->bin ? Html::tag('code', $model->bin) : '';
92		}
93		],
94		'etc' => [
95		'format' => 'html',
96		'value' => function ($model) {
97		return $model->etc ? Html::tag('code', $model->etc) : '';
98		}
99		],
100		'soft' => [
101		'value' => function ($model) {
102		return $model->soft;
103		}
104		],
105		'state' => [
106		'class' => RefColumn::class,
107		'i18nDictionary' => 'hipanel/hosting',
108		'format' => 'raw',
109		'value' => function ($model) {
110		return State::widget(compact('model'));
111		},
112		'gtype' => 'state,service',
113		],
114		'actions' => [
115		'class' => ActionColumn::class,
116		'template' => '{view}',
117		'header' => Yii::t('hipanel/hosting', 'Actions'),
118		],
119		];
120		}
121		}
122

hiqdev / hipanel-module-hosting

Push — master ( 210ee5...399696 )

ServiceGridView::defaultColumns() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like