Issues in Calculation.php (master) - Issues in master - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Issues (434)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/models/Calculation.php (4 issues)

Labels

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\models;

use Yii;
use yii\base\InvalidParamException;

/**
 * Class Calculation.
 *
 *
 * @property-read Value[] value
 * @property-read Value[] valueConverted
 */
class Calculation extends \hipanel\base\Model
{
    use \hipanel\base\ModelTrait;

    /** {@inheritdoc} */
    public static function tableName()
    {
        return 'action';
    }

    /** {@inheritdoc} */
    public function init()
    {
        if (!isset($this->seller)) {
            if (Yii::$app->user->getIsGuest()) {
                $this->seller = Yii::$app->params['user.seller'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            } else {
                $this->seller = Yii::$app->user->identity->seller;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
        }

        if (!isset($this->client) && !Yii::$app->user->getIsGuest()) {
            $this->client = Yii::$app->user->identity->username;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        $this->synchronize();
    }

    public function getValue()
    {
        // ['tariff_id' => 'currency'] is a dumb relation condition and does not make any sense
        return $this->hasMany(Value::class, ['tariff_id' => 'currency'])->indexBy('currency');
    }

    public function getValueConverted()
    {
        // ['tariff_id' => 'currency'] is a dumb relation condition and does not make any sense
        return $this->hasMany(Value::class, ['tariff_id' => 'currency'])->indexBy('currency');
    }

    /**
     * @param string $currency
     *
     * @throws InvalidParamException when the $currency is not calculated
     * @return Value
     */
    public function forCurrency($currency)
    {
        if (isset($this->value[$currency])) {
            return $this->value[$currency];
        }
        if (!empty($this->value)) {
            return reset($this->value);

        }
        Yii::warning('Value for currency $currency was not found. Using fake free value. Most probably, tariff is free', __METHOD__);

        return new Value(['value' => 0, 'price' => 0, 'currency' => $currency]);
    }

    /** {@inheritdoc} */
    public function rules()
    {
        return [
            [['object', 'seller', 'client', 'type', 'currency', 'item'], 'safe'],
            [['amount'], 'number'],
            [['tariff_id', 'calculation_id'], 'integer'],
        ];
    }

    /**
     * Synchronises the model to represent actual state of [[position]]
     * The method must update values, that affects the calculation and
     * can be changed in cart without position re-adding.
     * For example: quantity.
     */
    public function synchronize()
    {
        return true;
    }
}


1			<?php
2			/**
3			* Finance module for HiPanel
4			*
5			* @link https://github.com/hiqdev/hipanel-module-finance
6			* @package hipanel-module-finance
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hipanel\modules\finance\models;
12
13			use Yii;
14			use yii\base\InvalidParamException;
15
16			/**
17			* Class Calculation.
18			*
19			*
20			* @property-read Value[] value
21			* @property-read Value[] valueConverted
22			*/
23			class Calculation extends \hipanel\base\Model
24			{
25			use \hipanel\base\ModelTrait;
26
27			/** {@inheritdoc} */
28			public static function tableName()
29			{
30			return 'action';
31			}
32
33			/** {@inheritdoc} */
34			public function init()
35			{
36			if (!isset($this->seller)) {
37			if (Yii::$app->user->getIsGuest()) {
38			$this->seller = Yii::$app->params['user.seller'];
			0 ignored issues – show Documentation introduced 2016-06-24 07:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `seller` does not exist on `object<hipanel\modules\f...nce\models\Calculation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
39			} else {
40			$this->seller = Yii::$app->user->identity->seller;
			0 ignored issues – show Documentation introduced 2016-09-20 12:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `seller` does not exist on `object<hipanel\modules\f...nce\models\Calculation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
41			}
42			}
43
44			if (!isset($this->client) && !Yii::$app->user->getIsGuest()) {
45			$this->client = Yii::$app->user->identity->username;
			0 ignored issues – show Documentation introduced 2016-06-24 07:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `client` does not exist on `object<hipanel\modules\f...nce\models\Calculation>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46			}
47
48			$this->synchronize();
49			}
50
51			public function getValue()
52			{
53			// ['tariff_id' => 'currency'] is a dumb relation condition and does not make any sense
54			return $this->hasMany(Value::class, ['tariff_id' => 'currency'])->indexBy('currency');
55			}
56
57			public function getValueConverted()
58			{
59			// ['tariff_id' => 'currency'] is a dumb relation condition and does not make any sense
60			return $this->hasMany(Value::class, ['tariff_id' => 'currency'])->indexBy('currency');
61			}
62
63			/**
64			* @param string $currency
65			*
66			* @throws InvalidParamException when the $currency is not calculated
67			* @return Value
68			*/
69			public function forCurrency($currency)
70			{
71			if (isset($this->value[$currency])) {
72			return $this->value[$currency];
73			}
74			if (!empty($this->value)) {
75			return reset($this->value);
			0 ignored issues – show Comprehensibility Best Practice introduced 2019-10-04 16:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `reset($this->value);` of type `hipanel\modules\finance\models\Value\|false` adds `false` to the return on line 75 which is incompatible with the return type documented by `hipanel\modules\finance\...alculation::forCurrency` of type `hipanel\modules\finance\models\Value`. It seems like you forgot to handle an error condition. Loading history...
76			}
77			Yii::warning('Value for currency $currency was not found. Using fake free value. Most probably, tariff is free', __METHOD__);
78
79			return new Value(['value' => 0, 'price' => 0, 'currency' => $currency]);
80			}
81
82			/** {@inheritdoc} */
83			public function rules()
84			{
85			return [
86			[['object', 'seller', 'client', 'type', 'currency', 'item'], 'safe'],
87			[['amount'], 'number'],
88			[['tariff_id', 'calculation_id'], 'integer'],
89			];
90			}
91
92			/**
93			* Synchronises the model to represent actual state of [[position]]
94			* The method must update values, that affects the calculation and
95			* can be changed in cart without position re-adding.
96			* For example: quantity.
97			*/
98			public function synchronize()
99			{
100			return true;
101			}
102			}
103

hiqdev / hipanel-module-finance

Issues (434)

Security Analysis not enabled

src/models/Calculation.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like