Issues (462)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/grid/TariffProfileGridView.php (4 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * Finance module for HiPanel
4
 *
5
 * @link      https://github.com/hiqdev/hipanel-module-finance
6
 * @package   hipanel-module-finance
7
 * @license   BSD-3-Clause
8
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace hipanel\modules\finance\grid;
12
13
use hipanel\grid\BoxedGridView;
14
use hipanel\modules\finance\menus\ProfileActionsMenu;
15
use hipanel\modules\finance\models\Tariff;
16
use hipanel\modules\finance\models\TariffProfile;
17
use hiqdev\yii2\menus\grid\MenuColumn;
18
use Yii;
19
use yii\helpers\Html;
20
21
class TariffProfileGridView extends BoxedGridView
22
{
23
    public function columns()
24
    {
25
        return array_merge(parent::columns(), [
26
            'name' => [
27
                'class' => 'hipanel\grid\MainColumn',
28
                'filterAttribute' => 'name_like',
29
                'note' => null,
30
                'value' => function (TariffProfile $model) {
31
                    if (empty($model->name) || $model->isDefault()) {
32
                        return Yii::t('hipanel.finance.tariffprofile', 'Default');
33
                    }
34
35
                    return $model->name;
36
                },
37
            ],
38
            'tariff_names' => [
39
                'filter' => false,
40
                'format' => 'raw',
41
                'value' => function (TariffProfile $model) {
42
                    if (empty($model->tariffs)) {
43
                        return '';
44
                    }
45
46
                    foreach ($model->tariffs as $type => $values) {
47
                        if (empty($values)) {
48
                            continue;
49
                        }
50
51
                        $links = [];
52
                        foreach ($values as $id => $name) {
53
                            $links[$id] = $this->tariffLink($id, $name);
54
                        }
55
                        $tariffs[$type] = $model->getAttributeLabel($type) . ': ' . implode(', ', $links);
56
                    }
57
58
                    return implode('<br>', $tariffs);
0 ignored issues
show
The variable $tariffs does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
59
                },
60
            ],
61
            'domain_tariff' => [
62
                'attribute' => 'domain',
63
                'format' => 'raw',
64 View Code Duplication
                'value' => function (TariffProfile $model) {
65
                    if (empty($model->domain)) {
66
                        return '';
67
                    }
68
69
                    return $this->tariffLink($model->domain, $model->tariff_names[$model->domain]);
70
                },
71
            ],
72
            'certificate_tariff' => [
73
                'attribute' => 'certificate',
74
                'format' => 'raw',
75 View Code Duplication
                'value' => function (TariffProfile $model) {
76
                    if (empty($model->certificate)) {
77
                        return '';
78
                    }
79
80
                    return $this->tariffLink($model->certificate, $model->tariff_names[$model->certificate]);
81
                },
82
            ],
83
            'svds_tariff' => [
84
                'attribute' => 'svds',
85
                'format' => 'raw',
86 View Code Duplication
                'value' => function (TariffProfile $model) {
87
                    if (empty($model->tariffs)) {
88
                        return '';
89
                    }
90
91
                    if (empty($model->tariffs[Tariff::TYPE_XEN])) {
92
                        return '';
93
                    }
94
95
                    foreach ($model->tariffs[Tariff::TYPE_XEN] as $id => $name) {
96
                        $links[$id] = $this->tariffLink($id, $name);
97
                    }
98
99
                    return implode(', ', $links);
0 ignored issues
show
The variable $links does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
100
                },
101
            ],
102
            'ovds_tariff' => [
103
                'attribute' => 'ovds',
104
                'format' => 'raw',
105 View Code Duplication
                'value' => function (TariffProfile $model) {
106
                    if (empty($model->tariffs)) {
107
                        return '';
108
                    }
109
110
                    if (empty($model->tariffs[Tariff::TYPE_OPENVZ])) {
111
                        return '';
112
                    }
113
114
                    foreach ($model->tariffs[Tariff::TYPE_OPENVZ] as $id => $name) {
115
                        $links[$id] = $this->tariffLink($id, $name);
116
                    }
117
118
                    return implode(', ', $links);
0 ignored issues
show
The variable $links does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
119
                },
120
            ],
121
            'server_tariff' => [
122
                'attribute' => 'server',
123
                'format' => 'raw',
124 View Code Duplication
                'value' => function (TariffProfile $model) {
125
                    if (empty($model->tariffs)) {
126
                        return '';
127
                    }
128
129
                    if (empty($model->tariffs[Tariff::TYPE_SERVER])) {
130
                        return '';
131
                    }
132
133
                    foreach ($model->tariffs[Tariff::TYPE_SERVER] as $id => $name) {
134
                        $links[$id] = $this->tariffLink($id, $name);
135
                    }
136
137
                    return implode(', ', $links);
0 ignored issues
show
The variable $links does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
138
                },
139
            ],
140
            'actions' => [
141
                'class' => MenuColumn::class,
142
                'menuClass' => ProfileActionsMenu::class,
143
            ],
144
        ]);
145
    }
146
147
    protected function tariffLink($id, $name)
148
    {
149
        return Html::a($name, ['@plan/view', 'id' => $id]);
150
    }
151
}
152