VdsTariffManager::insert() - Code Metrics - Inspection of "Implementing VDS tariff creating" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0622f1...018a2f )

by Dmitry

created 2016-09-06 16:33 UTC

VdsTariffManager::insert() A

↳ Parent: VdsTariffManager

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	14
ccs	0
cts	11
cp	0
rs	9.4285
cc	2
eloc	8
nc	2
nop	0
crap	6

<?php

namespace hipanel\modules\finance\logic;

use hipanel\modules\finance\forms\DomainTariffForm;
use hipanel\modules\finance\forms\VdsTariffForm;
use hipanel\modules\finance\models\Tariff;
use hiqdev\hiart\ErrorResponseException;
use Yii;
use yii\web\NotFoundHttpException;
use yii\web\UnprocessableEntityHttpException;

class VdsTariffManager extends AbstractTariffManager
{
    /**
     * @var VdsTariffForm
     */
    public $form;

    /**
     * @inheritdoc
     */
    protected $type = 'server';

    public function init()
    {
        if (!Yii::getAlias('@server', true)) {
            throw new NotFoundHttpException('Domain module is missing');
        }

        parent::init();
    }

    public function insert()
    {
        $data = $this->form->toArray();

        try {
            $result = Tariff::perform('Create', $data);
        } catch (ErrorResponseException $e) {
            throw new UnprocessableEntityHttpException($e->getMessage(), 0, $e);
        }

        $this->form->id = $result['id'];

        return true;
    }

    public function update()
    {
        $data = $this->form->toArray();

        try {
            $result = Tariff::perform('Update', $data);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (ErrorResponseException $e) {
            throw new UnprocessableEntityHttpException($e->getMessage(), 0, $e);
        }

        return true;
    }
}


1			<?php
2
3			namespace hipanel\modules\finance\logic;
4
5			use hipanel\modules\finance\forms\DomainTariffForm;
6			use hipanel\modules\finance\forms\VdsTariffForm;
7			use hipanel\modules\finance\models\Tariff;
8			use hiqdev\hiart\ErrorResponseException;
9			use Yii;
10			use yii\web\NotFoundHttpException;
11			use yii\web\UnprocessableEntityHttpException;
12
13			class VdsTariffManager extends AbstractTariffManager
14			{
15			/**
16			* @var VdsTariffForm
17			*/
18			public $form;
19
20			/**
21			* @inheritdoc
22			*/
23			protected $type = 'server';
24
25			public function init()
26			{
27			if (!Yii::getAlias('@server', true)) {
28			throw new NotFoundHttpException('Domain module is missing');
29			}
30
31			parent::init();
32			}
33
34			public function insert()
35			{
36			$data = $this->form->toArray();
37
38			try {
39			$result = Tariff::perform('Create', $data);
40			} catch (ErrorResponseException $e) {
41			throw new UnprocessableEntityHttpException($e->getMessage(), 0, $e);
42			}
43
44			$this->form->id = $result['id'];
45
46			return true;
47			}
48
49			public function update()
50			{
51			$data = $this->form->toArray();
52
53			try {
54			$result = Tariff::perform('Update', $data);
			0 ignored issues – show Unused Code introduced 2016-08-26 16:35 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
55			} catch (ErrorResponseException $e) {
56			throw new UnprocessableEntityHttpException($e->getMessage(), 0, $e);
57			}
58
59			return true;
60			}
61			}
62

hiqdev / hipanel-module-finance

Push — master ( 0622f1...018a2f )

VdsTariffManager::insert() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like