hipanel\modules\finance\forms\VdsTariffForm

Complexity

Total Complexity

16

Size/Duplication

Total Lines	117
Duplicated Lines	38.46 %

Coupling/Cohesion

Components	3
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes	5
Bugs	0	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	load()	0	7	1
A	rules()	0	7	1
A	getHardwareResources()	11	11	1
A	sortResourcesByDefinedOrder()	0	13	3
A	getOveruseResources()	12	12	1
A	getBaseOveruseResource()	0	7	2
A	getBaseHardwareResource()	0	7	2
B	setResources()	22	22	5

<?php

namespace hipanel\modules\finance\forms;

use hipanel\helpers\ArrayHelper;
use hipanel\modules\finance\models\ServerResource;
use yii\web\UnprocessableEntityHttpException;

class VdsTariffForm extends AbstractTariffForm
{
    public $note;
    public $label;

    public function load($data)
    {
        $this->setAttributes($data[$this->formName()]);
        $this->setResources($data[(new ServerResource())->formName()]);

        return true;
    }

    public function rules()
    {
        $rules = parent::rules();
        $rules[] = [['note', 'label'], 'safe', 'on' => ['create', 'update']];

        return $rules;
    }

    /**
     * @return \hipanel\modules\finance\models\ServerResource[]
     */
    public function getHardwareResources()

This method seems to be duplicated in your project.

    {
        /** @var ServerResource[] $resources */
        $resources = array_filter($this->tariff->resources, function ($model) {
            /** @var ServerResource $model */
            return $model->isHardwareTypeCorrect();
        });
        $order = array_keys(reset($resources)->getHardwareTypes());

        return $this->sortResourcesByDefinedOrder($resources, $order, 'model_type');
    }

    /**
     * @param ServerResource[] $resources
     * @param array $order array of ordered values. $resources array will be re-ordered according this order
     * @param string $key the key that will be used to re-order
     * @return array
     */
    private function sortResourcesByDefinedOrder($resources, $order, $key)
    {
        $result = [];
        $resources = ArrayHelper::index($resources, $key);

        foreach ($order as $type) {
            if (isset($resources[$type])) {
                $result[] = $resources[$type];
            }
        }

        return $result;
    }



    /**
     * @return \hipanel\modules\finance\models\ServerResource[]
     */
    public function getOveruseResources()

This method seems to be duplicated in your project.

    {
        /** @var ServerResource[] $resources */
        $resources = array_filter($this->tariff->resources, function ($model) {
            /** @var ServerResource $model */
            return $model->isTypeCorrect();
        });
        $order = array_keys(reset($resources)->getTypes());

        return $this->sortResourcesByDefinedOrder($resources, $order, 'type');

    }

    public function getBaseOveruseResource($type_id)
    {
        return reset(array_filter($this->baseTariff->resources, function ($resource) use ($type_id) {

array_filter($this->baseTariff->resources, function ($resource) use($type_id) { return $resource->type_id == $type_id && $resource->isTypeCorrect(); }) cannot be passed to reset() as the parameter $array expects a reference.

            /** @var ServerResource $resource */
            return $resource->type_id == $type_id && $resource->isTypeCorrect();

The property type_id does not exist on object<hipanel\modules\finance\models\ServerResource>. Since you implemented __get, maybe consider adding a @property annotation.

        }));
    }

    /**
     * @return \hipanel\modules\finance\models\ServerResource[]
     */
    public function getBaseHardwareResource($object_id)
    {
        return reset(array_filter($this->baseTariff->resources, function ($resource) use ($object_id) {

array_filter($this->baseTariff->resources, function ($resource) use($object_id) { return $resource->object_id == $object_id && $resource->isHardwareTypeCorrect(); }) cannot be passed to reset() as the parameter $array expects a reference.

            /** @var ServerResource $resource */
            return $resource->object_id == $object_id && $resource->isHardwareTypeCorrect();

The property object_id does not exist on object<hipanel\modules\finance\models\ServerResource>. Since you implemented __get, maybe consider adding a @property annotation.

        }));
    }

    /** @inheritdoc */
    public function setResources($resources)

This method seems to be duplicated in your project.

    {
        $result = [];
        foreach ((array) $resources as $resource) {
            if ($resource instanceof ServerResource) {
                $result[] = $resource;
                continue;
            }

            $model = new ServerResource(['scenario' => $this->scenario]);

            if ($model->load($resource, '') && $model->validate()) {
                $result[] = $model;
            } else {
                throw new UnprocessableEntityHttpException('Failed to load resource model: ' . reset($model->getFirstErrors()));

$model->getFirstErrors() cannot be passed to reset() as the parameter $array expects a reference.

            }
        }

        $this->_resources = $result;

        return $this;
    }
}