Completed
Push — master ( 4bde9c...94e19b )
by Andrii
04:39
created

PlanQuery   A

Complexity

Total Complexity 5

Size/Duplication

Total Lines 49
Duplicated Lines 44.9 %

Coupling/Cohesion

Components 0
Dependencies 1

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
wmc 5
lcom 0
cbo 1
dl 22
loc 49
ccs 0
cts 32
cp 0
rs 10
c 0
b 0
f 0

5 Methods

Rating   Name   Duplication   Size   Complexity  
A byId() 0 4 1
A one() 0 4 1
A all() 0 4 1
A withPrices() 11 11 1
A joinWithPrices() 11 11 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * Finance module for HiPanel
4
 *
5
 * @link      https://github.com/hiqdev/hipanel-module-finance
6
 * @package   hipanel-module-finance
7
 * @license   BSD-3-Clause
8
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace hipanel\modules\finance\models\query;
12
13
use hipanel\modules\finance\models\Plan;
14
use hiqdev\hiart\ActiveQuery;
15
16
class PlanQuery extends \hiqdev\hiart\ActiveQuery
17
{
18
    public function byId($id)
19
    {
20
        return $this->andWhere(['id' => $id]);
21
    }
22
23
    /**
24
     * @param null $db
25
     * @return Plan|null
26
     */
27
    public function one($db = null)
28
    {
29
        return parent::one($db);
0 ignored issues
show
Bug Compatibility introduced by
The expression parent::one($db); of type hiqdev\hiart\ActiveRecord|array|null adds the type hiqdev\hiart\ActiveRecord to the return on line 29 which is incompatible with the return type declared by the interface yii\db\QueryInterface::one of type array|boolean.
Loading history...
30
    }
31
32
    /**
33
     * @param null $db
34
     * @return Plan[]
35
     */
36
    public function all($db = null)
37
    {
38
        return parent::all($db);
39
    }
40
41 View Code Duplication
    public function withPrices()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
42
    {
43
        return $this->with([
44
            'prices' => function (ActiveQuery $query) {
45
                $query
46
                    ->addSelect('main_object_id')
47
                    ->joinWith('object')
48
                    ->limit(-1);
49
            },
50
        ]);
51
    }
52
53 View Code Duplication
    public function joinWithPrices()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
54
    {
55
        return $this->joinWith([
56
            'prices' => function (ActiveQuery $query) {
57
                $query
58
                    ->addSelect('main_object_id')
59
                    ->joinWith('object')
60
                    ->limit(-1);
61
            },
62
        ]);
63
    }
64
}
65