Tariff::rules() - Code Metrics - Inspection of "Added OVDS views" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b87a46...8351d4 )

by Dmitry

created 2016-09-08 16:26 UTC

Tariff::rules() A

↳ Parent: Tariff

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	4
Bugs	0	Features	2

Metric	Value
c	4
b	0
f	2
dl	0
loc	15
rs	9.4285
ccs	0
cts	15
cp	0
cc	1
eloc	12
nc	1
nop	0
crap	2

<?php

/*
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\models;

use hipanel\modules\finance\models\query\TariffQuery;

/**
 * Class Tariff
 * @package hipanel\modules\finance\models
 * @property Resource[]|DomainResource[]|ServerResource[] $resources
 */
class Tariff extends \hipanel\base\Model
{
    use \hipanel\base\ModelTrait;

    const TYPE_DOMAIN = 'domain';
    const TYPE_SVDS = 'svds';
    const TYPE_OVDS = 'ovds';

    /**
     * {@inheritdoc}
     */
    public function rules()
    {
        return [
            [['client_id', 'seller_id', 'id', 'parent_id'], 'integer'],
            [['client', 'seller', 'bill', 'name'], 'safe'],
            [['domain', 'server'], 'safe'],
            [['tariff', 'tariff_id'], 'safe'],
            [['type_id', 'state_id'], 'integer'],
            [['type', 'state'], 'safe'],
            [['used'], 'integer'],
            [['note', 'label'], 'safe'],
            [['is_personal'], 'boolean'],
            [['id'], 'required', 'on' => ['delete']],
        ];
    }

    public function getResources()
    {
        if ($this->type === self::TYPE_DOMAIN) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return $this->hasMany(DomainResource::class, ['tariff_id' => 'id'])->inverseOf('tariff');
        } elseif ($this->type === self::TYPE_SVDS || $this->type === self::TYPE_OVDS) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return $this->hasMany(ServerResource::class, ['tariff_id' => 'id'])->inverseOf('tariff');
        }

        return $this->hasMany(Resource::class, ['tariff_id' => 'id'])->inverseOf('tariff');
    }

    /**
     * @param $type
     * @return DomainResource|ServerResource|Resource
     */
    public function getResourceByType($type)
    {
        foreach ($this->resources as $resource) {
            if ($resource->type === $type) {
                return $resource;
            }
        }

        return null;
    }

    /**
     * {@inheritdoc}
     */
    public function attributeLabels()
    {
        return $this->mergeAttributeLabels([
        ]);
    }

    /**
     * {@inheritdoc}
     * @return TariffQuery
     */
    public static function find($options = [])
    {
        return new TariffQuery(get_called_class(), [
            'options' => $options,
        ]);
    }
}


1			<?php
2
3			/*
4			* Finance module for HiPanel
5			*
6			* @link https://github.com/hiqdev/hipanel-module-finance
7			* @package hipanel-module-finance
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hipanel\modules\finance\models;
13
14			use hipanel\modules\finance\models\query\TariffQuery;
15
16			/**
17			* Class Tariff
18			* @package hipanel\modules\finance\models
19			* @property Resource[]\|DomainResource[]\|ServerResource[] $resources
20			*/
21			class Tariff extends \hipanel\base\Model
22			{
23			use \hipanel\base\ModelTrait;
24
25			const TYPE_DOMAIN = 'domain';
26			const TYPE_SVDS = 'svds';
27			const TYPE_OVDS = 'ovds';
28
29			/**
30			* {@inheritdoc}
31			*/
32			public function rules()
33			{
34			return [
35			[['client_id', 'seller_id', 'id', 'parent_id'], 'integer'],
36			[['client', 'seller', 'bill', 'name'], 'safe'],
37			[['domain', 'server'], 'safe'],
38			[['tariff', 'tariff_id'], 'safe'],
39			[['type_id', 'state_id'], 'integer'],
40			[['type', 'state'], 'safe'],
41			[['used'], 'integer'],
42			[['note', 'label'], 'safe'],
43			[['is_personal'], 'boolean'],
44			[['id'], 'required', 'on' => ['delete']],
45			];
46			}
47
48			public function getResources()
49			{
50			if ($this->type === self::TYPE_DOMAIN) {
			0 ignored issues – show Documentation introduced 2016-08-18 14:58 UTC by Report Bug Copy Issue Report The property `type` does not exist on `object<hipanel\modules\finance\models\Tariff>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
51			return $this->hasMany(DomainResource::class, ['tariff_id' => 'id'])->inverseOf('tariff');
52			} elseif ($this->type === self::TYPE_SVDS \|\| $this->type === self::TYPE_OVDS) {
			0 ignored issues – show Documentation introduced 2016-08-26 16:35 UTC by Report Bug Copy Issue Report The property `type` does not exist on `object<hipanel\modules\finance\models\Tariff>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
53			return $this->hasMany(ServerResource::class, ['tariff_id' => 'id'])->inverseOf('tariff');
54			}
55
56			return $this->hasMany(Resource::class, ['tariff_id' => 'id'])->inverseOf('tariff');
57			}
58
59			/**
60			* @param $type
61			* @return DomainResource\|ServerResource\|Resource
62			*/
63			public function getResourceByType($type)
64			{
65			foreach ($this->resources as $resource) {
66			if ($resource->type === $type) {
67			return $resource;
68			}
69			}
70
71			return null;
72			}
73
74			/**
75			* {@inheritdoc}
76			*/
77			public function attributeLabels()
78			{
79			return $this->mergeAttributeLabels([
80			]);
81			}
82
83			/**
84			* {@inheritdoc}
85			* @return TariffQuery
86			*/
87			public static function find($options = [])
88			{
89			return new TariffQuery(get_called_class(), [
90			'options' => $options,
91			]);
92			}
93			}
94

hiqdev / hipanel-module-finance

Push — master ( b87a46...8351d4 )

Tariff::rules() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like