hipanel\modules\finance\forms\CertificateTariffForm

Complexity

Total Complexity

23

Size/Duplication

Total Lines	132
Duplicated Lines	56.82 %

Coupling/Cohesion

Components	2
Dependencies	5

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	load()	9	9	1
A	getPeriods()	0	4	1
B	setResources()	22	22	5
A	getCertificateTypes()	0	12	3
A	getCertificateTypeId()	0	4	1
B	getTypeResources()	22	22	5
A	setCertificateTypes()	0	4	1
B	getTypeParentResources()	22	22	5

<?php
/**
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\forms;

use hipanel\modules\finance\logic\IntegrityException;
use hipanel\modules\finance\models\CertificateResource;
use Yii;
use yii\web\UnprocessableEntityHttpException;

/**
 * Class CertificateTariffForm
 *
 * @author Dmytro Naumenko <d.naumenko.a@gmail.com>
 */
class CertificateTariffForm extends AbstractTariffForm
{
    protected $certificateTypes = [];

    public function __construct(array $config = [])
    {
        parent::__construct($config);
    }

    public function load($data, $formName = null)

This method seems to be duplicated in your project.

    {
        $this->setAttributes($data[$this->formName()]);
        $this->setResources($data[(new CertificateResource())->formName()]);

        $this->initTariff();

        return true;
    }

    /**
     * @return array
     */
    public static function getPeriods()
    {
        return CertificateResource::getPeriods();
    }

    public function setResources($resources)

This method seems to be duplicated in your project.

    {
        $result = [];
        foreach ($resources as $resource) {
            if ($resource instanceof CertificateResource) {
                $result[] = $resource;
                continue;
            }

            $model = new CertificateResource(['scenario' => $this->scenario]);

            if ($model->load($resource, '') && $model->validate()) {
                $result[] = $model;
            } else {
                throw new UnprocessableEntityHttpException('Failed to load resource model: ' . reset($model->getFirstErrors()));

$model->getFirstErrors() cannot be passed to reset() as the parameter $array expects a reference.

            }
        }

        $this->_resources = $result;

        return $this;
    }

    public function getCertificateTypes()
    {
        $result = [];

        foreach ($this->tariff->resources as $resource) {
            if (isset($this->certificateTypes[$resource->object_id])) {
                $result[$resource->object_id] = $this->certificateTypes[$resource->object_id];
            }
        }

        return $result;
    }

    protected function getCertificateTypeId($type)
    {
        return array_search($type, $this->certificateTypes, true);
    }

    /**
     * @param $type
     * @return CertificateResource[]
     * @throws IntegrityException
     */
    public function getTypeResources($type)

This method seems to be duplicated in your project.

    {
        $id = $this->getCertificateTypeId($type);

        $result = [];

        foreach ($this->tariff->resources as $resource) {
            if (strcmp($resource->object_id, $id) === 0 && $resource->isTypeCorrect()) {
                $result[$resource->type] = $resource;
            }
        }

        $types = $resource->getTypes();

The variable $resource seems to be defined by a foreach iteration on line 102. Are you sure the iterator is never empty, otherwise this variable is not defined?

        if (count($result) !== count($types)) {
            throw new IntegrityException('Found ' . count($result) . ' resources for certificate "' . $type . '". Must be exactly ' . count($types));
        }

        // sorts $result by order of $resource->getTypes()
        $result = array_merge($types, $result);

        return $result;
    }

    /**
     * @param array $certificateTypes
     */
    public function setCertificateTypes($certificateTypes)
    {
        $this->certificateTypes = $certificateTypes;
    }

    /**
     * @param $certificateType
     * @return CertificateResource[]
     * @throws IntegrityException
     */
    public function getTypeParentResources($certificateType)

This method seems to be duplicated in your project.

    {
        $id = $this->getCertificateTypeId($certificateType);

        $result = [];

        foreach ($this->parentTariff->resources as $resource) {
            if (strcmp($resource->object_id, $id) === 0 && $resource->isTypeCorrect()) {
                $result[$resource->type] = $resource;
            }
        }

        $types = $resource->getTypes();

The variable $resource seems to be defined by a foreach iteration on line 138. Are you sure the iterator is never empty, otherwise this variable is not defined?

        if (count($result) !== count($types)) {
            throw new IntegrityException('Found ' . count($result) . ' resources for certificate "' . $certificateType . '". Must be exactly ' . count($types));
        }

        // sorts $result by order of $resource->getTypes()
        $result = array_merge($types, $result);

        return $result;
    }
}