hipanel\modules\finance\controllers\TariffController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	62
Duplicated Lines	35.48 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

54.55%

Importance

Changes	7
Bugs	2	Features	2

4 Methods

Rating	Name	Duplication	Size	Complexity
B	actions()	0	28	1
A	actionCreateDomain()	11	11	3
A	actionUpdate()	11	11	3
A	actionView()	0	6	1

<?php

/*
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\controllers;

use hipanel\actions\IndexAction;
use hipanel\actions\OrientationAction;
use hipanel\actions\SearchAction;
use hipanel\actions\SmartPerformAction;
use hipanel\actions\SmartUpdateAction;
use hipanel\actions\ValidateFormAction;
use hipanel\actions\ViewAction;
use hipanel\modules\finance\logic\TariffManagerFactory;
use Yii;

class TariffController extends \hipanel\base\CrudController
{
    public function actions()
    {
        return [
            'set-orientation' => [
                'class' => OrientationAction::class,
                'allowedRoutes' => [
                    '@tariff/index'
                ]
            ],
            'index' => [
                'class' => IndexAction::class,
            ],
            'search' => [
                'class' => SearchAction::class,
            ],
            'validate-form' => [
                'class' => ValidateFormAction::class,
            ],
            'set-note' => [
                'class' => SmartUpdateAction::class,
                'success' => Yii::t('hipanel', 'Note updated'),
            ],
            'delete' => [
                'class' => SmartPerformAction::class,
                'success' => Yii::t('hipanel/finance/tariff', 'Tariff deleted'),
            ],
        ];
    }

    public function actionCreateDomain()

This method seems to be duplicated in your project.

    {
        $manager = TariffManagerFactory::createByType('domain');

        if (Yii::$app->request->isPost && $manager->model->load(Yii::$app->request->post())) {
            $manager->insert();
            return $this->redirect(['view', 'id' => $manager->model->id]);
        }

        return $this->render('domain/create', ['model' => $manager->model]);
    }

    public function actionUpdate($id)

This method seems to be duplicated in your project.

    {
        $manager = TariffManagerFactory::createById($id);

        if (Yii::$app->request->isPost && $manager->model->load(Yii::$app->request->post())) {
            $manager->update();
            return $this->redirect(['view', 'id' => $manager->model->id]);
        }

        return $this->render($manager->getType() . '/update', ['model' => $manager->model]);
    }

    public function actionView($id)
    {
        $manager = TariffManagerFactory::createById($id);

        return $this->render('view', ['manager' => $manager]);
    }
}